diff mbox

[dpdk-dev,1/5] test-devargs: fix misplaced braces in strncmp call

Message ID 1418820925-20318-2-git-send-email-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Olivier Matz Dec. 17, 2014, 12:55 p.m. UTC 
  One occurrence call to strncmp had the closing brace in the wrong
place. Changing this form:
	if (strncmp(X, Y, sizeof(X) != 0))
which does a comparison of length 1, to
	if (strncmp(X, Y, sizeof(X)) != 0)
which does the correct length comparison and then compares the result
to zero in the "if" part.

Seen with clang-3.5:
  "error: size argument in 'strncmp' call is a comparison"

This patch is similar to 261386248 but it looks that one occurence
was forgotten.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 app/test/test_devargs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c
index dcbdd09..3d9f7bc 100644
--- a/app/test/test_devargs.c
+++ b/app/test/test_devargs.c
@@ -105,7 +105,7 @@  test_devargs(void)
 		devargs->pci.addr.devid != 0 ||
 		devargs->pci.addr.function != 1)
 		goto fail;
-	if (strncmp(devargs->args, "", sizeof(devargs->args) != 0))
+	if (strncmp(devargs->args, "", sizeof(devargs->args)) != 0)
 		goto fail;
 	free_devargs_list();