From patchwork Wed Dec 17 05:13:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 2040 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A61F67F48; Wed, 17 Dec 2014 06:13:41 +0100 (CET) Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id A7CEF7F10 for ; Wed, 17 Dec 2014 06:13:37 +0100 (CET) Received: by mail-pa0-f41.google.com with SMTP id rd3so15642772pab.28 for ; Tue, 16 Dec 2014 21:13:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YDENCFbsy2Xj/0FmpCJYF4o+Wg4Q4GG0SRkyNjFdUHQ=; b=h6T8RPj+icASZQovwGqEhHlTbVOPIkQDk41CvDlbg1KXMdKHv9jJVaOf7QOQIlP16p lgFeYM6CwPNf3WwVoeziijIJCXfPBjREhe82OvMVHXxpP7ZvMDwPc9HNotXG67+EwVBu Hfh5Vj5MuXw6kPjnl0ts5kKnj+d+lqBkfVwKktyNQrikP1EYFUGLDC/hAGGTrkuAwBv6 ZbXYVQOKJkY7SlvwsVCMIr3FD7hxcrZdvs4zDVZAP2nRvEcFO3ItOt8KUV4bDHyQXHhX dk5V/Urf8dmDl69/Xv7zjSKZ9kUIvgEhBc0vbq+U3AjzoiQZGGG0x1+RZOIsMP08l7o3 ggMw== X-Gm-Message-State: ALoCoQmkLEghHjyXbfa/V1FW8p3Y6kAn029ZTxf8UVSGC8zc084W6QWwS9bCrKBcPNKnLXds2ben X-Received: by 10.68.208.65 with SMTP id mc1mr66462066pbc.111.1418793216311; Tue, 16 Dec 2014 21:13:36 -0800 (PST) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id gd1sm2518208pbd.67.2014.12.16.21.13.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Dec 2014 21:13:35 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Date: Tue, 16 Dec 2014 21:13:11 -0800 Message-Id: <1418793196-17953-3-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1418793196-17953-1-git-send-email-stephen@networkplumber.org> References: <1418793196-17953-1-git-send-email-stephen@networkplumber.org> Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 2/7] vmxnet3: remove mtu check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger Remove check for packets sending packets greater than MTU. No other driver does this, it should be handled at higher layer. Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 1 - lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 10 ---------- 3 files changed, 13 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c index 30d0659..4947c78 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c @@ -219,7 +219,6 @@ eth_vmxnet3_dev_init(__attribute__((unused)) struct eth_driver *eth_drv, hw->num_rx_queues = 1; hw->num_tx_queues = 1; - hw->cur_mtu = ETHER_MTU; hw->bufs_per_pkt = 1; /* Check h/w version compatibility with driver. */ @@ -394,7 +393,6 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev) devRead->misc.queueDescPA = hw->queueDescPA; devRead->misc.queueDescLen = hw->queue_desc_len; - devRead->misc.mtu = hw->cur_mtu; devRead->misc.numTxQueues = hw->num_tx_queues; devRead->misc.numRxQueues = hw->num_rx_queues; diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h index 2c180ad..258fbae 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h @@ -101,7 +101,6 @@ struct vmxnet3_hw { uint8_t num_tx_queues; uint8_t num_rx_queues; uint8_t bufs_per_pkt; - uint16_t cur_mtu; Vmxnet3_TxQueueDesc *tqd_start; /* start address of all tx queue desc */ Vmxnet3_RxQueueDesc *rqd_start; /* start address of all rx queue desc */ diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 9871f16..8e15784 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c @@ -369,16 +369,6 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, continue; } - /* Needs to minus ether header len */ - if (txm->data_len > (hw->cur_mtu + ETHER_HDR_LEN)) { - PMD_TX_LOG(DEBUG, "Packet data_len higher than MTU"); - rte_pktmbuf_free(tx_pkts[nb_tx]); - txq->stats.drop_total++; - - nb_tx++; - continue; - } - txd = (Vmxnet3_TxDesc *)(txq->cmd_ring.base + txq->cmd_ring.next2fill); if (rte_pktmbuf_pkt_len(txm) <= VMXNET3_HDR_COPY_SIZE) { struct Vmxnet3_TxDataDesc *tdd;