diff mbox

[dpdk-dev] app/test: fix multiprocess unit test when device is bound to uio

Message ID 1418305835-10031-1-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

De Lara Guarch, Pablo Dec. 11, 2014, 1:50 p.m. UTC
Since commit a155d4301 "support link bonding device initialization",
EAL probes drivers to the PCI devices in rte_eal_init,
then PCI resources are mapped if a device
is bound to igb_uio driver, for instance.
Therefore, test app probes all the devices and multiprocess unit test
tries to map resources twice in the secondary processes, and test fails,
caused by RTE_PCI_DRV_NEEDED_MAPPING flag in dummy pci driver my_driver2.

Test is fixed by setting the driver flags to 0.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test/test_pci.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

Comments

Thomas Monjalon Dec. 17, 2014, 12:11 a.m. UTC | #1
> Since commit a155d4301 "support link bonding device initialization",
> EAL probes drivers to the PCI devices in rte_eal_init,
> then PCI resources are mapped if a device
> is bound to igb_uio driver, for instance.
> Therefore, test app probes all the devices and multiprocess unit test
> tries to map resources twice in the secondary processes, and test fails,
> caused by RTE_PCI_DRV_NEEDED_MAPPING flag in dummy pci driver my_driver2.
> 
> Test is fixed by setting the driver flags to 0.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied

Thanks
diff mbox

Patch

diff --git a/app/test/test_pci.c b/app/test/test_pci.c
index 4f0169a..747d8b7 100644
--- a/app/test/test_pci.c
+++ b/app/test/test_pci.c
@@ -64,11 +64,6 @@  static unsigned pci_dev_count;
 static int my_driver_init(struct rte_pci_driver *dr,
 			  struct rte_pci_device *dev);
 
-/*
- * To test cases where RTE_PCI_DRV_NEED_MAPPING is set, and isn't set, two
- * drivers are created (one with IGB devices, the other with IXGBE devices).
- */
-
 /* IXGBE NICS */
 struct rte_pci_id my_driver_id[] = {
 
@@ -92,7 +87,7 @@  struct rte_pci_driver my_driver = {
 	.name = "test_driver",
 	.devinit = my_driver_init,
 	.id_table = my_driver_id,
-	.drv_flags = RTE_PCI_DRV_NEED_MAPPING,
+	.drv_flags = 0,
 };
 
 struct rte_pci_driver my_driver2 = {