| Message ID | 1418029178-25162-15-git-send-email-zlu@ezchip.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 10F998071; Mon, 8 Dec 2014 10:21:08 +0100 (CET) Received: from emea01-am1-obe.outbound.protection.outlook.com (mail-am1on0058.outbound.protection.outlook.com [157.56.112.58]) by dpdk.org (Postfix) with ESMTP id 193C0CE7 for <dev@dpdk.org>; Mon, 8 Dec 2014 10:02:02 +0100 (CET) Received: from DB4PR02CA0038.eurprd02.prod.outlook.com (10.242.174.166) by AM3PR02MB001.eurprd02.prod.outlook.com (10.242.242.12) with Microsoft SMTP Server (TLS) id 15.1.26.15; Mon, 8 Dec 2014 09:02:00 +0000 Received: from AM1FFO11FD046.protection.gbl (2a01:111:f400:7e00::121) by DB4PR02CA0038.outlook.office365.com (2a01:111:e400:983b::38) with Microsoft SMTP Server (TLS) id 15.1.31.17 via Frontend Transport; Mon, 8 Dec 2014 09:02:00 +0000 Received: from bjgfarm-1.internal.tilera.com (124.207.145.166) by AM1FFO11FD046.mail.protection.outlook.com (10.174.65.209) with Microsoft SMTP Server (TLS) id 15.1.26.17 via Frontend Transport; Mon, 8 Dec 2014 09:01:59 +0000 Received: (from zlu@localhost) by bjgfarm-1.internal.tilera.com (8.14.4/8.14.4/Submit) id sB891tdh025274; Mon, 8 Dec 2014 17:01:55 +0800 From: Zhigang Lu <zlu@ezchip.com> To: <dev@dpdk.org> Date: Mon, 8 Dec 2014 16:59:37 +0800 Message-ID: <1418029178-25162-15-git-send-email-zlu@ezchip.com> X-Mailer: git-send-email 2.1.2 In-Reply-To: <1418029178-25162-1-git-send-email-zlu@ezchip.com> References: <1418029178-25162-1-git-send-email-zlu@ezchip.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:124.207.145.166; CTRY:CN; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(189002)(199003)(64706001)(31966008)(62966003)(48376002)(20776003)(50986999)(99396003)(76176999)(107046002)(77156002)(105606002)(21056001)(106466001)(120916001)(2351001)(68736005)(229853001)(89996001)(19580405001)(36756003)(87936001)(46102003)(50466002)(47776003)(6806004)(97736003)(86362001)(19580395003)(92566001)(110136001)(104016003)(84676001)(42186005)(33646002)(4396001)(50226001)(9376004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR02MB001; H:bjgfarm-1.internal.tilera.com; FPR:; SPF:Fail; MLV:sfv; PTR:InfoDomainNonexistent; MX:3; A:1; LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB001; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(602002); SRVR:AM3PR02MB001; X-Forefront-PRVS: 041963B986 Received-SPF: Fail (protection.outlook.com: domain of ezchip.com does not designate 124.207.145.166 as permitted sender) receiver=protection.outlook.com; client-ip=124.207.145.166; helo=bjgfarm-1.internal.tilera.com; Authentication-Results: spf=fail (sender IP is 124.207.145.166) smtp.mailfrom=zlu@ezchip.com; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:AM3PR02MB001; X-OriginatorOrg: ezchip.com X-Mailman-Approved-At: Mon, 08 Dec 2014 10:20:50 +0100 Cc: Cyril Chemparathy <cchemparathy@ezchip.com> Subject: [dpdk-dev] [PATCH 14/15] app/test: turn off cpu flag checks for tile architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Zhigang Lu
Dec. 8, 2014, 8:59 a.m. UTC
Tile processor doesn't have CPU flag hardware registers, so this patch turns off cpu flag checks for tile. Signed-off-by: Zhigang Lu <zlu@ezchip.com> Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com> --- app/test/test_cpuflags.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Dec 08, 2014 at 04:59:37PM +0800, Zhigang Lu wrote: > Tile processor doesn't have CPU flag hardware registers, so this patch > turns off cpu flag checks for tile. > > Signed-off-by: Zhigang Lu <zlu@ezchip.com> > Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com> > --- > app/test/test_cpuflags.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c > index 5aeba5d..da93af5 100644 > --- a/app/test/test_cpuflags.c > +++ b/app/test/test_cpuflags.c > @@ -113,7 +113,7 @@ test_cpuflags(void) > > printf("Check for ICACHE_SNOOP:\t\t"); > CHECK_FOR_FLAG(RTE_CPUFLAG_ICACHE_SNOOP); > -#else > +#elif !defined(RTE_ARCH_TILE) > printf("Check for SSE:\t\t"); > CHECK_FOR_FLAG(RTE_CPUFLAG_SSE); > Please stop this. It doesn't make sense for a library that supports multiple arches, we need some way to generically test for flags that doesn't involve forcing applications to do ton's of ifdeffing. Perhaps rte_cpu_get_flag_enabled needs to do a flag table lookup based on the detected arch at run time, and return the appropriate response. In the case of tile, it can just be an empty table, so 0 is always returned. But making an application responsible for doing arch checks is a guarantee to write non-portable applications Neil > -- > 2.1.2 > >
diff --git a/app/test/test_cpuflags.c b/app/test/test_cpuflags.c index 5aeba5d..da93af5 100644 --- a/app/test/test_cpuflags.c +++ b/app/test/test_cpuflags.c @@ -113,7 +113,7 @@ test_cpuflags(void) printf("Check for ICACHE_SNOOP:\t\t"); CHECK_FOR_FLAG(RTE_CPUFLAG_ICACHE_SNOOP); -#else +#elif !defined(RTE_ARCH_TILE) printf("Check for SSE:\t\t"); CHECK_FOR_FLAG(RTE_CPUFLAG_SSE);