diff mbox

[dpdk-dev] eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment

Message ID 1414640408-10118-1-git-send-email-mhall@mhcomputing.net (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Matthew Hall Oct. 30, 2014, 3:40 a.m. UTC
Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
---
 lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Oct. 30, 2014, 9:57 a.m. UTC | #1
On Thu, Oct 30, 2014 at 03:40:08AM +0000, Matthew Hall wrote:
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 5fe3961..ddb0535 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -266,7 +266,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
>  	snprintf(filename, sizeof(filename), "%s/numa_node",
>  		 dirname);
>  	if (access(filename, R_OK) != 0) {
> -		/* if no NUMA support just set node to 0 */
> +		/* if no NUMA support just set node to -1 */
>  		dev->numa_node = -1;
>  	} else {
>  		if (eal_parse_sysfs_value(filename, &tmp) < 0) {
> -- 
> 1.9.1
>
Thomas Monjalon Nov. 5, 2014, 9:52 p.m. UTC | #2
> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied

Thanks
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 5fe3961..ddb0535 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -266,7 +266,7 @@  pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
 	snprintf(filename, sizeof(filename), "%s/numa_node",
 		 dirname);
 	if (access(filename, R_OK) != 0) {
-		/* if no NUMA support just set node to 0 */
+		/* if no NUMA support just set node to -1 */
 		dev->numa_node = -1;
 	} else {
 		if (eal_parse_sysfs_value(filename, &tmp) < 0) {