diff mbox

[dpdk-dev] ixgbe: Fix compilation issue in vpmd

Message ID 1413874756-18669-1-git-send-email-changchun.ouyang@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Ouyang Changchun Oct. 21, 2014, 6:59 a.m. UTC 
  Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT is disabled.

Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
 lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon Oct. 21, 2014, 8:04 a.m. UTC | #1 
2014-10-21 14:59, Ouyang Changchun:
> Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT is disabled.
> 
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

Thanks
De Lara Guarch, Pablo Oct. 21, 2014, 8:19 a.m. UTC | #2 
Hi Thomas,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, October 21, 2014 9:04 AM
> To: Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> 2014-10-21 14:59, Ouyang Changchun:
> > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT is
> disabled.
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> 
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Applied

I was checking this patch right now, and I come across a second compilation issue,
 because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not declared, 
and Bond PMD and IP fragmentation libraries use those functions.

I guess that it is late to NACK this :P, but we require a second patch 
to fix completely this issue.

> 
> Thanks
> --
> Thomas
Ouyang Changchun Oct. 21, 2014, 8:28 a.m. UTC | #3 
Hi Pablo

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, October 21, 2014 4:19 PM
> To: Thomas Monjalon; Ouyang, Changchun
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> Hi Thomas,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Tuesday, October 21, 2014 9:04 AM
> > To: Ouyang, Changchun
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> >
> > 2014-10-21 14:59, Ouyang Changchun:
> > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > is
> > disabled.
> > >
> > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> >
> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> >
> > Applied
> 
> I was checking this patch right now, and I come across a second compilation
> issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> declared, and Bond PMD and IP fragmentation libraries use those functions.
> 
> I guess that it is late to NACK this :P, but we require a second patch to fix
> completely this issue.
As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)
In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
Yes, agree with you, we need another patch to fix compilation issue in other both places.
Thomas Monjalon Oct. 21, 2014, 8:36 a.m. UTC | #4 
2014-10-21 08:28, Ouyang, Changchun:
> From: De Lara Guarch, Pablo
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > 2014-10-21 14:59, Ouyang Changchun:
> > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > > is disabled.
> > > >
> > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > >
> > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > >
> > > Applied
> > 
> > I was checking this patch right now, and I come across a second compilation
> > issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> > declared, and Bond PMD and IP fragmentation libraries use those functions.
> > 
> > I guess that it is late to NACK this :P, but we require a second patch to fix
> > completely this issue.
> 
> As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)

Exact

> In my config, both BOND and IP fragment is disabled. So I don't come across your issues.
> Yes, agree with you, we need another patch to fix compilation issue in other both places.

Yes, I'm aware of these limitations.
Please, first explain why mbuf refcnt is needed for these features.
Then we have 2 options: remove the dependency or add more ifdefs.

Thanks
Doherty, Declan Oct. 21, 2014, 1:45 p.m. UTC | #5 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, October 21, 2014 9:36 AM
> To: Ouyang, Changchun; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix compilation issue in vpmd
> 
> 2014-10-21 08:28, Ouyang, Changchun:
> > From: De Lara Guarch, Pablo
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > > 2014-10-21 14:59, Ouyang Changchun:
> > > > > Fix the compilation issue in vector PMD when macro RTE_MBUF_REFCNT
> > > > > is disabled.
> > > > >
> > > > > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> > > >
> > > > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > > >
> > > > Applied
> > >
> > > I was checking this patch right now, and I come across a second compilation
> > > issue,  because rte_mbuf_refcnt_update and rte_pktmbuf_attach are not
> > > declared, and Bond PMD and IP fragmentation libraries use those functions.
> > >
> > > I guess that it is late to NACK this :P, but we require a second patch to fix
> > > completely this issue.
> >
> > As it fixes the compilation issue in vpmd, so no reason to NACK it,  :-)
> 
> Exact
> 
> > In my config, both BOND and IP fragment is disabled. So I don't come across your
> issues.
> > Yes, agree with you, we need another patch to fix compilation issue in other
> both places.
> 
> Yes, I'm aware of these limitations.
> Please, first explain why mbuf refcnt is needed for these features.
> Then we have 2 options: remove the dependency or add more ifdefs.
> 
> Thanks
> --
> Thomas

Thomas, 
for link bonding the refcnt is used in broadcast mode to allow the same
mbuf to be transmitted on multiple slaves. By increasing the refcnt, we 
can safely transmit the mbuf on multiple slaves without the danger of a 
mbuf being freed by one slave while in use by another. I can provide a patch to
disable the broadcast mode of operation if the bonding pmd is built with the macro 
RTE_MBUF_REFCNT disabled. I don't think there is any other option other than 
than to completely disable the library if the refcnt parameter isn't available
as we don't have access to the transmit mempool to allocate new mbufs to
make copies of the original. 

Declan
diff mbox

Patch

diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
index 2236250..a0d3d78 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
@@ -541,7 +541,7 @@  ixgbe_tx_free_bufs(struct igb_tx_queue *txq)
 #ifdef RTE_MBUF_REFCNT
 			m = __rte_pktmbuf_prefree_seg(txep[i].mbuf);
 #else
-			m = txep[i]->mbuf;
+			m = txep[i].mbuf;
 #endif
 			if (likely(m != NULL)) {
 				if (likely(m->pool == free[0]->pool))