diff mbox

[dpdk-dev] virtio-net-pmd: .gitignore: ignore librte_pmd_virtio.so

Message ID 1413273236-1873-1-git-send-email-mhall@mhcomputing.net (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Matthew Hall Oct. 14, 2014, 7:53 a.m. UTC
Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

Comments

Bruce Richardson Oct. 14, 2014, 9:44 a.m. UTC | #1
On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
> Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index e69de29..08d831a 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -0,0 +1 @@
> +librte_pmd_virtio.so
> -- 
> 1.9.1
> 

I thought our .gitignore could do with a few entries added alright, I just 
never expected this one to be top of the list! While I don't think it does 
any harm, I'm just curious why you think it needs to be added?

/Bruce
Stephen Hemminger Oct. 14, 2014, 9:52 a.m. UTC | #2
On Tue, 14 Oct 2014 10:44:16 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> On Tue, Oct 14, 2014 at 07:53:56AM +0000, Matthew Hall wrote:
> > Signed-off-by: Matthew Hall <mhall@mhcomputing.net>
> > ---
> >  .gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index e69de29..08d831a 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -0,0 +1 @@
> > +librte_pmd_virtio.so
> > -- 
> > 1.9.1
> > 
> 
> I thought our .gitignore could do with a few entries added alright, I just 
> never expected this one to be top of the list! While I don't think it does 
> any harm, I'm just curious why you think it needs to be added?
> 
> /Bruce

Why not add *.so to ignore all built shared libraries
Matthew Hall Oct. 14, 2014, 3:38 p.m. UTC | #3
I import all my DPDK dependencies as git submodules. When the submodules contain unignored files, they get marked as dirty by git, and it makes like difficult when it comes to updating my submodule pointers.

Matthew.
Matthew Hall Oct. 14, 2014, 3:40 p.m. UTC | #4
Sure, I can put the classic C gitignore entries in there if you guys prefer. I was just trying to make the minimum change to get it to work right for my environment.
Thomas Monjalon Oct. 14, 2014, 4:09 p.m. UTC | #5
> >I thought our .gitignore could do with a few entries added alright, I
> >just never expected this one to be top of the list! While I don't think
> >it does any harm, I'm just curious why you think it needs to be added?
> >
> >/Bruce
> 
> I import all my DPDK dependencies as git submodules. When the submodules
> contain unignored files, they get marked as dirty by git, and it makes
> like difficult when it comes to updating my submodule pointers.
> 
> Matthew.

So you cannot update submodules without filling .gitignore?

I'm not a big fan of .gitignore because I like seeing what has been
generated by looking at "git status".
And it's not really needed in DPDK because compilation is often done in
a separate directory.
Matthew Hall Oct. 14, 2014, 4:12 p.m. UTC | #6
In the virtio-net-pmd it is done in the same directory. Hence me submitting this to try to make it easier for others to use the product.

Also the default DPDK doesn't ignore the build target directories... but I already had to fork that one to fix clang compile failures in the examples files.

Matthew.
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index e69de29..08d831a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -0,0 +1 @@ 
+librte_pmd_virtio.so