diff mbox

[dpdk-dev,2/2] librte_pmd_null: Enable librte_pmd_null

Message ID 1412070970-5625-3-git-send-email-mukawa@igel.co.jp (mailing list archive)
State Superseded, archived
Headers

Commit Message

Tetsuya Mukawa Sept. 30, 2014, 9:56 a.m. UTC 
  From: Tetsuya Mukawa <mukawa@igel.co.jp>

Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
---
 mk/rte.app.mk | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Neil Horman Sept. 30, 2014, 11:23 a.m. UTC | #1 
On Tue, Sep 30, 2014 at 06:56:10PM +0900, mukawa@igel.co.jp wrote:
> From: Tetsuya Mukawa <mukawa@igel.co.jp>
> 
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> ---
>  mk/rte.app.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 34dff2a..f059290 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -179,6 +179,10 @@ LDLIBS += -lrte_pmd_xenvirt
>  LDLIBS += -lxenstore
>  endif
>  
> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)
> +LDLIBS += -lrte_pmd_null
> +endif
> +
You don't need to add this, as the pmd can be loaded dynamically via the dlopen
call executed via the -d option on the test app command line.  The only pmds
that need explicit linking are those that offer additional API calls to an
appilcation.

Neil

>  ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
>  # plugins (link only if static libraries)
>  
> -- 
> 1.9.1
> 
>
Tetsuya Mukawa Oct. 1, 2014, 1:39 a.m. UTC | #2 
(2014/09/30 20:23), Neil Horman wrote:
> On Tue, Sep 30, 2014 at 06:56:10PM +0900, mukawa@igel.co.jp wrote:
>> From: Tetsuya Mukawa <mukawa@igel.co.jp>
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
>> ---
>>  mk/rte.app.mk | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
>> index 34dff2a..f059290 100644
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -179,6 +179,10 @@ LDLIBS += -lrte_pmd_xenvirt
>>  LDLIBS += -lxenstore
>>  endif
>>  
>> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)
>> +LDLIBS += -lrte_pmd_null
>> +endif
>> +
> You don't need to add this, as the pmd can be loaded dynamically via the dlopen
> call executed via the -d option on the test app command line.  The only pmds
> that need explicit linking are those that offer additional API calls to an
> appilcation.
Thanks, I will change above.

Regards,
Tetsuya


> Neil
>
>>  ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
>>  # plugins (link only if static libraries)
>>  
>> -- 
>> 1.9.1
>>
>>
diff mbox

Patch

diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 34dff2a..f059290 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -179,6 +179,10 @@  LDLIBS += -lrte_pmd_xenvirt
 LDLIBS += -lxenstore
 endif
 
+ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)
+LDLIBS += -lrte_pmd_null
+endif
+
 ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)
 # plugins (link only if static libraries)