Message ID | 1411883352-22166-1-git-send-email-huawei.xie@intel.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 339937E20; Sun, 28 Sep 2014 07:43:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 589147E1B for <dev@dpdk.org>; Sun, 28 Sep 2014 07:43:10 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 27 Sep 2014 22:40:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,613,1406617200"; d="scan'208";a="597845200" Received: from shvmail01.sh.intel.com ([10.239.29.42]) by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2014 22:49:18 -0700 Received: from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com [10.239.29.90]) by shvmail01.sh.intel.com with ESMTP id s8S5nGPh002650; Sun, 28 Sep 2014 13:49:16 +0800 Received: from shecgisg003.sh.intel.com (localhost [127.0.0.1]) by shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP id s8S5nD0N022201; Sun, 28 Sep 2014 13:49:15 +0800 Received: (from hxie5@localhost) by shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id s8S5nDr9022197; Sun, 28 Sep 2014 13:49:13 +0800 From: Huawei Xie <huawei.xie@intel.com> To: dev@dpdk.org Date: Sun, 28 Sep 2014 13:49:12 +0800 Message-Id: <1411883352-22166-1-git-send-email-huawei.xie@intel.com> X-Mailer: git-send-email 1.7.4.1 Subject: [dpdk-dev] [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Huawei Xie
Sept. 28, 2014, 5:49 a.m. UTC
the right shift bits should be 5 rather than 4.
vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F)
Signed-off-by: Huawei Xie <huawei.xie@intel.com>
CC: Jing Chen <jing.d.chen@intel.com>
CC: Helin Zhang <helin.zhang@intel.com>
---
lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
Comments
> -----Original Message----- > From: Xie, Huawei > Sent: Sunday, September 28, 2014 1:49 PM > To: dev@dpdk.org > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix > > the right shift bits should be 5 rather than 4. > vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F) > > Signed-off-by: Huawei Xie <huawei.xie@intel.com> > CC: Jing Chen <jing.d.chen@intel.com> > CC: Helin Zhang <helin.zhang@intel.com> > > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 9009bd4..9c9d831 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > { > uint32_t vid_idx, vid_bit; > > -#define UINT32_BIT_MASK 0x1F > -#define VALID_VLAN_BIT_MASK 0xFFF > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find > the > * element first, then find the bits it belongs to > */ > - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > - sizeof(uint32_t)); > - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); > + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); > > if (on) > vsi->vfta[vid_idx] |= vid_bit; > -- > 1.8.1.4 Please try to use macro to replace numbers.
Thomas, comments for this patch? > -----Original Message----- > From: Xie, Huawei > Sent: Saturday, September 27, 2014 10:49 PM > To: dev@dpdk.org > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix > > the right shift bits should be 5 rather than 4. > vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F) > > Signed-off-by: Huawei Xie <huawei.xie@intel.com> > CC: Jing Chen <jing.d.chen@intel.com> > CC: Helin Zhang <helin.zhang@intel.com> > > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 9009bd4..9c9d831 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > { > uint32_t vid_idx, vid_bit; > > -#define UINT32_BIT_MASK 0x1F > -#define VALID_VLAN_BIT_MASK 0xFFF > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the > * element first, then find the bits it belongs to > */ > - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > - sizeof(uint32_t)); > - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); > + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); > > if (on) > vsi->vfta[vid_idx] |= vid_bit; > -- > 1.8.1.4
2014-11-06 00:22, Xie, Huawei: > Thomas, comments for this patch? No, but Jing Chen made some comments that you didn't replied: "Please try to use macro to replace numbers." So I wait a v2. > > -----Original Message----- > > From: Xie, Huawei > > Sent: Saturday, September 27, 2014 10:49 PM > > To: dev@dpdk.org > > Cc: Xie, Huawei; Chen, Jing D; Zhang, Helin > > Subject: [PATCH] lib/librte_pmd_i40e: i40e vlan filter set fix > > > > the right shift bits should be 5 rather than 4. > > vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F) > > > > Signed-off-by: Huawei Xie <huawei.xie@intel.com> > > CC: Jing Chen <jing.d.chen@intel.com> > > CC: Helin Zhang <helin.zhang@intel.com> > > > > --- > > lib/librte_pmd_i40e/i40e_ethdev.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > > b/lib/librte_pmd_i40e/i40e_ethdev.c > > index 9009bd4..9c9d831 100644 > > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > > @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, > > { > > uint32_t vid_idx, vid_bit; > > > > -#define UINT32_BIT_MASK 0x1F > > -#define VALID_VLAN_BIT_MASK 0xFFF > > /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the > > * element first, then find the bits it belongs to > > */ > > - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> > > - sizeof(uint32_t)); > > - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); > > + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); > > + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); > > > > if (on) > > vsi->vfta[vid_idx] |= vid_bit; > > -- > > 1.8.1.4
diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c index 9009bd4..9c9d831 100644 --- a/lib/librte_pmd_i40e/i40e_ethdev.c +++ b/lib/librte_pmd_i40e/i40e_ethdev.c @@ -3786,14 +3786,11 @@ i40e_set_vlan_filter(struct i40e_vsi *vsi, { uint32_t vid_idx, vid_bit; -#define UINT32_BIT_MASK 0x1F -#define VALID_VLAN_BIT_MASK 0xFFF /* VFTA is 32-bits size array, each element contains 32 vlan bits, Find the * element first, then find the bits it belongs to */ - vid_idx = (uint32_t) ((vlan_id & VALID_VLAN_BIT_MASK) >> - sizeof(uint32_t)); - vid_bit = (uint32_t) (1 << (vlan_id & UINT32_BIT_MASK)); + vid_idx = (uint32_t) ((vlan_id >> 5 ) & 0x7F); + vid_bit = (uint32_t) (1 << (vlan_id & 0x1F)); if (on) vsi->vfta[vid_idx] |= vid_bit;