From patchwork Tue Aug 29 15:35:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 28064 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 9E5032E8F; Tue, 29 Aug 2017 17:35:29 +0200 (CEST) Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 369522BD0 for ; Tue, 29 Aug 2017 17:35:27 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id b14so20939569wme.0 for ; Tue, 29 Aug 2017 08:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=6aIN363YeOKgGeaDDjhbeIh/ETVlt0aUPlMBHalRZIA=; b=GL+FcBuGzQF6HSqH9P76GqwRpIwbJI7faULeA04wfQqEfSjpeDMm8hV6I3e2vR70I4 pL4w5Yk3yAcrKxBqrVMy+LqUTblVzO641isYKAF34xdgHAueowJqSKfmmmtV2UZzcVUc PFhaUwGXQrSsCxV2teFZpMo4//T4UTdVxqvz26PX6d0htKWeXaFxn6lkboUh7PwnQHXj eAVveKl/TD7/BLtnFdhnaCsaWCtIhhbtDr6edzArCNi845y9Oij9JfXoikWQHK1e6NLL Rl6ZWvDgJf1U5IlJn3HDMNu0LbO8ABBONn4fqpix9URNIeDXDvMfdk8mCjJqgHm0Lfzq ivFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=6aIN363YeOKgGeaDDjhbeIh/ETVlt0aUPlMBHalRZIA=; b=PCs+oxgMNZAYuUkCpRzT04yPaQuYSokIktKCIdj4Q47vurk3cANO2iVhCZmKd++Lrx 1cR94cIDtFD8uCX3tx82BkgSR1BNEdJjiE5TXyLW8CF5kVekBzdF2iCVZmsesmZKAtfu 9UOKYjhtskKdOjDfYwo/fcLHEXJevL6WmpMyTGoU9nmtVEhLGTy/0XS5X4X+xUtHBrkR WMnOHueJNGEd+3rfxdB3vwPp9gtiNggAD8twL2OmpoAlBqKX7Jiv7d0yFKFtb76tcmdg mcjuC2zvUH7HR/npdVJmSBvCi528xP/kl6cCPPBLMwel4kLE6NQtFiYh5XjcSj4aIoU3 QQ+g== X-Gm-Message-State: AHYfb5jICVK8ljQFTNl5qWxcUj4FLbDldU7NrSnDS/d/m7I9jmc1ntOs Pz1oERGdb6mQLurwe0fNeg== X-Received: by 10.28.144.4 with SMTP id s4mr19704wmd.89.1504020926686; Tue, 29 Aug 2017 08:35:26 -0700 (PDT) Received: from ping.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t5sm1794344wma.44.2017.08.29.08.35.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 29 Aug 2017 08:35:26 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: stable@dpdk.org Date: Tue, 29 Aug 2017 17:35:03 +0200 Message-Id: <139a20a84bf2455ac0ded98984016f5557b75604.1504020810.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <20f8cf112084a36f203b80e212a9f08463bd3c91.1504020810.git.nelio.laranjeiro@6wind.com> References: <20f8cf112084a36f203b80e212a9f08463bd3c91.1504020810.git.nelio.laranjeiro@6wind.com> In-Reply-To: <20f8cf112084a36f203b80e212a9f08463bd3c91.1504020810.git.nelio.laranjeiro@6wind.com> References: <20f8cf112084a36f203b80e212a9f08463bd3c91.1504020810.git.nelio.laranjeiro@6wind.com> Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: improve stack usage during link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Allocate no more memory than necessary for the second call to ETHTOOL_GLINKSETTINGS. Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 0d2dae4..5af4d89 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -113,7 +113,6 @@ struct ethtool_link_settings { #define ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT 38 #define ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT 39 #endif -#define ETHTOOL_LINK_MODE_MASK_MAX_KERNEL_NU32 (SCHAR_MAX) /** * Return private structure associated with an Ethernet device. @@ -805,11 +804,7 @@ static int mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) { struct priv *priv = mlx5_get_priv(dev); - alignas(struct ethtool_link_settings) - uint8_t data[offsetof(struct ethtool_link_settings, link_mode_masks) + - sizeof(uint32_t) * - ETHTOOL_LINK_MODE_MASK_MAX_KERNEL_NU32 * 3]; - struct ethtool_link_settings *ecmd = (void *)data; + struct ethtool_link_settings gcmd = { .cmd = ETHTOOL_GLINKSETTINGS }; struct ifreq ifr; struct rte_eth_link dev_link; uint64_t sc; @@ -822,15 +817,21 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, int wait_to_complete) memset(&dev_link, 0, sizeof(dev_link)); dev_link.link_status = ((ifr.ifr_flags & IFF_UP) && (ifr.ifr_flags & IFF_RUNNING)); - memset(ecmd, 0, sizeof(*ecmd)); - ecmd->cmd = ETHTOOL_GLINKSETTINGS; - ifr.ifr_data = (void *)ecmd; + ifr.ifr_data = (void *)&gcmd; if (priv_ifreq(priv, SIOCETHTOOL, &ifr)) { DEBUG("ioctl(SIOCETHTOOL, ETHTOOL_GLINKSETTINGS) failed: %s", strerror(errno)); return -1; } - ecmd->link_mode_masks_nwords = -ecmd->link_mode_masks_nwords; + gcmd.link_mode_masks_nwords = -gcmd.link_mode_masks_nwords; + + alignas(struct ethtool_link_settings) + uint8_t data[offsetof(struct ethtool_link_settings, link_mode_masks) + + sizeof(uint32_t) * gcmd.link_mode_masks_nwords]; + struct ethtool_link_settings *ecmd = (void *)data; + + *ecmd = gcmd; + ifr.ifr_data = (void *)ecmd; if (priv_ifreq(priv, SIOCETHTOOL, &ifr)) { DEBUG("ioctl(SIOCETHTOOL, ETHTOOL_GLINKSETTINGS) failed: %s", strerror(errno));