From patchwork Wed Jul 11 06:49:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 42791 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC8571B3B5; Wed, 11 Jul 2018 08:49:56 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id E29B21B3AB for ; Wed, 11 Jul 2018 08:49:55 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id h9-v6so16917389wro.3 for ; Tue, 10 Jul 2018 23:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=VabHBNqyoas6ywMHCbRQtQlsaWK5Lh+Ln/xnMvqguzg=; b=yvt92jwecSqMkV1BvsUPM1Y76JuRjiC2GpDqBsNwLpdPYMHQoD5dMSKg4ui9XlLdaU FlEoO3OnhrBV6+lgF51Wi6r1C7uGP5N0Clq7Ou4mfyaZrxdsrfzdvxWqeLAVDu6gQW5D dtRPO2wOpKzOZp/ThXJ1POnbFJdyxqgxFXzQ7V0wezmixIpwTlO7NK69YXflqrDbv6lt yLcdSwCqHccdOKe8k5dVUFalapVpLuynPylhMmhE1UscfvPcTdG38E1uaADdo17ncZn0 bxcQUmrw6yYHI1b1IyKttRnj6g2O45iS46a60ZnO0LtrLoW1CqSthLt6HIHG1eo2U55Z JBCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=VabHBNqyoas6ywMHCbRQtQlsaWK5Lh+Ln/xnMvqguzg=; b=HahJT6ExgwmL78IyMLMK8/rjW0GLule3Ri0EAw6xRCZ0sr8gJZwqQ0GWeAjngeA5LJ NCTESqHeXq31ci+JxuaUxK/yx2uKhH/Kp2yetkAhJJdupOABn1RP+xYojV/24sQgfvi6 eOHfgUGJdIlQSnlLVk75tU3rkpxtRtytgHmi+JkW501zMO550a3lRRU5w8S3Pbojflpq jxfepry6N8HuLEBvfVmBKKgYMjUTGbX8aG3I1sUf1NNoeH8f+RFoAt82yZ4WA9Fuv+dN AdQNnhLb8aBVe7ED1ziGX6aomNx3+cOWg4e8eh6OwxtXQiCxwLQ+Vbdj+AqQIXX14VPN sv+g== X-Gm-Message-State: APt69E0XEJarQ/eJyctftHFJZRBlRppEU9N+8xJYhi0NGO/dC2SKS9Dm FINvdNgK10v3ubtlOYmJIvH06snEIQ== X-Google-Smtp-Source: AAOMgpcgeQInPBi+m6iwpGwjEgONfOi5sG9T1vWwsDVw3MUbUdsC4U65mQoYU1ko8cbNc3qaj+6mMQ== X-Received: by 2002:adf:b1d2:: with SMTP id r18-v6mr21316701wra.79.1531291795358; Tue, 10 Jul 2018 23:49:55 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b7-v6sm1831918wme.39.2018.07.10.23.49.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 23:49:54 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org, Adrien Mazarguil Date: Wed, 11 Jul 2018 08:49:35 +0200 Message-Id: <0f6611f2322f21df8e64682a6b8d74ab21983178.1531291755.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.18.0 Subject: [dpdk-dev] [PATCH] ethdev: fix flow expansion matching types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Node RSS types are generally covering more RSS kind than the user is requesting, it should accept to expand even if only a single bit is remains after masking. Setting the correct RSS kind for the rule remains the driver job. Fixes: 959823ce4c47 ("ethdev: add flow API to expand RSS flows") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- lib/librte_ethdev/rte_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c index 2b13efca7..e06cc2193 100644 --- a/lib/librte_ethdev/rte_flow.c +++ b/lib/librte_ethdev/rte_flow.c @@ -585,7 +585,7 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size, node = next_node ? &graph[*next_node] : NULL; while (node) { flow_items[stack_pos].type = node->type; - if ((node->rss_types & types) == node->rss_types) { + if (node->rss_types & types) { /* * compute the number of items to copy from the * expansion and copy it.