From patchwork Wed Mar 29 07:51:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 22670 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A7A8F5A8D; Wed, 29 Mar 2017 09:55:26 +0200 (CEST) Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id A422937B4 for ; Wed, 29 Mar 2017 09:51:56 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id l43so4956342wre.1 for ; Wed, 29 Mar 2017 00:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kn0jH8lz14Z/e91SYNp8ZvWI7P5+hDLqrxMjJoqjRqY=; b=wj8eYfHr1VIPnzUM9mwO+aixxsLP4ZFFwRr0Bctd8HL1Zb1/WGnxKnHbE8CcoIX3Hl AGcsmoq2Hq5ZGghPJeKKklP5Xbxqf7nxeBar+GYeePvSItEZzcB/ee9067j6EMWNu2G/ splQkb0uy1d7ZmMi8nrrJg0Vrd8dkrnDjihENCEalAeoh96Aoihw38ieqWT5hpggWnnu YOrfSbSGWcnbbnvp2czW2EEH+MgyP7BleNpHHeBYmAW8TCcaLLjnqecItrkWN47F7TdG u1Hx8QbFW9whuwWNQRVBCwU5cplHhnx4GodkwnkJuGy4Q0KwyQJ+5Prz+c2gULcKc3p8 6jGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kn0jH8lz14Z/e91SYNp8ZvWI7P5+hDLqrxMjJoqjRqY=; b=Zvw6MD8vQtu/2LO0oiZgWk0M6hMz2siIOndbjHx+GRLCYyqfQm933WfuScmrPnAXNq EvZpS/l2DI5QUfazWjdZIs+/9r8MVlmGv9sAvecsz3ou2XYE7juKY+11HzK5vOmfIHgD mGktjtP2Fni25inOCs0AfyRHQZ2BkcF0AN8jXpSUgByjVKFPwM48F9ASWvsAV7hr+OAF lQaDjy6vWvT5t1moLDKbD9vzdfC3T4Q5GwQ946tHahousGazzF0v7+nFOvZCk7eCix1G /xj/xbBnu367X7/XBz8mJovCLDo/TR/l2lRzFFCW29OtbViFBaOmNHbQlddQbmNWRHLj 0xFA== X-Gm-Message-State: AFeK/H3u8YM633TrJX5AecapjRJVABrwxlxDFNXOFI4ByrKxurVcCkRlJaaw/i2BoO24NYdp X-Received: by 10.223.146.132 with SMTP id 4mr5095115wrn.91.1490773916253; Wed, 29 Mar 2017 00:51:56 -0700 (PDT) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z40sm8128774wrz.67.2017.03.29.00.51.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Mar 2017 00:51:55 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , Yongseok Koh , stable@dpdk.org Date: Wed, 29 Mar 2017 09:51:39 +0200 Message-Id: <0765108e11b5128da9f6d403d87e3e42d0adffdd.1490773336.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx when first segment size is too short X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" First segment size must be at least 18 bytes, packets not respecting this are silently not sent by the NIC but counted as sent by the PMD. The only way to figure out is compiling the PMD in debug mode. Cc: stable@dpdk.org Fixes: 6579c27c11a5 ("net/mlx5: remove gather loop on segments") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil Acked-by: Yongseok Koh --- v2: fix the commit log. --- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 823aac8..e2e8a22 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -485,7 +485,8 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) #ifdef MLX5_PMD_SOFT_COUNTERS total_length = length; #endif - assert(length >= MLX5_WQE_DWORD_SIZE); + if (length < (MLX5_WQE_DWORD_SIZE + 2)) + break; /* Update element. */ (*txq->elts)[elts_head] = buf; elts_head = (elts_head + 1) & (elts_n - 1);