From patchwork Tue Aug 1 12:09:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 27306 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id BCBBD9B65; Tue, 1 Aug 2017 14:09:52 +0200 (CEST) Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id CB2487CAB for ; Tue, 1 Aug 2017 14:09:49 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id m85so12830373wma.0 for ; Tue, 01 Aug 2017 05:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=puWvFJRyuOusX2aXdN2bCHNEGZqrOEd8UzDX8HUm6Ks=; b=MrRAi/OEffVwR55mpWztrtFAQxFgGHVcmQl2geRzRw+btkLEcmyG4NRWTuc5i2R7wk 9esgdjKZ4Rf2cczcF3Jy4zbU2WP4P+Kh/470ov6LkpM3ITSqv7ZEunqdh9Sv6BACnMZj Bf7X840DWV/CMt2e7zbRwXZzPhfXkZ0bKs3LLQ7ZykQ4XvmapmxxkQ23oQymhGIBBhlx Dw8fbHSyQ1Va15It64DnAKxGMzWhqSD+FaP1iIFN1CnlAexZ8cA8TGDIkrYXvdpJKgcP nhb9zN/ZQRAA6em6009HjiNpdE95/iWKNiL/Kqj/h6IIZS1JtOgdQ2HQN9BChhAoIts8 NPnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=puWvFJRyuOusX2aXdN2bCHNEGZqrOEd8UzDX8HUm6Ks=; b=LzSI5zp/mnNzGL0jul0ONg+Fud7cy6E+WgTWQbDjlZKpz/RwyOb8Y6ZWW6k7H9zdxQ 0UAMTrDKpKUTUHrF1zWppP4b1+E1pz+cB5Sv3IrirkCUyQLoIJ702qHwLqk+ju6lovst RgNmNOoZ0AGYbhJfVpQ6uD/0jxyEDtkTZEjbAGhOwQy3CgDFxkop5S5nOHhiswLDC//1 mC643ksV0kyY534yOAQaj0kDLwql2GKQiSOueuGZWhyXFwfroOjlTKkK60HaBMvlVQH9 xGFOV6+xW/cmeHINZbl2ZVzO+4xGPoBODl7S8zh5QSdTw+hj/1dJGRY5FxCdb61v+1I6 zPHA== X-Gm-Message-State: AIVw1138sDFmRmkC+FW9g4d51UOgtPt1HIoACP9SRMwbBsaiR0Cur4fG 5eYyT4PM2s8Nl4HQNpVszg== X-Received: by 10.28.143.205 with SMTP id r196mr1289595wmd.69.1501589389429; Tue, 01 Aug 2017 05:09:49 -0700 (PDT) Received: from ping.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a3sm34318755wra.17.2017.08.01.05.09.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Aug 2017 05:09:48 -0700 (PDT) From: Nelio Laranjeiro To: Adrien Mazarguil , dev@dpdk.org Cc: Shahaf Shuler Date: Tue, 1 Aug 2017 14:09:27 +0200 Message-Id: <012dd330327bb736abbdff13c1305258b82958ad.1501588970.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 1/5] net/mlx5: remove flow drop useless if branches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Those two if statements are useless as there is a verification on the drop field of the flow to jump to the end of the function just above. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 86be929..d62ccff 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1279,10 +1279,6 @@ priv_flow_destroy(struct priv *priv, claim_zero(ibv_destroy_qp(flow->qp)); if (flow->ind_table) claim_zero(ibv_exp_destroy_rwq_ind_table(flow->ind_table)); - if (flow->drop && flow->wq) - claim_zero(ibv_exp_destroy_wq(flow->wq)); - if (flow->drop && flow->cq) - claim_zero(ibv_destroy_cq(flow->cq)); if (flow->mark) { struct rte_flow *tmp; struct rxq *rxq;