Message ID | cover.1653925803.git.gmuthukrishn@marvell.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 623B7A0542; Mon, 30 May 2022 17:52:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26E6F40694; Mon, 30 May 2022 17:52:53 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 55F17400D6 for <dev@dpdk.org>; Mon, 30 May 2022 17:52:52 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24UB4Kc9012162; Mon, 30 May 2022 08:52:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=97CJR9fk7pdWzJpI/bE1G1CCc6pGoJtEWjfd7tQ+1mY=; b=QZG+CubnKzDBv1tq20ffYJnM6vsVOWwkC1TPoTs/zbMp/e+EIFIohEs9Y+ZCbX4yK+fz 8eZRztdK9CbwXB2w/m88F8aOjW1ImlMxT3wKHZZBP6N7n6IveiWb5jKswi3hS4PgQYHO 43FbVj6fgYqNN/3YAh+SORFQx0flQfgotZcsZh2K3L6xb7Bt7riE620Ka0+rej6pdVT/ IiL0PJcogwTJ2OWVmRjPfWSuoAltjGQNslbtoqylBz8Q4NfQ7dWqRnfxAQHPY4/SFgoJ L6/0UDq9ngLLRGquf+dJ5Zf+4IiUC+KvJAJA53RG1kETGa9wf74BbML0mBrzS4wCbbk2 jg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gbk8n61p4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 30 May 2022 08:52:51 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 30 May 2022 08:52:49 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Mon, 30 May 2022 08:52:49 -0700 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id 15F973F7048; Mon, 30 May 2022 08:52:46 -0700 (PDT) From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> To: <dev@dpdk.org> CC: Fan Zhang <roy.fan.zhang@intel.com>, Brian Dooley <brian.dooley@intel.com>, <lylavoie@iol.unh.edu>, Anoob Joseph <anoobj@marvell.com>, Archana Muniganti <marchana@marvell.com>, Jerin Jacob <jerinj@marvell.com>, Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Subject: [v9, 00/10] Add JSON vector set support to fips validation Date: Mon, 30 May 2022 21:22:34 +0530 Message-ID: <cover.1653925803.git.gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <cover.1653913201.git.gmuthukrishn@marvell.com> References: <cover.1653913201.git.gmuthukrishn@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: lbZoU4EqptwSQDBeqAtQKgYAKB_3q31b X-Proofpoint-GUID: lbZoU4EqptwSQDBeqAtQKgYAKB_3q31b X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-30_07,2022-05-30_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
Add JSON vector set support to fips validation
|
|
Message
Gowrishankar Muthukrishnan
May 30, 2022, 3:52 p.m. UTC
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v9: * doc update. v8: * Fixed overlapped places for FIPS 140-2 test vectors. v7: * Fixed individual patches to build correctly. v6: * CI centos platform fix. v5: * AES_CBC support appended in series. Brandon Lo (8): examples/fips_validation: add jansson dependency examples/fips_validation: add json info to header examples/fips_validation: add json parsing examples/fips_validation: allow json file as input examples/fips_validation: add json to gcm test examples/fips_validation: add json to hmac examples/fips_validation: implement json cmac test examples/fips_validation: add parsing for cmac Gowrishankar Muthukrishnan (2): examples/fips_validation: add parsing for aes_cbc doc: add notes about acvp validation support doc/guides/sample_app_ug/fips_validation.rst | 30 +- examples/fips_validation/fips_validation.c | 117 ++++++- examples/fips_validation/fips_validation.h | 64 +++- .../fips_validation/fips_validation_aes.c | 223 +++++++++++++ .../fips_validation/fips_validation_cmac.c | 80 +++++ .../fips_validation/fips_validation_gcm.c | 152 ++++++++- .../fips_validation/fips_validation_hmac.c | 93 ++++++ examples/fips_validation/main.c | 295 ++++++++++++++++-- examples/fips_validation/meson.build | 4 + 9 files changed, 1015 insertions(+), 43 deletions(-)
Comments
Hey everyone, FIPS-140-2 tested and passed. Tested-by: Jakub Poczatek <Jakub.poczatek@intel.com> -----Original Message----- From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Sent: Monday 30 May 2022 16:53 To: dev@dpdk.org Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Dooley, Brian <brian.dooley@intel.com>; lylavoie@iol.unh.edu; Anoob Joseph <anoobj@marvell.com>; Archana Muniganti <marchana@marvell.com>; Jerin Jacob <jerinj@marvell.com>; Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Subject: [v9, 00/10] Add JSON vector set support to fips validation Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v9: * doc update. v8: * Fixed overlapped places for FIPS 140-2 test vectors. v7: * Fixed individual patches to build correctly. v6: * CI centos platform fix. v5: * AES_CBC support appended in series. Brandon Lo (8): examples/fips_validation: add jansson dependency examples/fips_validation: add json info to header examples/fips_validation: add json parsing examples/fips_validation: allow json file as input examples/fips_validation: add json to gcm test examples/fips_validation: add json to hmac examples/fips_validation: implement json cmac test examples/fips_validation: add parsing for cmac Gowrishankar Muthukrishnan (2): examples/fips_validation: add parsing for aes_cbc doc: add notes about acvp validation support doc/guides/sample_app_ug/fips_validation.rst | 30 +- examples/fips_validation/fips_validation.c | 117 ++++++- examples/fips_validation/fips_validation.h | 64 +++- .../fips_validation/fips_validation_aes.c | 223 +++++++++++++ .../fips_validation/fips_validation_cmac.c | 80 +++++ .../fips_validation/fips_validation_gcm.c | 152 ++++++++- .../fips_validation/fips_validation_hmac.c | 93 ++++++ examples/fips_validation/main.c | 295 ++++++++++++++++-- examples/fips_validation/meson.build | 4 + 9 files changed, 1015 insertions(+), 43 deletions(-) -- 2.25.1
> -----Original Message----- > From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> > Sent: Monday, May 30, 2022 4:53 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Dooley, Brian > <brian.dooley@intel.com>; lylavoie@iol.unh.edu; Anoob Joseph > <anoobj@marvell.com>; Archana Muniganti <marchana@marvell.com>; > Jerin Jacob <jerinj@marvell.com>; Gowrishankar Muthukrishnan > <gmuthukrishn@marvell.com> > Subject: [v9, 00/10] Add JSON vector set support to fips validation > > Adds a very basic introduction to JSON vector sets in > the fips validation example application. This patch set > will only introduce the AES-GCM test using a JSON request > file because the other algorithms need more information > than what is given in the new JSON format. > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > Subject: [v9, 00/10] Add JSON vector set support to fips validation > > > > Adds a very basic introduction to JSON vector sets in > > the fips validation example application. This patch set > > will only introduce the AES-GCM test using a JSON request > > file because the other algorithms need more information > > than what is given in the new JSON format. > > > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com> Series Applied to dpdk-next-crypto Thanks.
On Tue, May 31, 2022 at 5:23 PM Akhil Goyal <gakhil@marvell.com> wrote: > > > > Subject: [v9, 00/10] Add JSON vector set support to fips validation > > > > > > Adds a very basic introduction to JSON vector sets in > > > the fips validation example application. This patch set > > > will only introduce the AES-GCM test using a JSON request > > > file because the other algorithms need more information > > > than what is given in the new JSON format. > > > > > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com> > > Series Applied to dpdk-next-crypto This series breaks compiling the fips example out of DPDK. ## Building fips_validation /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_init': fips_validation.c:(.text+0x7ab): undefined reference to `json_loadf' /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_parse_one_json_vector_set': fips_validation.c:(.text+0xc2e): undefined reference to `json_object_get' /usr/bin/ld: fips_validation.c:(.text+0xc36): undefined reference to `json_string_value' /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_parse_one_json_group': fips_validation.c:(.text+0xd00): undefined reference to `json_object_get' /usr/bin/ld: fips_validation.c:(.text+0xd14): undefined reference to `json_integer_value' etc... I'll send a fix.
On Tue, Jun 7, 2022 at 11:48 AM David Marchand <david.marchand@redhat.com> wrote: > On Tue, May 31, 2022 at 5:23 PM Akhil Goyal <gakhil@marvell.com> wrote: > > > > > > Subject: [v9, 00/10] Add JSON vector set support to fips validation > > > > > > > > Adds a very basic introduction to JSON vector sets in > > > > the fips validation example application. This patch set > > > > will only introduce the AES-GCM test using a JSON request > > > > file because the other algorithms need more information > > > > than what is given in the new JSON format. > > > > > > > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com> > > > > Series Applied to dpdk-next-crypto > > This series breaks compiling the fips example out of DPDK. Gowri, Fan, Akhil, I disabled compilation checks for this example on my side. Can you look into this? Thanks.
Hi David, Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/ I have acked this. @Akhil Goyal could this be merged ?. Thanks, Gowrishankar > -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Monday, June 13, 2022 5:29 PM > To: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>; Zhang, Roy > Fan <roy.fan.zhang@intel.com>; Akhil Goyal <gakhil@marvell.com> > Cc: dev@dpdk.org; Dooley, Brian <brian.dooley@intel.com>; > lylavoie@iol.unh.edu; Anoob Joseph <anoobj@marvell.com>; Archana > Muniganti <marchana@marvell.com>; Jerin Jacob Kollanukkaran > <jerinj@marvell.com> > Subject: [EXT] Re: [v9, 00/10] Add JSON vector set support to fips validation > > External Email > > ---------------------------------------------------------------------- > On Tue, Jun 7, 2022 at 11:48 AM David Marchand > <david.marchand@redhat.com> wrote: > > On Tue, May 31, 2022 at 5:23 PM Akhil Goyal <gakhil@marvell.com> wrote: > > > > > > > > Subject: [v9, 00/10] Add JSON vector set support to fips > > > > > validation > > > > > > > > > > Adds a very basic introduction to JSON vector sets in the fips > > > > > validation example application. This patch set will only > > > > > introduce the AES-GCM test using a JSON request file because the > > > > > other algorithms need more information than what is given in the > > > > > new JSON format. > > > > > > > > > Series-acked-by: Fan Zhang <roy.fan.zhang@intel.com> > > > > > > Series Applied to dpdk-next-crypto > > > > This series breaks compiling the fips example out of DPDK. > > Gowri, Fan, Akhil, > > I disabled compilation checks for this example on my side. > Can you look into this? > > Thanks. > > -- > David Marchand
Hello, On Tue, Jun 21, 2022 at 9:29 AM Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> wrote: > Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/ > I have acked this. @Akhil Goyal could this be merged ?. Indeed, I had forgotten about it. Akhil, please take it for rc2.
> Hello, > > On Tue, Jun 21, 2022 at 9:29 AM Gowrishankar Muthukrishnan > <gmuthukrishn@marvell.com> wrote: > > Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/ > > I have acked this. @Akhil Goyal could this be merged ?. > > Indeed, I had forgotten about it. > Akhil, please take it for rc2. Sure, this patch was not delegated to me, so I did not notice this. I will take it for RC2
On Tue, Jun 21, 2022 at 9:40 AM Akhil Goyal <gakhil@marvell.com> wrote: > > > Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.marchand@redhat.com/ > > > I have acked this. @Akhil Goyal could this be merged ?. > > > > Indeed, I had forgotten about it. > > Akhil, please take it for rc2. > Sure, this patch was not delegated to me, so I did not notice this. > I will take it for RC2 Thanks Akhil.