mbox series

[0/2] net/cxgbe: minor fixes for link related changes

Message ID cover.1610730372.git.rahul.lakkireddy@chelsio.com (mailing list archive)
Headers
Series net/cxgbe: minor fixes for link related changes |

Message

Rahul Lakkireddy Jan. 15, 2021, 5:19 p.m. UTC
  Patch 1 fixes issue with link status always getting set to down by
driver for every link config change request. This is not required
for some link config changes, like Tx/Rx pause on/off. Instead,
driver should rely on actual link status returned by firmware in
link config change reply.

Patch 2 fixes issue with link FEC retraining during probe. If
firmware had already saved FEC before probe is completed, then
use the saved FEC for further link configuration, instead of
triggering link retraining. Also simplifies get fec ops.

Thanks,
Rahul

Rahul Lakkireddy (2):
  net/cxgbe: do not link down for every link config change
  net/cxgbe: avoid link FEC retraining during probe

 drivers/net/cxgbe/base/t4_hw.c   | 17 ++++++++++++-----
 drivers/net/cxgbe/cxgbe_ethdev.c | 21 +++++----------------
 2 files changed, 17 insertions(+), 21 deletions(-)
  

Comments

Ferruh Yigit Jan. 19, 2021, 1:52 a.m. UTC | #1
On 1/15/2021 5:19 PM, Rahul Lakkireddy wrote:
> Patch 1 fixes issue with link status always getting set to down by
> driver for every link config change request. This is not required
> for some link config changes, like Tx/Rx pause on/off. Instead,
> driver should rely on actual link status returned by firmware in
> link config change reply.
> 
> Patch 2 fixes issue with link FEC retraining during probe. If
> firmware had already saved FEC before probe is completed, then
> use the saved FEC for further link configuration, instead of
> triggering link retraining. Also simplifies get fec ops.
> 
> Thanks,
> Rahul
> 
> Rahul Lakkireddy (2):
>    net/cxgbe: do not link down for every link config change
>    net/cxgbe: avoid link FEC retraining during probe
> 
>   drivers/net/cxgbe/base/t4_hw.c   | 17 ++++++++++++-----
>   drivers/net/cxgbe/cxgbe_ethdev.c | 21 +++++----------------
>   2 files changed, 17 insertions(+), 21 deletions(-)
> 


Set squashed into relevant commits in next-net, thanks.