mbox series

[0/2] Fix shared lib detection on Fedora/CentOS/RHEL

Message ID cover.1606229937.git.tredaelli@redhat.com (mailing list archive)
Headers show
Series Fix shared lib detection on Fedora/CentOS/RHEL | expand

Message

Timothy Redaelli Nov. 24, 2020, 3:14 p.m. UTC
Currently eal only tries to find shared lib by looking for .so files,
but on Fedora, CentOS and RHEL the .so file is not installed by dpdk
package, but it's only installed by dpdk-devel package, since .so files
should not be necessary in order to run a program [1].

This series fix that by checking for .so.ABI_VERSION that should be
available on any linux distribution.

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

Timothy Redaelli (2):
  eal: fix shared lib mode detection
  eal: fix loading of shared libs from driver plugin directories

 lib/librte_eal/common/eal_common_options.c | 9 ++++++---
 lib/librte_eal/common/meson.build          | 2 ++
 2 files changed, 8 insertions(+), 3 deletions(-)

Comments

Maxime Coquelin Nov. 25, 2020, 10:57 a.m. UTC | #1
On 11/24/20 4:14 PM, Timothy Redaelli wrote:
> Currently eal only tries to find shared lib by looking for .so files,
> but on Fedora, CentOS and RHEL the .so file is not installed by dpdk
> package, but it's only installed by dpdk-devel package, since .so files
> should not be necessary in order to run a program [1].
> 
> This series fix that by checking for .so.ABI_VERSION that should be
> available on any linux distribution.
> 
> [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
> 
> Timothy Redaelli (2):
>   eal: fix shared lib mode detection
>   eal: fix loading of shared libs from driver plugin directories
> 
>  lib/librte_eal/common/eal_common_options.c | 9 ++++++---
>  lib/librte_eal/common/meson.build          | 2 ++
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 

Looks good to me. For the series:
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Ali Alnubani Nov. 25, 2020, 3:59 p.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Timothy Redaelli
> Sent: Tuesday, November 24, 2020 5:14 PM
> To: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: bruce.richardson@intel.com; dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/2] Fix shared lib detection on
> Fedora/CentOS/RHEL
> 

Tested-by: Ali Alnubani <alialnu@nvidia.com>

Thanks,
Ali
Thomas Monjalon Nov. 25, 2020, 10:54 p.m. UTC | #3
24/11/2020 16:13, Timothy Redaelli:
> Currently eal only tries to find shared lib by looking for .so files,
> but on Fedora, CentOS and RHEL the .so file is not installed by dpdk
> package, but it's only installed by dpdk-devel package, since .so files
> should not be necessary in order to run a program [1].
> 
> This series fix that by checking for .so.ABI_VERSION that should be
> available on any linux distribution.
> 
> [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
> 
> Timothy Redaelli (2):
>   eal: fix shared lib mode detection
>   eal: fix loading of shared libs from driver plugin directories

This is very late to fix such core behaviour,
but it has been well reviewed and tested:

    Acked-by: Bruce Richardson <bruce.richardson@intel.com>
    Acked-by: David Marchand <david.marchand@redhat.com>
    Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
    Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
    Tested-by: Ali Alnubani <alialnu@nvidia.com>

Applied, thanks