mbox series

[00/10] net/atlantic: bugfixes and code cleanup

Message ID cover.1551528549.git.igor.russkikh@aquantia.com (mailing list archive)
Headers show
Series net/atlantic: bugfixes and code cleanup | expand

Message

Igor Russkikh March 2, 2019, 12:10 p.m. UTC
The patchset mainly fixes some Coverity issues,
couple of minor bugs and overflows.

It also improves eeprom get/set logic with ability of custom
device address and dump length.

Igor Russkikh (7):
  net/atlantic: Fix negative error codes
  net/atlantic: remove unused variable
  net/atlantic: check for error codes
  net/atlantic: fix link configuration
  net/atlantic: eliminate excessive log levels on rx/tx
  net/atlantic: fix missing vlan filter offload
  net/atlantic: fix xstats to return correct number of requested items

Pavel Belous (3):
  net/atlantic: fix buffer overflow
  net/atlantic: use eeprom magic as a device address
  net/atlantic: fix eeprom fetching for small and uneven lengths

 drivers/net/atlantic/atl_ethdev.c             | 71 ++++++++++---------
 drivers/net/atlantic/atl_rxtx.c               | 20 ++----
 drivers/net/atlantic/atl_types.h              |  5 +-
 drivers/net/atlantic/hw_atl/hw_atl_b0.c       |  6 +-
 drivers/net/atlantic/hw_atl/hw_atl_utils.c    |  9 +--
 drivers/net/atlantic/hw_atl/hw_atl_utils.h    | 23 +++---
 .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c   | 59 ++++++++++-----
 7 files changed, 105 insertions(+), 88 deletions(-)

Comments

David Marchand March 4, 2019, 9:40 a.m. UTC | #1
On Sat, Mar 2, 2019 at 1:10 PM Igor Russkikh <Igor.Russkikh@aquantia.com>
wrote:

> The patchset mainly fixes some Coverity issues,
> couple of minor bugs and overflows.
>
> It also improves eeprom get/set logic with ability of custom
> device address and dump length.
>
> Igor Russkikh (7):
>   net/atlantic: Fix negative error codes
>   net/atlantic: remove unused variable
>   net/atlantic: check for error codes
>   net/atlantic: fix link configuration
>   net/atlantic: eliminate excessive log levels on rx/tx
>   net/atlantic: fix missing vlan filter offload
>   net/atlantic: fix xstats to return correct number of requested items
>
> Pavel Belous (3):
>   net/atlantic: fix buffer overflow
>   net/atlantic: use eeprom magic as a device address
>   net/atlantic: fix eeprom fetching for small and uneven lengths
>
>  drivers/net/atlantic/atl_ethdev.c             | 71 ++++++++++---------
>  drivers/net/atlantic/atl_rxtx.c               | 20 ++----
>  drivers/net/atlantic/atl_types.h              |  5 +-
>  drivers/net/atlantic/hw_atl/hw_atl_b0.c       |  6 +-
>  drivers/net/atlantic/hw_atl/hw_atl_utils.c    |  9 +--
>  drivers/net/atlantic/hw_atl/hw_atl_utils.h    | 23 +++---
>  .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c   | 59 ++++++++++-----
>  7 files changed, 105 insertions(+), 88 deletions(-)
>


Those patches are missing Fixes: tags and copying stable where appropriate.
The commitlogs also need some work.

It looks like those patches were neither checked against checkpatch nor
check-git-log.sh.
Here is what I see (extended the max line length to 100 to avoid all those
80 columns warnings, but this is worth fixing as well).

[dmarchan@dmarchan dpdk]$ DPDK_CHECKPATCH_LINE_LENGTH=100
./devtools/checkpatches.sh

### net/atlantic: Fix negative error codes

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 14 lines checked

### net/atlantic: use eeprom magic as a device address

WARNING:LONG_LINE: line over 100 characters
#163: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:134:
+    u32 val = rate_mask | ((BIT(CAPS_LO_SMBUS_READ) |
BIT(CAPS_LO_SMBUS_WRITE) | BIT(CAPS_LO_MACSEC)) & reg_val);

total: 0 errors, 1 warnings, 0 checks, 194 lines checked

### net/atlantic: fix eeprom fetching for small and uneven lengths

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#46: FILE: drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c:558:
+            rte_memcpy((u8*)data + len - bytes_remains, &val,
bytes_remains);

total: 1 errors, 1 warnings, 0 checks, 36 lines checked

### net/atlantic: fix missing vlan filter offload

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 9 lines checked

### net/atlantic: fix xstats to return correct number of requested items

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 16 lines checked

5/10 valid patches



[dmarchan@dmarchan dpdk]$ ./devtools/check-git-log.sh
Wrong headline uppercase:
    net/atlantic: Fix negative error codes
Wrong headline lowercase:
    net/atlantic: use eeprom magic as a device address
    net/atlantic: fix eeprom fetching for small and uneven lengths
    net/atlantic: eliminate excessive log levels on rx/tx
    net/atlantic: fix missing vlan filter offload
Headline too long:
    net/atlantic: fix eeprom fetching for small and uneven lengths
    net/atlantic: fix xstats to return correct number of requested items
Missing 'Fixes' tag:
    net/atlantic: Fix negative error codes
    net/atlantic: fix buffer overflow
    net/atlantic: fix eeprom fetching for small and uneven lengths
    net/atlantic: fix link configuration
    net/atlantic: fix missing vlan filter offload
    net/atlantic: fix xstats to return correct number of requested items
Igor Russkikh March 6, 2019, 12:08 p.m. UTC | #2
On 04.03.2019 12:40, David Marchand wrote:

> Those patches are missing Fixes: tags and copying stable where appropriate.
> The commitlogs also need some work.
> 
> It looks like those patches were neither checked against checkpatch nor
> check-git-log.sh.
> Here is what I see (extended the max line length to 100 to avoid all those
> 80 columns warnings, but this is worth fixing as well).

Thanks David, I've indeed forgot about check-git-log.
Will fix these and resubmit.

Regards,
  Igor