| Message ID | 20241114114000.1677350-1-huangdengdui@huawei.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BECF45D04; Thu, 14 Nov 2024 12:40:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E36BC40E45; Thu, 14 Nov 2024 12:40:08 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 653A940274 for <dev@dpdk.org>; Thu, 14 Nov 2024 12:40:04 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Xpynn2xWkz10SyQ; Thu, 14 Nov 2024 19:38:05 +0800 (CST) Received: from dggpeml500011.china.huawei.com (unknown [7.185.36.84]) by mail.maildlp.com (Postfix) with ESMTPS id CCE4D18009B; Thu, 14 Nov 2024 19:40:00 +0800 (CST) Received: from localhost.huawei.com (10.50.165.33) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 14 Nov 2024 19:40:00 +0800 From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ajit.khaparde@broadcom.com>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com>, <iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v6 00/14] use rte_strerror() for rte_errno Date: Thu, 14 Nov 2024 19:39:46 +0800 Message-ID: <20241114114000.1677350-1-huangdengdui@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20231114082539.1858594-1-huangdengdui@huawei.com> References: <20231114082539.1858594-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500011.china.huawei.com (7.185.36.84) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
use rte_strerror() for rte_errno
|
|
Message
Dengdui Huang
Nov. 14, 2024, 11:39 a.m. UTC
Whether strerror() needs to be replaced needs further discussion, but rte_error should not be used by strerror() because rte_errno may be an RTE-specific error code. This patchset use rte_strerror() instead of strerror() for rte_errno. Also, I tried to add it to checkpatch, but rte_errno can be used as an argument to any function and the checkpatch script should not return an error, so I didn't do that. Dengdui Huang (14): eal: fix use rte errno for libc function eal: use rte strerror pdump: use rte strerror bus/vdev: use rte strerror common/mlx5: use rte strerror net/af_xdp: use rte strerror net/bonding: use rte strerror net/failsafe: use rte strerror net/memif: use rte strerror net/mlx4: use rte strerror net/mlx5: use rte strerror net/tap: use rte strerror app/dumpcap: use rte strerror test: use rte strerror app/dumpcap/main.c | 2 +- app/test/test_bpf.c | 10 +++++----- drivers/bus/vdev/vdev.c | 2 +- drivers/common/mlx5/linux/mlx5_nl.c | 10 +++++----- drivers/common/mlx5/mlx5_common.c | 6 +++--- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- drivers/net/bonding/rte_eth_bond_flow.c | 4 ++-- drivers/net/failsafe/failsafe.c | 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- drivers/net/failsafe/failsafe_flow.c | 4 ++-- drivers/net/memif/rte_eth_memif.c | 2 +- drivers/net/mlx4/mlx4.c | 2 +- drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++--------- drivers/net/mlx4/mlx4_rxq.c | 4 ++-- drivers/net/mlx4/mlx4_txq.c | 10 +++++----- drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 +++++++++++----------- drivers/net/mlx5/linux/mlx5_os.c | 16 ++++++++-------- drivers/net/mlx5/mlx5.c | 8 ++++---- drivers/net/mlx5/mlx5_mac.c | 2 +- drivers/net/mlx5/mlx5_rxmode.c | 8 ++++---- drivers/net/mlx5/mlx5_stats.c | 2 +- drivers/net/mlx5/mlx5_testpmd.c | 10 +++++----- drivers/net/mlx5/mlx5_trigger.c | 12 ++++++------ drivers/net/mlx5/mlx5_vlan.c | 2 +- drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- drivers/net/mlx5/windows/mlx5_os.c | 10 +++++----- drivers/net/tap/rte_eth_tap.c | 4 ++-- lib/eal/linux/eal_dev.c | 2 +- lib/eal/unix/eal_unix_memory.c | 2 +- lib/pdump/rte_pdump.c | 2 +- 31 files changed, 93 insertions(+), 93 deletions(-)
Comments
On Thu, 14 Nov 2024 19:39:46 +0800 Dengdui Huang <huangdengdui@huawei.com> wrote: > Whether strerror() needs to be replaced needs further discussion, > but rte_error should not be used by strerror() because rte_errno > may be an RTE-specific error code. > > This patchset use rte_strerror() instead of strerror() for rte_errno. > > Also, I tried to add it to checkpatch, but rte_errno can be used as an argument to any function > and the checkpatch script should not return an error, so I didn't do that. > > Dengdui Huang (14): > eal: fix use rte errno for libc function > eal: use rte strerror > pdump: use rte strerror > bus/vdev: use rte strerror > common/mlx5: use rte strerror > net/af_xdp: use rte strerror > net/bonding: use rte strerror > net/failsafe: use rte strerror > net/memif: use rte strerror > net/mlx4: use rte strerror > net/mlx5: use rte strerror > net/tap: use rte strerror > app/dumpcap: use rte strerror > test: use rte strerror > > app/dumpcap/main.c | 2 +- > app/test/test_bpf.c | 10 +++++----- > drivers/bus/vdev/vdev.c | 2 +- > drivers/common/mlx5/linux/mlx5_nl.c | 10 +++++----- > drivers/common/mlx5/mlx5_common.c | 6 +++--- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- > drivers/net/bonding/rte_eth_bond_flow.c | 4 ++-- > drivers/net/failsafe/failsafe.c | 2 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > drivers/net/failsafe/failsafe_flow.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/mlx4/mlx4.c | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++--------- > drivers/net/mlx4/mlx4_rxq.c | 4 ++-- > drivers/net/mlx4/mlx4_txq.c | 10 +++++----- > drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 +++++++++++----------- > drivers/net/mlx5/linux/mlx5_os.c | 16 ++++++++-------- > drivers/net/mlx5/mlx5.c | 8 ++++---- > drivers/net/mlx5/mlx5_mac.c | 2 +- > drivers/net/mlx5/mlx5_rxmode.c | 8 ++++---- > drivers/net/mlx5/mlx5_stats.c | 2 +- > drivers/net/mlx5/mlx5_testpmd.c | 10 +++++----- > drivers/net/mlx5/mlx5_trigger.c | 12 ++++++------ > drivers/net/mlx5/mlx5_vlan.c | 2 +- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- > drivers/net/mlx5/windows/mlx5_os.c | 10 +++++----- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > lib/eal/linux/eal_dev.c | 2 +- > lib/eal/unix/eal_unix_memory.c | 2 +- > lib/pdump/rte_pdump.c | 2 +- > 31 files changed, 93 insertions(+), 93 deletions(-) > Looks good thanks. Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Series-acked-by: Chengwen Feng <fengchengwen@huawei.com> On 2024/11/14 19:39, Dengdui Huang wrote: > Whether strerror() needs to be replaced needs further discussion, > but rte_error should not be used by strerror() because rte_errno > may be an RTE-specific error code. > > This patchset use rte_strerror() instead of strerror() for rte_errno. > > Also, I tried to add it to checkpatch, but rte_errno can be used as an argument to any function > and the checkpatch script should not return an error, so I didn't do that. > > Dengdui Huang (14): > eal: fix use rte errno for libc function > eal: use rte strerror > pdump: use rte strerror > bus/vdev: use rte strerror > common/mlx5: use rte strerror > net/af_xdp: use rte strerror > net/bonding: use rte strerror > net/failsafe: use rte strerror > net/memif: use rte strerror > net/mlx4: use rte strerror > net/mlx5: use rte strerror > net/tap: use rte strerror > app/dumpcap: use rte strerror > test: use rte strerror > > app/dumpcap/main.c | 2 +- > app/test/test_bpf.c | 10 +++++----- > drivers/bus/vdev/vdev.c | 2 +- > drivers/common/mlx5/linux/mlx5_nl.c | 10 +++++----- > drivers/common/mlx5/mlx5_common.c | 6 +++--- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- > drivers/net/bonding/rte_eth_bond_flow.c | 4 ++-- > drivers/net/failsafe/failsafe.c | 2 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > drivers/net/failsafe/failsafe_flow.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/mlx4/mlx4.c | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++--------- > drivers/net/mlx4/mlx4_rxq.c | 4 ++-- > drivers/net/mlx4/mlx4_txq.c | 10 +++++----- > drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 +++++++++++----------- > drivers/net/mlx5/linux/mlx5_os.c | 16 ++++++++-------- > drivers/net/mlx5/mlx5.c | 8 ++++---- > drivers/net/mlx5/mlx5_mac.c | 2 +- > drivers/net/mlx5/mlx5_rxmode.c | 8 ++++---- > drivers/net/mlx5/mlx5_stats.c | 2 +- > drivers/net/mlx5/mlx5_testpmd.c | 10 +++++----- > drivers/net/mlx5/mlx5_trigger.c | 12 ++++++------ > drivers/net/mlx5/mlx5_vlan.c | 2 +- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- > drivers/net/mlx5/windows/mlx5_os.c | 10 +++++----- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > lib/eal/linux/eal_dev.c | 2 +- > lib/eal/unix/eal_unix_memory.c | 2 +- > lib/pdump/rte_pdump.c | 2 +- > 31 files changed, 93 insertions(+), 93 deletions(-) >
Series-Acked-by: Huisong Li <lihuisong@huawei.com> 在 2024/11/14 19:39, Dengdui Huang 写道: > Whether strerror() needs to be replaced needs further discussion, > but rte_error should not be used by strerror() because rte_errno > may be an RTE-specific error code. > > This patchset use rte_strerror() instead of strerror() for rte_errno. > > Also, I tried to add it to checkpatch, but rte_errno can be used as an argument to any function > and the checkpatch script should not return an error, so I didn't do that. > > Dengdui Huang (14): > eal: fix use rte errno for libc function > eal: use rte strerror > pdump: use rte strerror > bus/vdev: use rte strerror > common/mlx5: use rte strerror > net/af_xdp: use rte strerror > net/bonding: use rte strerror > net/failsafe: use rte strerror > net/memif: use rte strerror > net/mlx4: use rte strerror > net/mlx5: use rte strerror > net/tap: use rte strerror > app/dumpcap: use rte strerror > test: use rte strerror > > app/dumpcap/main.c | 2 +- > app/test/test_bpf.c | 10 +++++----- > drivers/bus/vdev/vdev.c | 2 +- > drivers/common/mlx5/linux/mlx5_nl.c | 10 +++++----- > drivers/common/mlx5/mlx5_common.c | 6 +++--- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- > drivers/net/bonding/rte_eth_bond_flow.c | 4 ++-- > drivers/net/failsafe/failsafe.c | 2 +- > drivers/net/failsafe/failsafe_eal.c | 2 +- > drivers/net/failsafe/failsafe_flow.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/mlx4/mlx4.c | 2 +- > drivers/net/mlx4/mlx4_ethdev.c | 18 +++++++++--------- > drivers/net/mlx4/mlx4_rxq.c | 4 ++-- > drivers/net/mlx4/mlx4_txq.c | 10 +++++----- > drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 +++++++++++----------- > drivers/net/mlx5/linux/mlx5_os.c | 16 ++++++++-------- > drivers/net/mlx5/mlx5.c | 8 ++++---- > drivers/net/mlx5/mlx5_mac.c | 2 +- > drivers/net/mlx5/mlx5_rxmode.c | 8 ++++---- > drivers/net/mlx5/mlx5_stats.c | 2 +- > drivers/net/mlx5/mlx5_testpmd.c | 10 +++++----- > drivers/net/mlx5/mlx5_trigger.c | 12 ++++++------ > drivers/net/mlx5/mlx5_vlan.c | 2 +- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 2 +- > drivers/net/mlx5/windows/mlx5_os.c | 10 +++++----- > drivers/net/tap/rte_eth_tap.c | 4 ++-- > lib/eal/linux/eal_dev.c | 2 +- > lib/eal/unix/eal_unix_memory.c | 2 +- > lib/pdump/rte_pdump.c | 2 +- > 31 files changed, 93 insertions(+), 93 deletions(-) >