| Message ID | 20240618071150.21564-1-jiawenwu@trustnetic.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FA4345489; Tue, 18 Jun 2024 09:12:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90CD040DD6; Tue, 18 Jun 2024 09:12:16 +0200 (CEST) Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by mails.dpdk.org (Postfix) with ESMTP id ED54840DD6 for <dev@dpdk.org>; Tue, 18 Jun 2024 09:12:00 +0200 (CEST) X-QQ-mid: bizesmtpsz1t1718694717tghg9rx X-QQ-Originating-IP: P1Qc+TR3ShjC5fa0xlTG4CxJq7NmRARraNS/mKeImhg= Received: from lap-jiawenwu.trustnetic.com ( [183.159.97.141]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 18 Jun 2024 15:11:55 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 16999197105924276361 From: Jiawen Wu <jiawenwu@trustnetic.com> To: dev@dpdk.org Cc: Jiawen Wu <jiawenwu@trustnetic.com> Subject: [PATCH 00/19] Wangxun fixes and supports Date: Tue, 18 Jun 2024 15:11:31 +0800 Message-Id: <20240618071150.21564-1-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
Wangxun fixes and supports
|
|
Message
Jiawen Wu
June 18, 2024, 7:11 a.m. UTC
Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. Jiawen Wu (19): net/txgbe: fix to parse tunnel packets net/txgbe: fix flow filters in VT mode net/txgbe: fix Tx hang on queue disable net/txgbe: restrict the configuration of VLAN strip offload net/txgbe: reconfigure more MAC Rx registers net/txgbe: fix VF promiscuous and allmulticast net/ngbe: special config for YT8531SH-CA PHY net/ngbe: keep PHY power down while device probing net/ngbe: add WOL and NCSI capability net/txgbe: fix hotplug remove net/ngbe: fix hotplug remove net/txgbe: correct valid MTU range net/ngbe: correct valid MTU range net/txgbe: fix memory leak net/ngbe: fix memory leak net/txgbe: fix Rx interrupt net/ngbe: support Rx interrupt net/txgbe: disable LLDP by default net/ngbe: disable LLDP by default doc/guides/nics/features/ngbe.ini | 1 + doc/guides/nics/ngbe.rst | 1 + drivers/net/ngbe/base/ngbe_devids.h | 1 + drivers/net/ngbe/base/ngbe_eeprom.h | 4 + drivers/net/ngbe/base/ngbe_hw.c | 106 ++++++++++++++++++--- drivers/net/ngbe/base/ngbe_hw.h | 5 +- drivers/net/ngbe/base/ngbe_mng.c | 46 +++++++++ drivers/net/ngbe/base/ngbe_mng.h | 14 +++ drivers/net/ngbe/base/ngbe_phy.c | 6 ++ drivers/net/ngbe/base/ngbe_phy_mvl.c | 2 +- drivers/net/ngbe/base/ngbe_phy_rtl.c | 5 +- drivers/net/ngbe/base/ngbe_phy_yt.c | 7 ++ drivers/net/ngbe/base/ngbe_phy_yt.h | 2 + drivers/net/ngbe/base/ngbe_regs.h | 2 + drivers/net/ngbe/base/ngbe_type.h | 4 + drivers/net/ngbe/ngbe_ethdev.c | 66 ++++++++++--- drivers/net/ngbe/ngbe_ethdev.h | 1 + drivers/net/ngbe/ngbe_rxtx.c | 13 ++- drivers/net/ngbe/ngbe_rxtx.h | 2 + drivers/net/txgbe/base/meson.build | 2 +- drivers/net/txgbe/base/txgbe_eeprom.h | 3 + drivers/net/txgbe/base/txgbe_hw.c | 128 +++++++++++++++++++++---- drivers/net/txgbe/base/txgbe_hw.h | 5 +- drivers/net/txgbe/base/txgbe_mng.c | 46 +++++++++ drivers/net/txgbe/base/txgbe_mng.h | 13 +++ drivers/net/txgbe/base/txgbe_osdep.h | 1 + drivers/net/txgbe/base/txgbe_regs.h | 7 ++ drivers/net/txgbe/base/txgbe_type.h | 3 + drivers/net/txgbe/txgbe_ethdev.c | 131 +++++++++++++++----------- drivers/net/txgbe/txgbe_ethdev.h | 2 +- drivers/net/txgbe/txgbe_ethdev_vf.c | 21 ++++- drivers/net/txgbe/txgbe_fdir.c | 3 + drivers/net/txgbe/txgbe_rxtx.c | 85 ++++++++++------- drivers/net/txgbe/txgbe_rxtx.h | 2 + 34 files changed, 601 insertions(+), 139 deletions(-)
Comments
Hi, > -----Original Message----- > From: Jiawen Wu <jiawenwu@trustnetic.com> > Sent: Tuesday, June 18, 2024 3:12 PM > To: dev@dpdk.org > Cc: Jiawen Wu <jiawenwu@trustnetic.com> > Subject: [PATCH 00/19] Wangxun fixes and supports > > Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. > > Jiawen Wu (19): > net/txgbe: fix to parse tunnel packets > net/txgbe: fix flow filters in VT mode > net/txgbe: fix Tx hang on queue disable > net/txgbe: restrict the configuration of VLAN strip offload > net/txgbe: reconfigure more MAC Rx registers > net/txgbe: fix VF promiscuous and allmulticast > net/ngbe: special config for YT8531SH-CA PHY > net/ngbe: keep PHY power down while device probing > net/ngbe: add WOL and NCSI capability > net/txgbe: fix hotplug remove > net/ngbe: fix hotplug remove > net/txgbe: correct valid MTU range > net/ngbe: correct valid MTU range > net/txgbe: fix memory leak > net/ngbe: fix memory leak > net/txgbe: fix Rx interrupt > net/ngbe: support Rx interrupt > net/txgbe: disable LLDP by default > net/ngbe: disable LLDP by default > > doc/guides/nics/features/ngbe.ini | 1 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/base/ngbe_devids.h | 1 + > drivers/net/ngbe/base/ngbe_eeprom.h | 4 + > drivers/net/ngbe/base/ngbe_hw.c | 106 ++++++++++++++++++--- > drivers/net/ngbe/base/ngbe_hw.h | 5 +- > drivers/net/ngbe/base/ngbe_mng.c | 46 +++++++++ > drivers/net/ngbe/base/ngbe_mng.h | 14 +++ > drivers/net/ngbe/base/ngbe_phy.c | 6 ++ > drivers/net/ngbe/base/ngbe_phy_mvl.c | 2 +- > drivers/net/ngbe/base/ngbe_phy_rtl.c | 5 +- > drivers/net/ngbe/base/ngbe_phy_yt.c | 7 ++ > drivers/net/ngbe/base/ngbe_phy_yt.h | 2 + > drivers/net/ngbe/base/ngbe_regs.h | 2 + > drivers/net/ngbe/base/ngbe_type.h | 4 + > drivers/net/ngbe/ngbe_ethdev.c | 66 ++++++++++--- > drivers/net/ngbe/ngbe_ethdev.h | 1 + > drivers/net/ngbe/ngbe_rxtx.c | 13 ++- > drivers/net/ngbe/ngbe_rxtx.h | 2 + > drivers/net/txgbe/base/meson.build | 2 +- > drivers/net/txgbe/base/txgbe_eeprom.h | 3 + > drivers/net/txgbe/base/txgbe_hw.c | 128 +++++++++++++++++++++---- > drivers/net/txgbe/base/txgbe_hw.h | 5 +- > drivers/net/txgbe/base/txgbe_mng.c | 46 +++++++++ > drivers/net/txgbe/base/txgbe_mng.h | 13 +++ > drivers/net/txgbe/base/txgbe_osdep.h | 1 + > drivers/net/txgbe/base/txgbe_regs.h | 7 ++ > drivers/net/txgbe/base/txgbe_type.h | 3 + > drivers/net/txgbe/txgbe_ethdev.c | 131 +++++++++++++++----------- > drivers/net/txgbe/txgbe_ethdev.h | 2 +- > drivers/net/txgbe/txgbe_ethdev_vf.c | 21 ++++- > drivers/net/txgbe/txgbe_fdir.c | 3 + > drivers/net/txgbe/txgbe_rxtx.c | 85 ++++++++++------- > drivers/net/txgbe/txgbe_rxtx.h | 2 + > 34 files changed, 601 insertions(+), 139 deletions(-) > > -- > 2.27.0 >
Hi, > -----Original Message----- > From: Jiawen Wu <jiawenwu@trustnetic.com> > Sent: Tuesday, June 25, 2024 9:51 AM > To: dev@dpdk.org > Subject: RE: [PATCH 00/19] Wangxun fixes and supports > > Hi, > > > -----Original Message----- > > From: Jiawen Wu <jiawenwu@trustnetic.com> > > Sent: Tuesday, June 18, 2024 3:12 PM > > To: dev@dpdk.org > > Cc: Jiawen Wu <jiawenwu@trustnetic.com> > > Subject: [PATCH 00/19] Wangxun fixes and supports > > > > Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. > > > > Jiawen Wu (19): > > net/txgbe: fix to parse tunnel packets > > net/txgbe: fix flow filters in VT mode > > net/txgbe: fix Tx hang on queue disable > > net/txgbe: restrict the configuration of VLAN strip offload > > net/txgbe: reconfigure more MAC Rx registers > > net/txgbe: fix VF promiscuous and allmulticast > > net/ngbe: special config for YT8531SH-CA PHY > > net/ngbe: keep PHY power down while device probing > > net/ngbe: add WOL and NCSI capability > > net/txgbe: fix hotplug remove > > net/ngbe: fix hotplug remove > > net/txgbe: correct valid MTU range > > net/ngbe: correct valid MTU range > > net/txgbe: fix memory leak > > net/ngbe: fix memory leak > > net/txgbe: fix Rx interrupt > > net/ngbe: support Rx interrupt > > net/txgbe: disable LLDP by default > > net/ngbe: disable LLDP by default > > > > doc/guides/nics/features/ngbe.ini | 1 + > > doc/guides/nics/ngbe.rst | 1 + > > drivers/net/ngbe/base/ngbe_devids.h | 1 + > > drivers/net/ngbe/base/ngbe_eeprom.h | 4 + > > drivers/net/ngbe/base/ngbe_hw.c | 106 ++++++++++++++++++--- > > drivers/net/ngbe/base/ngbe_hw.h | 5 +- > > drivers/net/ngbe/base/ngbe_mng.c | 46 +++++++++ > > drivers/net/ngbe/base/ngbe_mng.h | 14 +++ > > drivers/net/ngbe/base/ngbe_phy.c | 6 ++ > > drivers/net/ngbe/base/ngbe_phy_mvl.c | 2 +- > > drivers/net/ngbe/base/ngbe_phy_rtl.c | 5 +- > > drivers/net/ngbe/base/ngbe_phy_yt.c | 7 ++ > > drivers/net/ngbe/base/ngbe_phy_yt.h | 2 + > > drivers/net/ngbe/base/ngbe_regs.h | 2 + > > drivers/net/ngbe/base/ngbe_type.h | 4 + > > drivers/net/ngbe/ngbe_ethdev.c | 66 ++++++++++--- > > drivers/net/ngbe/ngbe_ethdev.h | 1 + > > drivers/net/ngbe/ngbe_rxtx.c | 13 ++- > > drivers/net/ngbe/ngbe_rxtx.h | 2 + > > drivers/net/txgbe/base/meson.build | 2 +- > > drivers/net/txgbe/base/txgbe_eeprom.h | 3 + > > drivers/net/txgbe/base/txgbe_hw.c | 128 +++++++++++++++++++++---- > > drivers/net/txgbe/base/txgbe_hw.h | 5 +- > > drivers/net/txgbe/base/txgbe_mng.c | 46 +++++++++ > > drivers/net/txgbe/base/txgbe_mng.h | 13 +++ > > drivers/net/txgbe/base/txgbe_osdep.h | 1 + > > drivers/net/txgbe/base/txgbe_regs.h | 7 ++ > > drivers/net/txgbe/base/txgbe_type.h | 3 + > > drivers/net/txgbe/txgbe_ethdev.c | 131 +++++++++++++++----------- > > drivers/net/txgbe/txgbe_ethdev.h | 2 +- > > drivers/net/txgbe/txgbe_ethdev_vf.c | 21 ++++- > > drivers/net/txgbe/txgbe_fdir.c | 3 + > > drivers/net/txgbe/txgbe_rxtx.c | 85 ++++++++++------- > > drivers/net/txgbe/txgbe_rxtx.h | 2 + > > 34 files changed, 601 insertions(+), 139 deletions(-) > > > > -- > > 2.27.0 > > >
On 7/5/2024 9:11 AM, Jiawen Wu wrote: > Hi, > >> -----Original Message----- >> From: Jiawen Wu <jiawenwu@trustnetic.com> >> Sent: Tuesday, June 25, 2024 9:51 AM >> To: dev@dpdk.org >> Subject: RE: [PATCH 00/19] Wangxun fixes and supports >> >> Hi, >> >>> -----Original Message----- >>> From: Jiawen Wu <jiawenwu@trustnetic.com> >>> Sent: Tuesday, June 18, 2024 3:12 PM >>> To: dev@dpdk.org >>> Cc: Jiawen Wu <jiawenwu@trustnetic.com> >>> Subject: [PATCH 00/19] Wangxun fixes and supports >>> >>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. >>> >>> Jiawen Wu (19): >>> net/txgbe: fix to parse tunnel packets >>> net/txgbe: fix flow filters in VT mode >>> net/txgbe: fix Tx hang on queue disable >>> net/txgbe: restrict the configuration of VLAN strip offload >>> net/txgbe: reconfigure more MAC Rx registers >>> net/txgbe: fix VF promiscuous and allmulticast >>> net/ngbe: special config for YT8531SH-CA PHY >>> net/ngbe: keep PHY power down while device probing >>> net/ngbe: add WOL and NCSI capability >>> net/txgbe: fix hotplug remove >>> net/ngbe: fix hotplug remove >>> net/txgbe: correct valid MTU range >>> net/ngbe: correct valid MTU range >>> net/txgbe: fix memory leak >>> net/ngbe: fix memory leak >>> net/txgbe: fix Rx interrupt >>> net/ngbe: support Rx interrupt >>> net/txgbe: disable LLDP by default >>> net/ngbe: disable LLDP by default >> > Series applied to dpdk-next-net/main, thanks.
Hello, On Sat, Jul 6, 2024 at 5:39 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. > >>> > >>> Jiawen Wu (19): > >>> net/txgbe: fix to parse tunnel packets > >>> net/txgbe: fix flow filters in VT mode > >>> net/txgbe: fix Tx hang on queue disable > >>> net/txgbe: restrict the configuration of VLAN strip offload > >>> net/txgbe: reconfigure more MAC Rx registers > >>> net/txgbe: fix VF promiscuous and allmulticast > >>> net/ngbe: special config for YT8531SH-CA PHY > >>> net/ngbe: keep PHY power down while device probing > >>> net/ngbe: add WOL and NCSI capability > >>> net/txgbe: fix hotplug remove > >>> net/ngbe: fix hotplug remove > >>> net/txgbe: correct valid MTU range > >>> net/ngbe: correct valid MTU range > >>> net/txgbe: fix memory leak > >>> net/ngbe: fix memory leak > >>> net/txgbe: fix Rx interrupt > >>> net/ngbe: support Rx interrupt > >>> net/txgbe: disable LLDP by default > >>> net/ngbe: disable LLDP by default > >> > > > > Series applied to dpdk-next-net/main, thanks. Compilation is broken for some ARM targets with next-net. It was detected by the CI: http://mails.dpdk.org/archives/test-report/2024-June/700549.html Jiawen, please send a fix.
On Thu, Jul 11, 2024 at 1:53 PM David Marchand <david.marchand@redhat.com> wrote: > On Sat, Jul 6, 2024 at 5:39 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > >>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. > > >>> > > >>> Jiawen Wu (19): > > >>> net/txgbe: fix to parse tunnel packets > > >>> net/txgbe: fix flow filters in VT mode > > >>> net/txgbe: fix Tx hang on queue disable > > >>> net/txgbe: restrict the configuration of VLAN strip offload > > >>> net/txgbe: reconfigure more MAC Rx registers > > >>> net/txgbe: fix VF promiscuous and allmulticast > > >>> net/ngbe: special config for YT8531SH-CA PHY > > >>> net/ngbe: keep PHY power down while device probing > > >>> net/ngbe: add WOL and NCSI capability > > >>> net/txgbe: fix hotplug remove > > >>> net/ngbe: fix hotplug remove > > >>> net/txgbe: correct valid MTU range > > >>> net/ngbe: correct valid MTU range > > >>> net/txgbe: fix memory leak > > >>> net/ngbe: fix memory leak > > >>> net/txgbe: fix Rx interrupt > > >>> net/ngbe: support Rx interrupt > > >>> net/txgbe: disable LLDP by default > > >>> net/ngbe: disable LLDP by default > > >> > > > > > > > Series applied to dpdk-next-net/main, thanks. > > Compilation is broken for some ARM targets with next-net. > It was detected by the CI: > http://mails.dpdk.org/archives/test-report/2024-June/700549.html > > Jiawen, please send a fix. Ferruh, Thomas, We have many build failure reports because of this series. What is the best approach while waiting for a fix? Can we drop patch 35c4da655a95 ("net/ngbe: disable LLDP by default") (which seems to be the cause) from next-net? Thanks.
On 7/12/2024 10:32 AM, David Marchand wrote: > On Thu, Jul 11, 2024 at 1:53 PM David Marchand > <david.marchand@redhat.com> wrote: >> On Sat, Jul 6, 2024 at 5:39 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: >>>>>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. >>>>>> >>>>>> Jiawen Wu (19): >>>>>> net/txgbe: fix to parse tunnel packets >>>>>> net/txgbe: fix flow filters in VT mode >>>>>> net/txgbe: fix Tx hang on queue disable >>>>>> net/txgbe: restrict the configuration of VLAN strip offload >>>>>> net/txgbe: reconfigure more MAC Rx registers >>>>>> net/txgbe: fix VF promiscuous and allmulticast >>>>>> net/ngbe: special config for YT8531SH-CA PHY >>>>>> net/ngbe: keep PHY power down while device probing >>>>>> net/ngbe: add WOL and NCSI capability >>>>>> net/txgbe: fix hotplug remove >>>>>> net/ngbe: fix hotplug remove >>>>>> net/txgbe: correct valid MTU range >>>>>> net/ngbe: correct valid MTU range >>>>>> net/txgbe: fix memory leak >>>>>> net/ngbe: fix memory leak >>>>>> net/txgbe: fix Rx interrupt >>>>>> net/ngbe: support Rx interrupt >>>>>> net/txgbe: disable LLDP by default >>>>>> net/ngbe: disable LLDP by default >>>>> >>>> >>> >>> Series applied to dpdk-next-net/main, thanks. >> >> Compilation is broken for some ARM targets with next-net. >> It was detected by the CI: >> http://mails.dpdk.org/archives/test-report/2024-June/700549.html >> >> Jiawen, please send a fix. > > Ferruh, Thomas, > > We have many build failure reports because of this series. > What is the best approach while waiting for a fix? > Can we drop patch 35c4da655a95 ("net/ngbe: disable LLDP by default") > (which seems to be the cause) from next-net? > Hi David, I can check if the error is trivial, and if so send a patch for it.
On 7/12/2024 1:47 PM, Ferruh Yigit wrote: > On 7/12/2024 10:32 AM, David Marchand wrote: >> On Thu, Jul 11, 2024 at 1:53 PM David Marchand >> <david.marchand@redhat.com> wrote: >>> On Sat, Jul 6, 2024 at 5:39 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: >>>>>>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. >>>>>>> >>>>>>> Jiawen Wu (19): >>>>>>> net/txgbe: fix to parse tunnel packets >>>>>>> net/txgbe: fix flow filters in VT mode >>>>>>> net/txgbe: fix Tx hang on queue disable >>>>>>> net/txgbe: restrict the configuration of VLAN strip offload >>>>>>> net/txgbe: reconfigure more MAC Rx registers >>>>>>> net/txgbe: fix VF promiscuous and allmulticast >>>>>>> net/ngbe: special config for YT8531SH-CA PHY >>>>>>> net/ngbe: keep PHY power down while device probing >>>>>>> net/ngbe: add WOL and NCSI capability >>>>>>> net/txgbe: fix hotplug remove >>>>>>> net/ngbe: fix hotplug remove >>>>>>> net/txgbe: correct valid MTU range >>>>>>> net/ngbe: correct valid MTU range >>>>>>> net/txgbe: fix memory leak >>>>>>> net/ngbe: fix memory leak >>>>>>> net/txgbe: fix Rx interrupt >>>>>>> net/ngbe: support Rx interrupt >>>>>>> net/txgbe: disable LLDP by default >>>>>>> net/ngbe: disable LLDP by default >>>>>> >>>>> >>>> >>>> Series applied to dpdk-next-net/main, thanks. >>> >>> Compilation is broken for some ARM targets with next-net. >>> It was detected by the CI: >>> http://mails.dpdk.org/archives/test-report/2024-June/700549.html >>> >>> Jiawen, please send a fix. >> >> Ferruh, Thomas, >> >> We have many build failure reports because of this series. >> What is the best approach while waiting for a fix? >> Can we drop patch 35c4da655a95 ("net/ngbe: disable LLDP by default") >> (which seems to be the cause) from next-net? >> > > Hi David, > > I can check if the error is trivial, and if so send a patch for it. > Error is: In function 'ngbe_host_interface_command', inlined from 'ngbe_host_interface_command' at ../drivers/net/ngbe/base/ngbe_mng.c:86:1, inlined from 'ngbe_hic_get_lldp' at ../drivers/net/ngbe/base/ngbe_mng.c:394:8: ../drivers/net/ngbe/base/ngbe_mng.c:127:36: error: array subscript 2 is outside array bounds of 'struct ngbe_hic_write_lldp[1]' [-Werror=array-bounds] 127 | buffer[bi] = rd32a(hw, NGBE_MNGMBX, bi); ../drivers/net/ngbe/base/ngbe_mng.c: In function 'ngbe_hic_get_lldp': ../drivers/net/ngbe/base/ngbe_mng.c:385:36: note: at offset 8 into object 'buffer' of size 8 385 | struct ngbe_hic_write_lldp buffer; | ^~~~~~ Problematic case only happens when 'resp->cmd == 0x30', but for 'get_lldp', cmd is 'FW_LLDP_GET_CMD' which is 0xF5, so practically this is not a real issue. To build the build log, we have options: 1. Extend "struct ngbe_hic_read_pcie" with 'u32 pad4' 2. Remove 'resp->cmd == 0x30' exception in 'ngbe_host_interface_command()' as that command seems not supported at all. But I can't be sure on possible side impacts of above changes. Another option is dropping this patch from the next-net and a fixed version can be merged back.
12/07/2024 14:47, Ferruh Yigit: > On 7/12/2024 10:32 AM, David Marchand wrote: > > On Thu, Jul 11, 2024 at 1:53 PM David Marchand > > <david.marchand@redhat.com> wrote: > >> On Sat, Jul 6, 2024 at 5:39 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >>>>>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. > >>>>>> > >>>>>> Jiawen Wu (19): > >>>>>> net/txgbe: fix to parse tunnel packets > >>>>>> net/txgbe: fix flow filters in VT mode > >>>>>> net/txgbe: fix Tx hang on queue disable > >>>>>> net/txgbe: restrict the configuration of VLAN strip offload > >>>>>> net/txgbe: reconfigure more MAC Rx registers > >>>>>> net/txgbe: fix VF promiscuous and allmulticast > >>>>>> net/ngbe: special config for YT8531SH-CA PHY > >>>>>> net/ngbe: keep PHY power down while device probing > >>>>>> net/ngbe: add WOL and NCSI capability > >>>>>> net/txgbe: fix hotplug remove > >>>>>> net/ngbe: fix hotplug remove > >>>>>> net/txgbe: correct valid MTU range > >>>>>> net/ngbe: correct valid MTU range > >>>>>> net/txgbe: fix memory leak > >>>>>> net/ngbe: fix memory leak > >>>>>> net/txgbe: fix Rx interrupt > >>>>>> net/ngbe: support Rx interrupt > >>>>>> net/txgbe: disable LLDP by default > >>>>>> net/ngbe: disable LLDP by default These 2 last patches are not pulled in the main branch in the hope that the build will pass OK in our UNH lab. > >>> Series applied to dpdk-next-net/main, thanks. > >> > >> Compilation is broken for some ARM targets with next-net. > >> It was detected by the CI: > >> http://mails.dpdk.org/archives/test-report/2024-June/700549.html > >> > >> Jiawen, please send a fix. > > > > Ferruh, Thomas, > > > > We have many build failure reports because of this series. > > What is the best approach while waiting for a fix? > > Can we drop patch 35c4da655a95 ("net/ngbe: disable LLDP by default") > > (which seems to be the cause) from next-net? > > > > Hi David, > > I can check if the error is trivial, and if so send a patch for it.
On Fri, Jul 12, 2024 11:31 PM, Ferruh Yigit wrote: > On 7/12/2024 1:47 PM, Ferruh Yigit wrote: > > On 7/12/2024 10:32 AM, David Marchand wrote: > >> On Thu, Jul 11, 2024 at 1:53 PM David Marchand > >> <david.marchand@redhat.com> wrote: > >>> On Sat, Jul 6, 2024 at 5:39 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >>>>>>> Fix some bugs in txgbe/ngbe, and support new features in ngbe driver. > >>>>>>> > >>>>>>> Jiawen Wu (19): > >>>>>>> net/txgbe: fix to parse tunnel packets > >>>>>>> net/txgbe: fix flow filters in VT mode > >>>>>>> net/txgbe: fix Tx hang on queue disable > >>>>>>> net/txgbe: restrict the configuration of VLAN strip offload > >>>>>>> net/txgbe: reconfigure more MAC Rx registers > >>>>>>> net/txgbe: fix VF promiscuous and allmulticast > >>>>>>> net/ngbe: special config for YT8531SH-CA PHY > >>>>>>> net/ngbe: keep PHY power down while device probing > >>>>>>> net/ngbe: add WOL and NCSI capability > >>>>>>> net/txgbe: fix hotplug remove > >>>>>>> net/ngbe: fix hotplug remove > >>>>>>> net/txgbe: correct valid MTU range > >>>>>>> net/ngbe: correct valid MTU range > >>>>>>> net/txgbe: fix memory leak > >>>>>>> net/ngbe: fix memory leak > >>>>>>> net/txgbe: fix Rx interrupt > >>>>>>> net/ngbe: support Rx interrupt > >>>>>>> net/txgbe: disable LLDP by default > >>>>>>> net/ngbe: disable LLDP by default > >>>>>> > >>>>> > >>>> > >>>> Series applied to dpdk-next-net/main, thanks. > >>> > >>> Compilation is broken for some ARM targets with next-net. > >>> It was detected by the CI: > >>> http://mails.dpdk.org/archives/test-report/2024-June/700549.html > >>> > >>> Jiawen, please send a fix. > >> > >> Ferruh, Thomas, > >> > >> We have many build failure reports because of this series. > >> What is the best approach while waiting for a fix? > >> Can we drop patch 35c4da655a95 ("net/ngbe: disable LLDP by default") > >> (which seems to be the cause) from next-net? > >> > > > > Hi David, > > > > I can check if the error is trivial, and if so send a patch for it. > > > > Error is: > In function 'ngbe_host_interface_command', > inlined from 'ngbe_host_interface_command' at > ../drivers/net/ngbe/base/ngbe_mng.c:86:1, > inlined from 'ngbe_hic_get_lldp' at > ../drivers/net/ngbe/base/ngbe_mng.c:394:8: > ../drivers/net/ngbe/base/ngbe_mng.c:127:36: error: array subscript 2 is > outside array bounds of 'struct ngbe_hic_write_lldp[1]' > [-Werror=array-bounds] > 127 | buffer[bi] = rd32a(hw, NGBE_MNGMBX, bi); > ../drivers/net/ngbe/base/ngbe_mng.c: In function 'ngbe_hic_get_lldp': > ../drivers/net/ngbe/base/ngbe_mng.c:385:36: note: at offset 8 into > object 'buffer' of size 8 > 385 | struct ngbe_hic_write_lldp buffer; > | ^~~~~~ > > > Problematic case only happens when 'resp->cmd == 0x30', but for > 'get_lldp', cmd is 'FW_LLDP_GET_CMD' which is 0xF5, so practically this > is not a real issue. > > To build the build log, we have options: > 1. Extend "struct ngbe_hic_read_pcie" with 'u32 pad4' > 2. Remove 'resp->cmd == 0x30' exception in > 'ngbe_host_interface_command()' as that command seems not supported at all. > > But I can't be sure on possible side impacts of above changes. > > Another option is dropping this patch from the next-net and a fixed > version can be merged back. Sorry for these build error, I don't have a platform to verify this yet. But I think the fix should be extending 'struct ngbe_hic_write_lldp'.