| Message ID | 20240318111838.16991-1-fengchengwen@huawei.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31FA043CE3; Mon, 18 Mar 2024 12:21:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 028C34027F; Mon, 18 Mar 2024 12:21:03 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 9F3CE40A6B for <dev@dpdk.org>; Mon, 18 Mar 2024 12:21:00 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4TysmN149QzwPgh; Mon, 18 Mar 2024 19:18:28 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id ACA4F140259; Mon, 18 Mar 2024 19:20:58 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Mar 2024 19:20:58 +0800 From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <david.marchand@redhat.com> CC: <dev@dpdk.org> Subject: [PATCH v4 0/6] refine argparse library Date: Mon, 18 Mar 2024 11:18:32 +0000 Message-ID: <20240318111838.16991-1-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240220131502.47510-1-fengchengwen@huawei.com> References: <20240220131502.47510-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
refine argparse library
|
|
Message
fengchengwen
March 18, 2024, 11:18 a.m. UTC
I found a couple of issues when I revisited the argparse_autotest output, so got this patchset. Chengwen Feng (6): argparse: refine error message argparse: remove dead code argparse: replace flag enum with marco argparse: fix argument flags operate as uint32 type test/argparse: refine testcases argparse: fix doc don't display two hyphens --- v4: address Thomas's comment on 4/6 commit: - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. v3: - address Thomas's comment on 4/6 comit. - add commit: fix doc don't display two hyphens. v2: address David Marchand's comment: - replace flag enum with marco. - replace flag's hardcode with macro in test_argparse.c. app/test/test_argparse.c | 65 +++++++++++--------- doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- lib/argparse/rte_argparse.c | 61 +++++++++--------- lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- 4 files changed, 127 insertions(+), 131 deletions(-)
Comments
18/03/2024 12:18, Chengwen Feng: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argparse: fix argument flags operate as uint32 type > test/argparse: refine testcases > argparse: fix doc don't display two hyphens I'd like to get an approval from someone else for the API changes here. I feel it is better to wait post 24.03. Anyway it is a fresh experimental API.
Hi Thomas, On 2024/3/22 1:27, Thomas Monjalon wrote: > 18/03/2024 12:18, Chengwen Feng: >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: refine error message >> argparse: remove dead code >> argparse: replace flag enum with marco >> argparse: fix argument flags operate as uint32 type >> test/argparse: refine testcases >> argparse: fix doc don't display two hyphens > > I'd like to get an approval from someone else for the API changes here. > I feel it is better to wait post 24.03. > Anyway it is a fresh experimental API. That's OK Thanks > > > > . >
Hi Thomas, On 2024/3/22 1:27, Thomas Monjalon wrote: > 18/03/2024 12:18, Chengwen Feng: >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: refine error message >> argparse: remove dead code >> argparse: replace flag enum with marco >> argparse: fix argument flags operate as uint32 type >> test/argparse: refine testcases >> argparse: fix doc don't display two hyphens > > I'd like to get an approval from someone else for the API changes here. > I feel it is better to wait post 24.03. > Anyway it is a fresh experimental API. Could you review this patchset and merge? BTW: this patchset also fixes bug 1409 Thanks > > > > . >
Kindly ping. Best regards, Chengwen Feng On 2024/3/18 19:18, Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argparse: fix argument flags operate as uint32 type > test/argparse: refine testcases > argparse: fix doc don't display two hyphens > > --- > v4: address Thomas's comment on 4/6 commit: > - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and > TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. > v3: > - address Thomas's comment on 4/6 comit. > - add commit: fix doc don't display two hyphens. > v2: address David Marchand's comment: > - replace flag enum with marco. > - replace flag's hardcode with macro in test_argparse.c. > > app/test/test_argparse.c | 65 +++++++++++--------- > doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- > lib/argparse/rte_argparse.c | 61 +++++++++--------- > lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- > 4 files changed, 127 insertions(+), 131 deletions(-) >
For the patchset, Acked-by: Jie Hai <haijie1@huawei.com> On 2024/3/18 19:18, Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argparse: fix argument flags operate as uint32 type > test/argparse: refine testcases > argparse: fix doc don't display two hyphens > --- > v4: address Thomas's comment on 4/6 commit: > - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and > TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. > v3: > - address Thomas's comment on 4/6 comit. > - add commit: fix doc don't display two hyphens. > v2: address David Marchand's comment: > - replace flag enum with marco. > - replace flag's hardcode with macro in test_argparse.c. > > app/test/test_argparse.c | 65 +++++++++++--------- > doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- > lib/argparse/rte_argparse.c | 61 +++++++++--------- > lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- > 4 files changed, 127 insertions(+), 131 deletions(-) >
For the patchset, Reviewed-by: Dengdui Huang <huangdengdui@huawei.com> On 2024/3/18 19:18, Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argparse: fix argument flags operate as uint32 type > test/argparse: refine testcases > argparse: fix doc don't display two hyphens > > --- > v4: address Thomas's comment on 4/6 commit: > - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and > TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. > v3: > - address Thomas's comment on 4/6 comit. > - add commit: fix doc don't display two hyphens. > v2: address David Marchand's comment: > - replace flag enum with marco. > - replace flag's hardcode with macro in test_argparse.c. > > app/test/test_argparse.c | 65 +++++++++++--------- > doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- > lib/argparse/rte_argparse.c | 61 +++++++++--------- > lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- > 4 files changed, 127 insertions(+), 131 deletions(-) >
Hi Thomas and David, This patchset is good enhance for argparse library, we hope it could upstream to DPDK 24.11. Please look at it. Thanks On 2024/7/4 11:07, fengchengwen wrote: > Kindly ping. > > Best regards, > Chengwen Feng > > On 2024/3/18 19:18, Chengwen Feng wrote: >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: refine error message >> argparse: remove dead code >> argparse: replace flag enum with marco >> argparse: fix argument flags operate as uint32 type >> test/argparse: refine testcases >> argparse: fix doc don't display two hyphens >> >> --- >> v4: address Thomas's comment on 4/6 commit: >> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and >> TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK. >> v3: >> - address Thomas's comment on 4/6 comit. >> - add commit: fix doc don't display two hyphens. >> v2: address David Marchand's comment: >> - replace flag enum with marco. >> - replace flag's hardcode with macro in test_argparse.c. >> >> app/test/test_argparse.c | 65 +++++++++++--------- >> doc/guides/prog_guide/argparse_lib.rst | 47 +++++++------- >> lib/argparse/rte_argparse.c | 61 +++++++++--------- >> lib/argparse/rte_argparse.h | 85 ++++++++++++-------------- >> 4 files changed, 127 insertions(+), 131 deletions(-) >> > . >