From patchwork Wed Feb 28 17:00:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 713 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B38A143C2C; Wed, 28 Feb 2024 18:01:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98D6740EE2; Wed, 28 Feb 2024 18:01:36 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id 9AA7E4003C for ; Wed, 28 Feb 2024 18:01:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c3wVKUjBMswF8l3zIVRThCKEw0X19z7gm9S9ukNCcm6bqL60ttWn0MtutNN7q8E6qP68CsE9oyTE9jNRXiheKZdaldujl0IQr/mx5drnT+J1uAM2ZyPn23lUYKX74UYhe2rBHB0vmeVToaQs9F7coPNUXZDeDOW3xHigsdX6vJ1Pb6oJzn1smlNo/SK5pbiyC8awVtg2txHFvqFMcbw/RCcUNQvhWwHPYT3LB4Qoys5ng/aQyDrDrDFOZStVvPQe9VVrIjxKjbhkESOJlnB2U13zE6FCVyUJeJFEQi0i5oPRxn1XFVBqmf/G4rAMcOyCFkiSmViAZob2gOi2iQi9kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DJ6rPPBTQZbFX+1ukaGeqLQqOwLnQF1+VA3tUJbe3CM=; b=fr5eUdfYRn+dlIZhqMAiXJhZDtIqSs1oVhp/CD81Eysrw+ClzjYpFWOaTGZf5odSrToh5iiA86dhf6ItMfl5qMclO7SRM2Fr/mJF5fYAYEmmvBzhnA2tTXqzLRONAgiHx+LZVkLE7v0pB7wtfGobVYgxfIK01PGA9tuQ9YSSQfAcE9bpDBbhgVO/W+MmvmNF4jYrRK6yrQ9udNuVmhsDMVUmSmQQzKIWJ3N9nYywP+mMYJWGdPgHZ000c2HEfPt8sD1CCClIXZ64sWsV2QwKz+fxi3bTS8m8DOFgHLMJY1JGDIk9t4AP+UTZKoX8FD0gbgYcF5NquZVGsOSiCQ03zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DJ6rPPBTQZbFX+1ukaGeqLQqOwLnQF1+VA3tUJbe3CM=; b=Jsu82+O9dduT3qzl+cRijF9ZefV78pmDQ6Rs9wb9U/084dxmEpbRtkNAWkISe2G5O2WYXGHVwbTWQVf3ndA0fkcnxOH9USBEDf7ww1kS73DQ9T21tG06ozrtWn/10U5oNlIGQDsxWWKBToFR6jAyErW8VHA+iyt9ejBXVZ5O82IlQziL187c+wcV3HH+cQpgO83v3so3R9tiHkia6Y32aM6zCEnOwNssSpZOayQztt1XwmeodDTikSUtTjrcRSG18R8ZBW4JJ2dl2w2N7JdXnGQn9Hfc4vZgOgUle6BjlrAOBYQdzNfkl6RZCu6v00qPQEp+BGFiyNLLsN5XnwZGiQ== Received: from BYAPR07CA0010.namprd07.prod.outlook.com (2603:10b6:a02:bc::23) by PH8PR12MB7280.namprd12.prod.outlook.com (2603:10b6:510:220::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.34; Wed, 28 Feb 2024 17:01:31 +0000 Received: from SJ1PEPF00001CE0.namprd05.prod.outlook.com (2603:10b6:a02:bc:cafe::2c) by BYAPR07CA0010.outlook.office365.com (2603:10b6:a02:bc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.49 via Frontend Transport; Wed, 28 Feb 2024 17:01:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF00001CE0.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Wed, 28 Feb 2024 17:01:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 28 Feb 2024 09:01:05 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 28 Feb 2024 09:01:02 -0800 From: Dariusz Sosnowski To: Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad CC: , Raslan Darawsheh , Bing Zhao Subject: [PATCH 00/11] net/mlx5: flow insertion performance improvements Date: Wed, 28 Feb 2024 18:00:35 +0100 Message-ID: <20240228170046.176600-1-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE0:EE_|PH8PR12MB7280:EE_ X-MS-Office365-Filtering-Correlation-Id: df5bb809-36e6-4c14-797e-08dc387ee953 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /6eLCXr6TrxB96VLu10H+E/saR611CAiAtK6+iLM/JwvDhXWKWhurpx2kvayLC8iWQSDMOKnY9Yo6e1W+7mqiKYvgAdN+03AAnn8h2vWD88loh98YYl9xtGiXctny5Y/MI8mauLxpdxqD01zjPA5XRxjJ4tLgcsDHuV5xzTPKbfLRiPhTEPac4QxbaAdc3UTt+Q77wvOxRP5TqsX5d5APijDmOX3yyVNyZIHP31NODxOMfaiuTd1ff3E9ynZo65s2Ha1DMx3ckGQfg7dULIiM1wC52iTgrd9/p7KcJxwUh23LOXiJ8e9/m+FN8ULhJ5zcRmIGQ0GAZhhwt/hSzzAC7yyoeY8EO09LcmoJhVQBA0VwfSvSIiT1WrqrlHc2VQXxGT867cSBdkw7R/5VUpcFnutiBVoV86VUHDHa9H//mP1uhbVpCD6yXQGWBrHMQTecUfqBnoHynrGc0R0z/E4FZFrJ+y12uE8R1AVZHR534fMn37E4/UXjXOZ9lZ+2y0zPONEU81FY+33KWHZHXGjHz4ERRkSDFI3ijkPmroZsB9Kk1exKNbMdWNsqFlpE3jLfDTyiOa78O1ZC/lbqTGSgpZBzKcuttJGkgSyydYEuvhdhqAYautWPcf0BUdUgey6pZK6gddfsnmD8Q4LLd6vaqV8bvMj59DPBCPVystit3H46rTvickHY1hzvujRwWYeVzhCkWMuWYoEwQROnPjb//0BMGyteq104K5owVJkPAK6pDMmCUn17BZPksnPySCn X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 17:01:31.0426 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: df5bb809-36e6-4c14-797e-08dc387ee953 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7280 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Goal of this patchset is to improve the throughput of flow insertion and deletion in mlx5 PMD when HW Steering flow engine is used. - Patch 1 - Use preallocated per-queue, per-actions template buffer for storing translated flow actions, instead of allocating and filling it on demand, on each flow operation. - Patches 2-4 - Make resource index allocation optional. This allocation will be skipped when it is not required by the created template table. - Patches 5-7 - Reduce memory footprint of the internal flow queue. - Patch 8 - Remove indirection between flow job and flow itself, by using flow as an operation container. - Patches 9-10 - Reduce memory footpring of flow struct by moving rarely used flow fields outside of the main flow struct. These fields will accesses only when needed. Also remove unneeded `zmalloc` usage. - Patch 11 - Remove unneeded device status check in flow create. In general all of these changes result in the following improvements (all numbers are averaged Kflows/sec): | | Insertion) | +% | Deletion | +% | |--------------|:----------:|:------:|:--------:|:-----:| | baseline | 6338.7 | | 9739.6 | | | improvements | 6978.8 | +10.1% | 10432.4 | +7.1% | The basic benchmark was run on ConnectX-6 Dx (22.40.1000), on the system with Intel Xeon Platinum 8380 CPU. Bing Zhao (2): net/mlx5: skip the unneeded resource index allocation net/mlx5: remove unneeded device status checking Dariusz Sosnowski (7): net/mlx5: allocate local DR rule action buffers net/mlx5: remove action params from job net/mlx5: remove flow pattern from job net/mlx5: remove updated flow from job net/mlx5: use flow as operation container net/mlx5: move rarely used flow fields outside net/mlx5: reuse flow fields Erez Shitrit (2): net/mlx5/hws: add check for matcher rule update support net/mlx5/hws: add check if matcher contains complex rules drivers/net/mlx5/hws/mlx5dr.h | 16 + drivers/net/mlx5/hws/mlx5dr_action.c | 6 + drivers/net/mlx5/hws/mlx5dr_action.h | 2 + drivers/net/mlx5/hws/mlx5dr_matcher.c | 29 + drivers/net/mlx5/mlx5.h | 29 +- drivers/net/mlx5/mlx5_flow.h | 128 ++++- drivers/net/mlx5/mlx5_flow_hw.c | 794 ++++++++++++++++---------- 7 files changed, 666 insertions(+), 338 deletions(-) --- 2.39.2