Message ID | 20240208171330.31139-1-ajit.khaparde@broadcom.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C38D843AE1; Thu, 8 Feb 2024 18:13:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE99842E28; Thu, 8 Feb 2024 18:13:37 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id F15C242E27 for <dev@dpdk.org>; Thu, 8 Feb 2024 18:13:35 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5ce942efda5so1572646a12.2 for <dev@dpdk.org>; Thu, 08 Feb 2024 09:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1707412415; x=1708017215; darn=dpdk.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=miTWGOzNuRHYsTmacw3bPK3//Qes2CDW3alIb4J9dzQ=; b=I5A6drprwqvgvbE2YMZHTpohFbtQEFXIwsdii3JLIKqleel4HNXk0x45jUQtIes9fz cL5o1FZwqQFj3W5Sg8PMHRMJhNwUStBRoTJ7F0GfxWPnEeD0E24wlTteiBWckgs4olRE sSMe1j0RhuceRQNi1P8eJS7NtMH4xtuV1Q6JI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707412415; x=1708017215; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=miTWGOzNuRHYsTmacw3bPK3//Qes2CDW3alIb4J9dzQ=; b=gNofBMR3RywTO7zlwBdaZD+2BNm406eFky9XoLVuXebw/DUN0IcNQTapTmEZ4pQ4U/ yBUKWOisoxwn+0aJDMkf3/NPAez86UjsDHxdZzz5+83bc2RtFTPjYbZ4cJqdGr8LrCL+ UG5ppdbkxToM2RxhAYZRU/27TZ10QZYyGgi3vF4U13Vu/6/hA3YrjMijYTkBAOqYaIZe IdsnxMliPUpj/3k3fhe9Pg9zp/Jx8x+BDhuD4iUpDopBRvXbLVu/oL1Cq1Q26WN5FnjO v8ZUgb2k5mJQSL8+ok/JwPW+pIjgpOL9pg53rgKmqqXZlYBMP7JD/vTe3ga0tw5E99Nj Sijw== X-Gm-Message-State: AOJu0YxNp2p602VY0H30CeATMd6vMPkwSgYdVkQTVQh7304RTXh1FPWv 1P5c7psUHjtNWqI1S4BQ/8DIiFVfJ2P7+/f6Vz7zUaawkF3tb/OxGRzzR19gOmJfcA28HDE/UIA nhDZWPVl89oGUytEu3QvXCCJMSipBXQX0UgTk5WjnXB3kv3Awbw5SznWMuKSdwVG/eE4V9/UzdP RJXbFsJxKQXUgCmHlAGvbQ/FZz8bMg X-Google-Smtp-Source: AGHT+IFpxgMMhomf8U5Bk/uAtv9EtdP0AUMqxTCU2bW+utI3VAQouOSN2eCAcTjl+5whlz3TvPQY0w== X-Received: by 2002:a05:6a20:918c:b0:19e:9b19:96c0 with SMTP id v12-20020a056a20918c00b0019e9b1996c0mr285278pzd.7.1707412414496; Thu, 08 Feb 2024 09:13:34 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id p15-20020aa79e8f000000b006e0527ffe88sm3966204pfq.213.2024.02.08.09.13.33 for <dev@dpdk.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 09:13:33 -0800 (PST) From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: dev@dpdk.org Subject: [PATCH 0/7] bnxt bug fixes Date: Thu, 8 Feb 2024 09:13:23 -0800 Message-Id: <20240208171330.31139-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007c01980610e1ee4d" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
bnxt bug fixes
|
|
Message
Ajit Khaparde
Feb. 8, 2024, 5:13 p.m. UTC
Patchset with bug fixes for bnxt PMD. Patch based against the next-net-brcm for-next-net branch. Please apply. Ajit Khaparde (4): net/bnxt: modify locking for representor Tx net/bnxt: refactor VNIC context cleanup net/bnxt: update consumer index of NQ regularly net/bnxt: update RSS algorithm capability Damodharam Ammepalli (1): net/bnxt: cleanup vnic ref count Kishore Padmanabha (1): net/bnxt: avoid seg fault in Tx queue release Shuanglin Wang (1): net/bnxt: adjust session name on multi host system drivers/net/bnxt/bnxt.h | 2 +- drivers/net/bnxt/bnxt_ethdev.c | 14 +++----- drivers/net/bnxt/bnxt_hwrm.c | 16 +++++++-- drivers/net/bnxt/bnxt_irq.c | 26 +++++++++++--- drivers/net/bnxt/bnxt_reps.c | 6 ++-- drivers/net/bnxt/bnxt_txq.c | 8 ++++- drivers/net/bnxt/bnxt_txq.h | 1 + drivers/net/bnxt/bnxt_txr.c | 13 +++++++ drivers/net/bnxt/bnxt_txr.h | 4 ++- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++ 10 files changed, 125 insertions(+), 23 deletions(-)
Comments
On Thu, Feb 8, 2024 at 9:13 AM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > > Patchset with bug fixes for bnxt PMD. > Patch based against the > next-net-brcm for-next-net branch. > > Please apply. Patchset merged to the dpdk-next-brcm for-next-net branch. Thanks > > Ajit Khaparde (4): > net/bnxt: modify locking for representor Tx > net/bnxt: refactor VNIC context cleanup > net/bnxt: update consumer index of NQ regularly > net/bnxt: update RSS algorithm capability > > Damodharam Ammepalli (1): > net/bnxt: cleanup vnic ref count > > Kishore Padmanabha (1): > net/bnxt: avoid seg fault in Tx queue release > > Shuanglin Wang (1): > net/bnxt: adjust session name on multi host system > > drivers/net/bnxt/bnxt.h | 2 +- > drivers/net/bnxt/bnxt_ethdev.c | 14 +++----- > drivers/net/bnxt/bnxt_hwrm.c | 16 +++++++-- > drivers/net/bnxt/bnxt_irq.c | 26 +++++++++++--- > drivers/net/bnxt/bnxt_reps.c | 6 ++-- > drivers/net/bnxt/bnxt_txq.c | 8 ++++- > drivers/net/bnxt/bnxt_txq.h | 1 + > drivers/net/bnxt/bnxt_txr.c | 13 +++++++ > drivers/net/bnxt/bnxt_txr.h | 4 ++- > drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++ > 10 files changed, 125 insertions(+), 23 deletions(-) > > -- > 2.39.2 (Apple Git-143) >
https://patchwork.dpdk.org/project/dpdk/patch/20240208171330.31139-8-ajit.khaparde@broadcom.com/ Hi Ajit, So you know, this series did fail in CI testing, and now that it is merged to main, all patchseries are failing DTS at EAL. Performance testing is also offline for the same reason. I will run the niccli utility to upgrade broadcom NIC firmware on the system and give it a rerun. Otherwise, let me know what you think. This occurs on our ARM Ampere server, with the BCM57414 NetXtreme-E 10Gb/25Gb 21:02:08 [00;36m TestScatter: Test Case test_scatter_mbuf_2048 Begin [0m 21:02:08 dut.arm-ampere-dut.dpdklab.iol.unh.edu: x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a 0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854 -- -i --mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00008000 [0m 21:04:14 [01;31m TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: TIMEOUT on x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a 0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854 -- -i --mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00008000 [0m 21:04:14 [01;31m TestScatter: EAL: Detected CPU lcores: 160 21:04:14 EAL: Detected NUMA nodes: 2 21:04:14 EAL: Detected static linkage of DPDK 21:04:14 EAL: Multi-process socket /var/run/dpdk/dpdk_2978774_20240222015854/mp_socket 21:04:14 EAL: Selected IOVA mode 'VA' 21:04:14 EAL: VFIO support initialized 21:04:14 EAL: Using IOMMU type 1 (Type 1) 21:04:14 EAL: Probe PCI driver: net_bnxt (14e4:16d7) device: 0007:01:00.0 (socket 1) 21:04:14 Segmentation fault (core dumped) I'll let you know how reruns go. On Thu, Feb 8, 2024 at 4:51 PM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > On Thu, Feb 8, 2024 at 9:13 AM Ajit Khaparde <ajit.khaparde@broadcom.com> > wrote: > > > > Patchset with bug fixes for bnxt PMD. > > Patch based against the > > next-net-brcm for-next-net branch. > > > > Please apply. > Patchset merged to the dpdk-next-brcm for-next-net branch. > Thanks > > > > > Ajit Khaparde (4): > > net/bnxt: modify locking for representor Tx > > net/bnxt: refactor VNIC context cleanup > > net/bnxt: update consumer index of NQ regularly > > net/bnxt: update RSS algorithm capability > > > > Damodharam Ammepalli (1): > > net/bnxt: cleanup vnic ref count > > > > Kishore Padmanabha (1): > > net/bnxt: avoid seg fault in Tx queue release > > > > Shuanglin Wang (1): > > net/bnxt: adjust session name on multi host system > > > > drivers/net/bnxt/bnxt.h | 2 +- > > drivers/net/bnxt/bnxt_ethdev.c | 14 +++----- > > drivers/net/bnxt/bnxt_hwrm.c | 16 +++++++-- > > drivers/net/bnxt/bnxt_irq.c | 26 +++++++++++--- > > drivers/net/bnxt/bnxt_reps.c | 6 ++-- > > drivers/net/bnxt/bnxt_txq.c | 8 ++++- > > drivers/net/bnxt/bnxt_txq.h | 1 + > > drivers/net/bnxt/bnxt_txr.c | 13 +++++++ > > drivers/net/bnxt/bnxt_txr.h | 4 ++- > > drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++ > > 10 files changed, 125 insertions(+), 23 deletions(-) > > > > -- > > 2.39.2 (Apple Git-143) > > >
On Wed, Feb 21, 2024 at 6:50 PM Patrick Robb <probb@iol.unh.edu> wrote: > > https://patchwork.dpdk.org/project/dpdk/patch/20240208171330.31139-8-ajit.khaparde@broadcom.com/ > > Hi Ajit, > > So you know, this series did fail in CI testing, and now that it is merged to main, all patchseries are failing DTS at EAL. Performance testing is also offline for the same reason. > > I will run the niccli utility to upgrade broadcom NIC firmware on the system and give it a rerun. Otherwise, let me know what you think. > > This occurs on our ARM Ampere server, with the BCM57414 NetXtreme-E 10Gb/25Gb > > 21:02:08 [00;36m TestScatter: Test Case test_scatter_mbuf_2048 Begin [0m > 21:02:08 dut.arm-ampere-dut.dpdklab.iol.unh.edu: x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a 0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854 -- -i --mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00008000 [0m > 21:04:14 [01;31m TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: TIMEOUT on x86_64-native-linux-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0007:01:00.0 -a 0007:01:00.1 --file-prefix=dpdk_2978774_20240222015854 -- -i --mbcache=200 --mbuf-size=1024 --portmask=0x1 --max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00008000 [0m > 21:04:14 [01;31m TestScatter: EAL: Detected CPU lcores: 160 > 21:04:14 EAL: Detected NUMA nodes: 2 > 21:04:14 EAL: Detected static linkage of DPDK > 21:04:14 EAL: Multi-process socket /var/run/dpdk/dpdk_2978774_20240222015854/mp_socket > 21:04:14 EAL: Selected IOVA mode 'VA' > 21:04:14 EAL: VFIO support initialized > 21:04:14 EAL: Using IOMMU type 1 (Type 1) > 21:04:14 EAL: Probe PCI driver: net_bnxt (14e4:16d7) device: 0007:01:00.0 (socket 1) > 21:04:14 Segmentation fault (core dumped) > > I'll let you know how reruns go. Ok Thanks for bringing it to my attention. Let me know how the rerun goes. I had run the tests on my ARM setup and did not see the problem. Let me try again. Thanks Ajit > > On Thu, Feb 8, 2024 at 4:51 PM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: >> >> On Thu, Feb 8, 2024 at 9:13 AM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: >> > >> > Patchset with bug fixes for bnxt PMD. >> > Patch based against the >> > next-net-brcm for-next-net branch. >> > >> > Please apply. >> Patchset merged to the dpdk-next-brcm for-next-net branch. >> Thanks >> >> > >> > Ajit Khaparde (4): >> > net/bnxt: modify locking for representor Tx >> > net/bnxt: refactor VNIC context cleanup >> > net/bnxt: update consumer index of NQ regularly >> > net/bnxt: update RSS algorithm capability >> > >> > Damodharam Ammepalli (1): >> > net/bnxt: cleanup vnic ref count >> > >> > Kishore Padmanabha (1): >> > net/bnxt: avoid seg fault in Tx queue release >> > >> > Shuanglin Wang (1): >> > net/bnxt: adjust session name on multi host system >> > >> > drivers/net/bnxt/bnxt.h | 2 +- >> > drivers/net/bnxt/bnxt_ethdev.c | 14 +++----- >> > drivers/net/bnxt/bnxt_hwrm.c | 16 +++++++-- >> > drivers/net/bnxt/bnxt_irq.c | 26 +++++++++++--- >> > drivers/net/bnxt/bnxt_reps.c | 6 ++-- >> > drivers/net/bnxt/bnxt_txq.c | 8 ++++- >> > drivers/net/bnxt/bnxt_txq.h | 1 + >> > drivers/net/bnxt/bnxt_txr.c | 13 +++++++ >> > drivers/net/bnxt/bnxt_txr.h | 4 ++- >> > drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 58 ++++++++++++++++++++++++++++++ >> > 10 files changed, 125 insertions(+), 23 deletions(-) >> > >> > -- >> > 2.39.2 (Apple Git-143) >> > > >