[v5,00/18] Replace uses of PMD logtype

Message ID 20231221164841.125006-1-stephen@networkplumber.org (mailing list archive)
Headers
Series Replace uses of PMD logtype |

Message

Stephen Hemminger Dec. 21, 2023, 4:46 p.m. UTC
  The generic RTE_LOGTYPE_PMD is a leftover and should be removed.
This replaces all uses in current tree. It leaves PMD logtype
as deprecated because there maybe other uses in external projects
leftover.

This version does not use Depends-on: because CI system can't
handle that and want to make sure no PMD left behind.

v5 - incorporate review feedback

David Marchand (1):
  drivers: use dedicated logtypes

Stephen Hemminger (17):
  common/sfc_efx: remove use of PMD logtype
  mempool/dpaa2: use driver logtype not PMD
  net/dpaa: use dedicated logtype not PMD
  net/dpaa2: used dedicated logtype not PMD
  net/mvpp2: use dedicated logtype
  net/vmxnet3: used dedicated logtype not PMD
  raw/cnxk: replace PMD logtype with dynamic type
  crypto/scheduler: replace use of logtype PMD
  crypto/ccp: do not use PMD logtype
  crypto/caam_jr: use dedicated logtype
  crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype
  event/dlb2: use dedicated logtype
  event/dpaa, event/dpaa2: use dedicated logtype
  event/skeleton: replace logtype PMD with dynamic type
  net/nfb: use dynamic logtype
  examples/fips_validation: replace use of PMD logtype
  log: mark PMD logtype as deprecated

 .../baseband/la12xx/bbdev_la12xx_pmd_logs.h   |   3 +-
 drivers/bus/cdx/cdx_logs.h                    |   3 +-
 drivers/bus/fslmc/fslmc_logs.h                |   3 +-
 drivers/common/cnxk/roc_platform.h            |  16 +-
 drivers/common/cpt/cpt_pmd_logs.h             |   6 +-
 drivers/common/dpaax/caamflib/compat.h        |   4 +-
 drivers/common/dpaax/dpaax_logs.h             |   3 +-
 drivers/common/dpaax/version.map              |   1 +
 drivers/common/idpf/idpf_common_logs.h        |   5 +-
 drivers/common/sfc_efx/sfc_efx.c              |  11 +-
 drivers/common/sfc_efx/sfc_efx_log.h          |   2 +-
 drivers/crypto/caam_jr/caam_jr.c              |  46 ++-
 drivers/crypto/caam_jr/caam_jr_log.h          |  15 +-
 drivers/crypto/caam_jr/caam_jr_uio.c          |   4 +-
 drivers/crypto/ccp/rte_ccp_pmd.c              |  13 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c   |   6 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_logs.h     |   3 +-
 drivers/crypto/dpaa_sec/dpaa_sec.c            |  30 +-
 drivers/crypto/dpaa_sec/dpaa_sec_log.h        |   3 +-
 drivers/crypto/scheduler/scheduler_pmd.c      |   4 +-
 drivers/dma/dpaa/dpaa_qdma_logs.h             |   3 +-
 drivers/dma/dpaa2/dpaa2_qdma_logs.h           |   3 +-
 drivers/event/dlb2/dlb2.c                     | 275 +++++++++---------
 drivers/event/dlb2/dlb2_log.h                 |   3 +-
 drivers/event/dpaa/dpaa_eventdev.c            |   2 +-
 drivers/event/dpaa2/dpaa2_eventdev.c          |   4 +-
 drivers/event/dpaa2/dpaa2_eventdev_logs.h     |   3 +-
 drivers/event/dpaa2/dpaa2_eventdev_selftest.c |   6 +-
 drivers/event/skeleton/skeleton_eventdev.c    |   4 +-
 drivers/event/skeleton/skeleton_eventdev.h    |   8 +-
 drivers/mempool/dpaa/dpaa_mempool.c           |   1 +
 drivers/mempool/dpaa/dpaa_mempool.h           |   2 +-
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c      |   4 +-
 drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h |   3 +-
 drivers/net/atlantic/atl_logs.h               |   5 +-
 drivers/net/avp/avp_logs.h                    |   5 +-
 drivers/net/bnxt/bnxt.h                       |   1 +
 drivers/net/bnxt/bnxt_rxtx_vec_neon.c         |   2 +-
 drivers/net/bnxt/bnxt_rxtx_vec_sse.c          |   2 +-
 drivers/net/bnxt/bnxt_txr.c                   |   2 +-
 drivers/net/dpaa/dpaa_ethdev.c                |   8 +-
 drivers/net/dpaa/dpaa_ethdev.h                |   3 +-
 drivers/net/dpaa2/dpaa2_ethdev.c              |   2 +-
 drivers/net/dpaa2/dpaa2_pmd_logs.h            |   3 +-
 drivers/net/dpaa2/dpaa2_sparser.c             |   4 +-
 drivers/net/enetc/enetc_logs.h                |   3 +-
 drivers/net/enetfec/enet_pmd_logs.h           |   3 +-
 drivers/net/igc/igc_logs.h                    |   5 +-
 drivers/net/mana/mana.h                       |   3 +-
 drivers/net/mvpp2/mrvl_ethdev.c               |   4 +-
 drivers/net/nfb/nfb.h                         |   5 +
 drivers/net/nfb/nfb_ethdev.c                  |  24 +-
 drivers/net/nfb/nfb_rx.c                      |   9 +-
 drivers/net/nfb/nfb_rx.h                      |   2 +-
 drivers/net/nfb/nfb_tx.c                      |   9 +-
 drivers/net/nfb/nfb_tx.h                      |   2 +-
 drivers/net/octeon_ep/otx_ep_common.h         |   2 +
 drivers/net/octeon_ep/otx_ep_rxtx.c           |   2 +-
 drivers/net/octeontx/octeontx_logs.h          |   3 +-
 drivers/net/pfe/pfe_logs.h                    |   3 +-
 drivers/net/qede/qede_logs.h                  |   5 +-
 drivers/net/virtio/virtio_logs.h              |   5 +-
 drivers/net/vmxnet3/vmxnet3_ethdev.c          |   2 +-
 drivers/net/vmxnet3/vmxnet3_logs.h            |   7 +-
 drivers/raw/cnxk_bphy/cnxk_bphy.c             |   3 +-
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c         |   2 +-
 drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c    |  31 +-
 drivers/raw/cnxk_bphy/rte_pmd_bphy.h          |   6 +
 drivers/raw/cnxk_gpio/cnxk_gpio.c             |  21 +-
 drivers/raw/cnxk_gpio/cnxk_gpio.h             |   5 +
 drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c    |  17 +-
 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h    |   3 +-
 .../raw/ifpga/base/osdep_rte/osdep_generic.h  |   5 +-
 drivers/vdpa/ifc/base/ifcvf.c                 |  10 +-
 drivers/vdpa/ifc/base/ifcvf_osdep.h           |   7 +-
 examples/fips_validation/fips_dev_self_test.c |  44 +--
 lib/log/log.c                                 |   3 +
 lib/log/rte_log.h                             |   2 +-
 78 files changed, 420 insertions(+), 376 deletions(-)
  

Comments

David Marchand Dec. 22, 2023, 12:50 p.m. UTC | #1
On Thu, Dec 21, 2023 at 5:49 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The generic RTE_LOGTYPE_PMD is a leftover and should be removed.
> This replaces all uses in current tree. It leaves PMD logtype
> as deprecated because there maybe other uses in external projects
> leftover.
>
> This version does not use Depends-on: because CI system can't
> handle that and want to make sure no PMD left behind.
>
> v5 - incorporate review feedback
>
> David Marchand (1):
>   drivers: use dedicated logtypes
>
> Stephen Hemminger (17):
>   common/sfc_efx: remove use of PMD logtype
>   mempool/dpaa2: use driver logtype not PMD
>   net/dpaa: use dedicated logtype not PMD
>   net/dpaa2: used dedicated logtype not PMD
>   net/mvpp2: use dedicated logtype
>   net/vmxnet3: used dedicated logtype not PMD
>   raw/cnxk: replace PMD logtype with dynamic type
>   crypto/scheduler: replace use of logtype PMD
>   crypto/ccp: do not use PMD logtype
>   crypto/caam_jr: use dedicated logtype
>   crypto/dpaa_sec, crypto/dpaa2_sec: use dedicated logtype
>   event/dlb2: use dedicated logtype
>   event/dpaa, event/dpaa2: use dedicated logtype
>   event/skeleton: replace logtype PMD with dynamic type
>   net/nfb: use dynamic logtype
>   examples/fips_validation: replace use of PMD logtype
>   log: mark PMD logtype as deprecated

It seems our CI has some gaps.

I found some PMD use in two drivers:
drivers/crypto/armv8/rte_armv8_pmd.c:   RTE_LOG(INFO, PMD,
drivers/net/mvpp2/mrvl_ethdev.c:                        RTE_LOG(ERR, PMD,