Message ID | 20231127133903.1138657-1-huangdengdui@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40F0E433E5; Mon, 27 Nov 2023 14:39:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DB9840273; Mon, 27 Nov 2023 14:39:07 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 0216F406A2 for <dev@dpdk.org>; Mon, 27 Nov 2023 14:39:05 +0100 (CET) Received: from dggpeml500011.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Sf69V5BQ2zWhp8; Mon, 27 Nov 2023 21:38:22 +0800 (CST) Received: from localhost.huawei.com (10.50.165.33) by dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 27 Nov 2023 21:39:03 +0800 From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <haijie1@huawei.com>, <lihuisong@huawei.com>, <liuyonglong@huawei.com>, <fengchengwen@huawei.com> Subject: [PATCH 0/3] fix some bug for hns3 Date: Mon, 27 Nov 2023 21:39:00 +0800 Message-ID: <20231127133903.1138657-1-huangdengdui@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500011.china.huawei.com (7.185.36.84) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series | fix some bug for hns3 | |
Message
huangdengdui
Nov. 27, 2023, 1:39 p.m. UTC
Dengdui Huang (3): net/hns3: fix reset detect be ignored net/hns3: fix VF wrong clear reset status net/hns3: fix the VF reset interrupted possibly drivers/net/hns3/hns3_ethdev.c | 5 ++++- drivers/net/hns3/hns3_ethdev.h | 12 ++++++++++++ drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++++++-- drivers/net/hns3/hns3_intr.c | 4 ++-- 4 files changed, 35 insertions(+), 5 deletions(-)
Comments
On 2023/11/27 21:39, Dengdui Huang wrote: > Dengdui Huang (3): > net/hns3: fix reset detect be ignored > net/hns3: fix VF wrong clear reset status > net/hns3: fix the VF reset interrupted possibly Hi, Dengdui, Good fix. For the patchset, Acked-by: Jie Hai <haijie1@huawei.com> Thank, Jie Hai > > drivers/net/hns3/hns3_ethdev.c | 5 ++++- > drivers/net/hns3/hns3_ethdev.h | 12 ++++++++++++ > drivers/net/hns3/hns3_ethdev_vf.c | 19 +++++++++++++++++-- > drivers/net/hns3/hns3_intr.c | 4 ++-- > 4 files changed, 35 insertions(+), 5 deletions(-) >
On 11/27/2023 1:55 PM, Jie Hai wrote: > On 2023/11/27 21:39, Dengdui Huang wrote: >> Dengdui Huang (3): >> net/hns3: fix reset detect be ignored >> net/hns3: fix VF wrong clear reset status >> net/hns3: fix the VF reset interrupted possibly > Hi, Dengdui, > > Good fix. > For the patchset, > Acked-by: Jie Hai <haijie1@huawei.com> > Hi Jie, Dengdui, is this set for this release, which is a few days away? My suggestion is to wait next version as issues doesn't look critical. I applied set to next-net, but leaving decision to pull it for the release or not to Thomas/David. Applied to dpdk-next-net/main, thanks.
On 2023/11/28 2:33, Ferruh Yigit wrote: > On 11/27/2023 1:55 PM, Jie Hai wrote: >> On 2023/11/27 21:39, Dengdui Huang wrote: >>> Dengdui Huang (3): >>> net/hns3: fix reset detect be ignored >>> net/hns3: fix VF wrong clear reset status >>> net/hns3: fix the VF reset interrupted possibly >> Hi, Dengdui, >> >> Good fix. >> For the patchset, >> Acked-by: Jie Hai <haijie1@huawei.com> >> > > > Hi Jie, Dengdui, is this set for this release, which is a few days away? > My suggestion is to wait next version as issues doesn't look critical. > > > I applied set to next-net, but leaving decision to pull it for the > release or not to Thomas/David. > > Applied to dpdk-next-net/main, thanks. > Hi, Ferruh, Thomas and David, I'm sorry that this problem is a little serious. a) Without [PATCH 2/3], when the VF executes the hns3_clear_reset_event(), unexpected memory is written. As a result, unexpected errors occur in the program or even the app may crash. b) Without [PATCH 3/3], there is a low probability that the app is unavailable after the FLR reset is done. c) In addition, some LTS versions have the same problem. Therefore, we hope that the problem can be solved in the current version. Thanks, Jie Hai > .
28/11/2023 04:33, Jie Hai: > On 2023/11/28 2:33, Ferruh Yigit wrote: > > On 11/27/2023 1:55 PM, Jie Hai wrote: > >> On 2023/11/27 21:39, Dengdui Huang wrote: > >>> Dengdui Huang (3): > >>> net/hns3: fix reset detect be ignored > >>> net/hns3: fix VF wrong clear reset status > >>> net/hns3: fix the VF reset interrupted possibly > >> Hi, Dengdui, > >> > >> Good fix. > >> For the patchset, > >> Acked-by: Jie Hai <haijie1@huawei.com> > >> > > > > > > Hi Jie, Dengdui, is this set for this release, which is a few days away? > > My suggestion is to wait next version as issues doesn't look critical. > > > > > > I applied set to next-net, but leaving decision to pull it for the > > release or not to Thomas/David. > > > > Applied to dpdk-next-net/main, thanks. > > > Hi, Ferruh, Thomas and David, > > I'm sorry that this problem is a little serious. > > a) Without [PATCH 2/3], when the VF executes the > hns3_clear_reset_event(), unexpected memory is written. > As a result, unexpected errors occur in the program or even the app may > crash. > b) Without [PATCH 3/3], there is a low probability that the app is > unavailable after the FLR reset is done. > c) In addition, some LTS versions have the same problem. > > Therefore, we hope that the problem can be solved in the current version. OK applied, thanks.