Message ID | 20231013042722.429592-1-taozj888@163.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BA4742350; Fri, 13 Oct 2023 06:27:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A6EC4067C; Fri, 13 Oct 2023 06:27:41 +0200 (CEST) Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by mails.dpdk.org (Postfix) with ESMTP id 991D7402CB for <dev@dpdk.org>; Fri, 13 Oct 2023 06:27:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=xxTw9 MBlxsC9u3adnqgv53UVRWyaXgf2PQFKinTgBc4=; b=ax56nJtYY3hNBJHCZOK02 eH17lOtOXHEGQNCzWDtyil69b6d6OKqs+/o1QHt+1rJ2+QDl8r2ZUFpJBg33uhRI 3eX/byz9s7B1FbrDvhEo2xn+HN9q3vJnYfalCUzwRVogx3yPWLdUVJn44DlGhpsm TTX/26vHgxXQpUU2oSPfsE= Received: from u2204.. (unknown [49.76.95.19]) by zwqz-smtp-mta-g3-1 (Coremail) with SMTP id _____wDnd_AsxyhlkACrAQ--.46395S2; Fri, 13 Oct 2023 12:27:30 +0800 (CST) From: Trevor Tao <taozj888@163.com> To: dev@dpdk.org Cc: Trevor Tao <taozj888@163.com> Subject: [PATCH v2 0/3] example/l3fwd: relax l3fwd rx RSS/Offload if needed Date: Fri, 13 Oct 2023 04:27:19 +0000 Message-Id: <20231013042722.429592-1-taozj888@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: _____wDnd_AsxyhlkACrAQ--.46395S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruw4fGw13Aw17Xr4xWw4Uurg_yoWxurX_K3 Z5Wa93Aay7tFy7JFy3tr4fW39Ykr47J3WUJF4qgr4vvF1fWw43Kr1DJ3Za9w1Yv3W8KFW5 Ww1DXry0yr4SyjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7VUjCzuDUUUUU== X-Originating-IP: [49.76.95.19] X-CM-SenderInfo: hwdr6yqyyyqiywtou0bp/xtbBohMIx1aEJ0jE6AAAsv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
example/l3fwd: relax l3fwd rx RSS/Offload if needed
|
|
Message
Trevor Tao
Oct. 13, 2023, 4:27 a.m. UTC
This series tries to relax l3fwd rx RSS/Offload mode requirement if they are not supported by underlying hw or virtual devices, there is an option named relax_rx_mode added to enable this option. Trevor Tao (3): examples/l3fwd: relax RSS requirement with option examples/l3fwd: relax the Offload requirement doc: add a relax rx mode requirement option doc/guides/rel_notes/release_23_11.rst | 251 +++++++++++++++++++++--- doc/guides/sample_app_ug/l3_forward.rst | 4 +- examples/l3fwd/l3fwd.h | 12 +- examples/l3fwd/l3fwd_em.h | 2 +- examples/l3fwd/l3fwd_lpm.h | 2 +- examples/l3fwd/main.c | 30 +++ 6 files changed, 272 insertions(+), 29 deletions(-)
Comments
Hello, On Fri, Oct 13, 2023 at 6:28 AM Trevor Tao <taozj888@163.com> wrote: > > This series tries to relax l3fwd rx RSS/Offload mode requirement if they > are not supported by underlying hw or virtual devices, there is an > option named relax_rx_mode added to enable this option. > > Trevor Tao (3): > examples/l3fwd: relax RSS requirement with option > examples/l3fwd: relax the Offload requirement > doc: add a relax rx mode requirement option > > doc/guides/rel_notes/release_23_11.rst | 251 +++++++++++++++++++++--- > doc/guides/sample_app_ug/l3_forward.rst | 4 +- > examples/l3fwd/l3fwd.h | 12 +- > examples/l3fwd/l3fwd_em.h | 2 +- > examples/l3fwd/l3fwd_lpm.h | 2 +- > examples/l3fwd/main.c | 30 +++ > 6 files changed, 272 insertions(+), 29 deletions(-) Thanks for the patches. One comment on the form though. I see 4 batches of "v2 patches" in patchwork. https://patchwork.dpdk.org/project/dpdk/list/?submitter=3044&state=* I marked all but the last batch as superseded. If there is something wrong with this, please register to patchwork with your mail address, you will then be able to update the states yourself. It is hard to follow what work has been done between those different iterations of patches. For future submissions, don't forget to version your patches with a new revision (iirc, we should be at version 7 if I count the initial standalone v1 patch). In the cover letter, please provide a changelog of the differences between revisions. If you think it is better, you may put a more detailed changelog in each patch commitlog (as annotations, after ---). Thanks.
Hi David: Thanks for your notifications. I will check them in the future work. Trevor Tao At 2023-10-13 15:07:03, "David Marchand" <david.marchand@redhat.com> wrote: >Hello, > >On Fri, Oct 13, 2023 at 6:28 AM Trevor Tao <taozj888@163.com> wrote: >> >> This series tries to relax l3fwd rx RSS/Offload mode requirement if they >> are not supported by underlying hw or virtual devices, there is an >> option named relax_rx_mode added to enable this option. >> >> Trevor Tao (3): >> examples/l3fwd: relax RSS requirement with option >> examples/l3fwd: relax the Offload requirement >> doc: add a relax rx mode requirement option >> >> doc/guides/rel_notes/release_23_11.rst | 251 +++++++++++++++++++++--- >> doc/guides/sample_app_ug/l3_forward.rst | 4 +- >> examples/l3fwd/l3fwd.h | 12 +- >> examples/l3fwd/l3fwd_em.h | 2 +- >> examples/l3fwd/l3fwd_lpm.h | 2 +- >> examples/l3fwd/main.c | 30 +++ >> 6 files changed, 272 insertions(+), 29 deletions(-) > >Thanks for the patches. >One comment on the form though. > >I see 4 batches of "v2 patches" in patchwork. >https://patchwork.dpdk.org/project/dpdk/list/?submitter=3044&state=* >I marked all but the last batch as superseded. >If there is something wrong with this, please register to patchwork >with your mail address, you will then be able to update the states >yourself. > > >It is hard to follow what work has been done between those different >iterations of patches. >For future submissions, don't forget to version your patches with a >new revision (iirc, we should be at version 7 if I count the initial >standalone v1 patch). > >In the cover letter, please provide a changelog of the differences >between revisions. >If you think it is better, you may put a more detailed changelog in >each patch commitlog (as annotations, after ---). > > >Thanks. > >-- >David Marchand