Message ID | 20230913114351.1940459-1-thomas@monjalon.net (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DFD442588; Wed, 13 Sep 2023 13:45:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE64340633; Wed, 13 Sep 2023 13:45:01 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id C057940608 for <dev@dpdk.org>; Wed, 13 Sep 2023 13:45:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6EA5A320096C; Wed, 13 Sep 2023 07:44:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 13 Sep 2023 07:44:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1694605497; x=1694691897; bh=bpHu6NzKw3yp9FA+ayYpODYUMLWvrFQSXe+ uRfKUTs0=; b=jaok4RdPWG6C/FP05BSZbHnYH37hUYWRqf68whr4Lmf89CvkG+E 0fM1mXs9sBQtM1xjqsiFDZTHeuYNjPxzxg+3Cjx3fuUyTBM5k4+M9icEA1WcSS8o Fb3h/Nbp64oWG960MObql97SlGkiufIfweqBKN86NfUqyuM2Kp8ba7b42prS+FZ8 QpRFQerO71mTvWxvPYQlVHANxD2n5niXR1dxjj1B0ciz6sg0IrqNhQ7Arsc2f2pa 02qOeM19cFec9mHdO8yrTzO9fSFg3tEIiONL+pvsROncULA0H/FPnwwILpSaDWsi aEsbcUJf9uakxsWMv6vOBs48KmGUDxfk0Vw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1694605497; x=1694691897; bh=bpHu6NzKw3yp9FA+ayYpODYUMLWvrFQSXe+ uRfKUTs0=; b=a3Zmm4/SUHR3m+dGqTmCCyhyERYNbv7ffWlX3AGTHebE+6wlV3r bcTO4id/VcCxXARHfTRpgdp/VJb0FG9Z+hlYHeEUKlHBFia+vNSg2KFEJAUrj74r AcdH6TW5kDNmYJ0M3+tekhNniCfO8pVSo23TxNssGBQv08+kh2fPTY8n1BjDRgrC kYfKCc0OaK5kBpmIDl+cCHBwEgycVqLYLmFdZrfRdcphbqsvhtTlLfNMtCsOcRe2 FQI48dt0GGUE8pv31kOvMH9jJqEcX4StKFxfHLTNG6qijBLpzxHsfUUvIpCdzG2r cgEaqDCkLr0sjDLBuwi5q/ER5ZrFctojT4g== X-ME-Sender: <xms:uaABZaZIuDGaiGgEVAxjGN_OkCZRSYc17UOdAMjSQVcxmtqJZpGEww> <xme:uaABZdYuuvElavA9BGODn57y_0PvFJpjto-zSUYd0n5N8Ykj5bxE045Ex3V86-i8o E2PYcrYCn1EFn4pcA> X-ME-Received: <xmr:uaABZU-NAuvJVROecaBgqVwK2su7iG4opeHU4vLSnGkd4tJB0PGQphYMCRRleb99wK2ijA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeikedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdeiffffgeefteelhfekueetueduffejgfelvedtieejudek gfevheetheehgeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:uaABZcqQwmYTYyy1jcwvjo3tGe6KGHwCHx7Y5WW1Qcxg9W1oDH4q1A> <xmx:uaABZVrmaHGU7qL0Uhb347H0_mx6AdTx2aJWF67UQnvwGSlyoyjyZA> <xmx:uaABZaSMfXAknEtxxxlgvXAZozwj5JuxsAINn_4PANxAawz4jQv2Sw> <xmx:uaABZc2kZLP2dHSagB-LlUQ2M_Km9d0PSBB10vce9CnPY-6bX5QRQA> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Sep 2023 07:44:56 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, David Marchand <david.marchand@redhat.com>, Ferruh Yigit <ferruh.yigit@amd.com> Subject: [PATCH v3 00/11] rework thread management Date: Wed, 13 Sep 2023 13:28:13 +0200 Message-ID: <20230913114351.1940459-1-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230906162226.1618088-1-thomas@monjalon.net> References: <20230906162226.1618088-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
rework thread management
|
|
Message
Thomas Monjalon
Sept. 13, 2023, 11:28 a.m. UTC
The main effect of this patch series is to remove calls to pthread functions except for pthread_cancel and locks. The function rte_thread_create_control() does not take thread attributes settings anymore as it looks a useless complication of the API. Then the rte_thread API is made stable, so we can remove the old deprecated functions rte_thread_setname() and rte_ctrl_thread_create(). Some new internal functions are added in rte_thread to make sure all internal thread names are prefixed with "dpdk-". Few other cleanups are done. Future work about pthread portability are about: - cancel - mutex --- v2 changes: - replace (|_) with _? in checkpatch - simplify thread name size doc - build time check of internal thread name size - clean control thread params struct v3 change: - fix build (wrong placement of RTE_BUILD_BUG_ON) note for later: never send a patch during a summit! Thomas Monjalon (11): devtools: warn when adding some pthread calls eal: rename thread name length definition eal: remove attributes from control thread creation eal: promote thread API as stable eal: force prefix for internal threads lib: convert to internal control threads drivers: convert to internal control threads examples: convert to normal control threads test: convert threads creation eal: remove deprecated thread functions lib: remove pthread.h from includes app/test/process.h | 10 +- app/test/test_lcores.c | 9 +- app/test/test_link_bonding.c | 2 + app/test/test_pdump.c | 6 +- app/test/test_pdump.h | 2 +- app/test/test_threads.c | 2 +- devtools/checkpatches.sh | 16 +++ .../prog_guide/env_abstraction_layer.rst | 2 +- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_23_11.rst | 6 + drivers/common/cnxk/roc_dev.c | 16 +-- drivers/common/cnxk/roc_dev_priv.h | 2 +- drivers/common/cnxk/roc_nix_inl_dev.c | 9 +- drivers/common/cnxk/roc_nix_inl_priv.h | 2 +- drivers/common/cnxk/roc_platform.h | 3 +- drivers/common/mlx5/mlx5_common.c | 1 + drivers/common/mlx5/windows/mlx5_win_ext.h | 2 + drivers/dma/skeleton/skeleton_dmadev.c | 8 +- drivers/event/dlb2/pf/base/dlb2_osdep.h | 14 +- drivers/event/dlb2/pf/base/dlb2_resource.c | 39 +++--- drivers/event/dlb2/pf/dlb2_main.h | 1 - drivers/net/ark/ark_ethdev.c | 11 +- drivers/net/ark/ark_pktgen.c | 8 +- drivers/net/ark/ark_pktgen.h | 2 +- drivers/net/bnxt/bnxt.h | 1 + drivers/net/iavf/iavf_vchnl.c | 4 +- drivers/net/ice/ice_dcf_parent.c | 7 +- drivers/net/ipn3ke/ipn3ke_representor.c | 17 ++- drivers/net/ixgbe/ixgbe_ethdev.c | 8 +- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_hws_cnt.c | 42 +++--- drivers/net/qede/base/bcm_osal.h | 1 + drivers/net/sfc/sfc_mae.h | 2 +- drivers/net/sfc/sfc_mae_counter.c | 11 +- drivers/net/txgbe/txgbe_ethdev.c | 6 +- drivers/raw/ifpga/base/opae_osdep.h | 1 + drivers/raw/ifpga/ifpga_rawdev.c | 19 ++- drivers/vdpa/ifc/ifcvf_vdpa.c | 86 ++++++------ drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 10 +- drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 70 +++------- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 64 +++------ drivers/vdpa/sfc/sfc_vdpa.c | 1 + drivers/vdpa/sfc/sfc_vdpa_ops.c | 15 +- drivers/vdpa/sfc/sfc_vdpa_ops.h | 3 +- examples/vhost/main.c | 9 +- examples/vhost_blk/vhost_blk.c | 21 +-- lib/eal/common/eal_common_options.c | 1 + lib/eal/common/eal_common_proc.c | 15 +- lib/eal/common/eal_common_thread.c | 131 +++++++----------- lib/eal/common/eal_common_trace.c | 1 + lib/eal/common/malloc_mp.c | 1 + lib/eal/freebsd/eal.c | 2 +- lib/eal/freebsd/eal_alarm.c | 1 + lib/eal/freebsd/eal_interrupts.c | 10 +- lib/eal/freebsd/eal_thread.c | 9 +- lib/eal/include/rte_eal.h | 3 - lib/eal/include/rte_lcore.h | 42 ------ lib/eal/include/rte_per_lcore.h | 2 - lib/eal/include/rte_thread.h | 131 +++++++++--------- lib/eal/linux/eal.c | 2 +- lib/eal/linux/eal_alarm.c | 1 + lib/eal/linux/eal_interrupts.c | 10 +- lib/eal/linux/eal_thread.c | 18 +-- lib/eal/linux/eal_timer.c | 11 +- lib/eal/unix/rte_thread.c | 2 +- lib/eal/version.map | 44 +++--- lib/eal/windows/eal.c | 2 +- lib/eal/windows/eal_interrupts.c | 2 +- lib/eal/windows/eal_thread.c | 8 -- lib/eal/windows/rte_thread.c | 2 +- lib/ethdev/ethdev_driver.c | 1 + lib/ethdev/ethdev_driver.h | 2 + lib/ethdev/rte_ethdev_core.h | 2 - lib/ethdev/rte_flow.c | 1 + lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++-- lib/vhost/fd_man.c | 6 +- lib/vhost/fd_man.h | 2 +- lib/vhost/socket.c | 23 ++- lib/vhost/vduse.c | 5 +- lib/vhost/vhost.c | 1 + 81 files changed, 466 insertions(+), 632 deletions(-)
Comments
13/09/2023 12:28, Thomas Monjalon пишет: > The main effect of this patch series is to > remove calls to pthread functions except for pthread_cancel and locks. > > The function rte_thread_create_control() does not take thread attributes > settings anymore as it looks a useless complication of the API. > Then the rte_thread API is made stable, > so we can remove the old deprecated functions > rte_thread_setname() and rte_ctrl_thread_create(). > > Some new internal functions are added in rte_thread to make sure > all internal thread names are prefixed with "dpdk-". > > Few other cleanups are done. > > Future work about pthread portability are about: > - cancel > - mutex > > --- > > v2 changes: > - replace (|_) with _? in checkpatch > - simplify thread name size doc > - build time check of internal thread name size > - clean control thread params struct > v3 change: > - fix build (wrong placement of RTE_BUILD_BUG_ON) > note for later: never send a patch during a summit! > > > Thomas Monjalon (11): > devtools: warn when adding some pthread calls > eal: rename thread name length definition > eal: remove attributes from control thread creation > eal: promote thread API as stable > eal: force prefix for internal threads > lib: convert to internal control threads > drivers: convert to internal control threads > examples: convert to normal control threads > test: convert threads creation > eal: remove deprecated thread functions > lib: remove pthread.h from includes > > app/test/process.h | 10 +- > app/test/test_lcores.c | 9 +- > app/test/test_link_bonding.c | 2 + > app/test/test_pdump.c | 6 +- > app/test/test_pdump.h | 2 +- > app/test/test_threads.c | 2 +- > devtools/checkpatches.sh | 16 +++ > .../prog_guide/env_abstraction_layer.rst | 2 +- > doc/guides/rel_notes/deprecation.rst | 5 - > doc/guides/rel_notes/release_23_11.rst | 6 + > drivers/common/cnxk/roc_dev.c | 16 +-- > drivers/common/cnxk/roc_dev_priv.h | 2 +- > drivers/common/cnxk/roc_nix_inl_dev.c | 9 +- > drivers/common/cnxk/roc_nix_inl_priv.h | 2 +- > drivers/common/cnxk/roc_platform.h | 3 +- > drivers/common/mlx5/mlx5_common.c | 1 + > drivers/common/mlx5/windows/mlx5_win_ext.h | 2 + > drivers/dma/skeleton/skeleton_dmadev.c | 8 +- > drivers/event/dlb2/pf/base/dlb2_osdep.h | 14 +- > drivers/event/dlb2/pf/base/dlb2_resource.c | 39 +++--- > drivers/event/dlb2/pf/dlb2_main.h | 1 - > drivers/net/ark/ark_ethdev.c | 11 +- > drivers/net/ark/ark_pktgen.c | 8 +- > drivers/net/ark/ark_pktgen.h | 2 +- > drivers/net/bnxt/bnxt.h | 1 + > drivers/net/iavf/iavf_vchnl.c | 4 +- > drivers/net/ice/ice_dcf_parent.c | 7 +- > drivers/net/ipn3ke/ipn3ke_representor.c | 17 ++- > drivers/net/ixgbe/ixgbe_ethdev.c | 8 +- > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mlx5/mlx5_hws_cnt.c | 42 +++--- > drivers/net/qede/base/bcm_osal.h | 1 + > drivers/net/sfc/sfc_mae.h | 2 +- > drivers/net/sfc/sfc_mae_counter.c | 11 +- > drivers/net/txgbe/txgbe_ethdev.c | 6 +- > drivers/raw/ifpga/base/opae_osdep.h | 1 + > drivers/raw/ifpga/ifpga_rawdev.c | 19 ++- > drivers/vdpa/ifc/ifcvf_vdpa.c | 86 ++++++------ > drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +- > drivers/vdpa/mlx5/mlx5_vdpa.h | 10 +- > drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 70 +++------- > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 64 +++------ > drivers/vdpa/sfc/sfc_vdpa.c | 1 + > drivers/vdpa/sfc/sfc_vdpa_ops.c | 15 +- > drivers/vdpa/sfc/sfc_vdpa_ops.h | 3 +- > examples/vhost/main.c | 9 +- > examples/vhost_blk/vhost_blk.c | 21 +-- > lib/eal/common/eal_common_options.c | 1 + > lib/eal/common/eal_common_proc.c | 15 +- > lib/eal/common/eal_common_thread.c | 131 +++++++----------- > lib/eal/common/eal_common_trace.c | 1 + > lib/eal/common/malloc_mp.c | 1 + > lib/eal/freebsd/eal.c | 2 +- > lib/eal/freebsd/eal_alarm.c | 1 + > lib/eal/freebsd/eal_interrupts.c | 10 +- > lib/eal/freebsd/eal_thread.c | 9 +- > lib/eal/include/rte_eal.h | 3 - > lib/eal/include/rte_lcore.h | 42 ------ > lib/eal/include/rte_per_lcore.h | 2 - > lib/eal/include/rte_thread.h | 131 +++++++++--------- > lib/eal/linux/eal.c | 2 +- > lib/eal/linux/eal_alarm.c | 1 + > lib/eal/linux/eal_interrupts.c | 10 +- > lib/eal/linux/eal_thread.c | 18 +-- > lib/eal/linux/eal_timer.c | 11 +- > lib/eal/unix/rte_thread.c | 2 +- > lib/eal/version.map | 44 +++--- > lib/eal/windows/eal.c | 2 +- > lib/eal/windows/eal_interrupts.c | 2 +- > lib/eal/windows/eal_thread.c | 8 -- > lib/eal/windows/rte_thread.c | 2 +- > lib/ethdev/ethdev_driver.c | 1 + > lib/ethdev/ethdev_driver.h | 2 + > lib/ethdev/rte_ethdev_core.h | 2 - > lib/ethdev/rte_flow.c | 1 + > lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++-- > lib/vhost/fd_man.c | 6 +- > lib/vhost/fd_man.h | 2 +- > lib/vhost/socket.c | 23 ++- > lib/vhost/vduse.c | 5 +- > lib/vhost/vhost.c | 1 + > 81 files changed, 466 insertions(+), 632 deletions(-) > Series-acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
On Wed, Sep 13, 2023 at 1:45 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > The main effect of this patch series is to > remove calls to pthread functions except for pthread_cancel and locks. > > The function rte_thread_create_control() does not take thread attributes > settings anymore as it looks a useless complication of the API. > Then the rte_thread API is made stable, > so we can remove the old deprecated functions > rte_thread_setname() and rte_ctrl_thread_create(). > > Some new internal functions are added in rte_thread to make sure > all internal thread names are prefixed with "dpdk-". > > Few other cleanups are done. > > Future work about pthread portability are about: > - cancel > - mutex > > --- > > v2 changes: > - replace (|_) with _? in checkpatch > - simplify thread name size doc > - build time check of internal thread name size > - clean control thread params struct > v3 change: > - fix build (wrong placement of RTE_BUILD_BUG_ON) > note for later: never send a patch during a summit! Series applied, thanks.