Message ID | 20230906162226.1618088-1-thomas@monjalon.net (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75A6242529; Wed, 6 Sep 2023 18:22:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E0684027E; Wed, 6 Sep 2023 18:22:44 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id DDA164027C for <dev@dpdk.org>; Wed, 6 Sep 2023 18:22:41 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D9B4B32008C3; Wed, 6 Sep 2023 12:22:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 06 Sep 2023 12:22:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; t=1694017357; x=1694103757; bh=VvF+lm4sYV 0iiKakdrG4NMTbWVK5f6jA5HDGOMXYhKs=; b=ROIKHWpZXu+ao6iGAujEYmqY36 v+Yu3ubbUdvKm2CUR4f+B/34SSnp5amvzYK04Ivt0rb6poGVd8cUerNXGni1N0IJ BSCtxWFH9yqxdGR3/bhvadZtmFs4BfPI0XLm3ZdQn/JwlU+MyOH2B1LdtItHWZCA ZTf55VQG/NXbCoa/ELqemB/r+eYfzl70Fj2OVXEcxbWUVZmUQN2xSA/2eTvaPhzY JEkwC1xApJBtaPYSlGfLTUFK/TZ+Typ5EAF905JiaSs3xJ8F73lkWCCgqxbyKySt yS0xD/xFC2wPGqMCEJ35WiGg0ZBJjM1QCMgsRF9X/IfwwFR6bcqUGHeXxriw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1694017357; x=1694103757; bh=VvF+lm4sYV0ii KakdrG4NMTbWVK5f6jA5HDGOMXYhKs=; b=wA/WyPrOiAxDVhDj/wU2VFWu90eMt T21wyRaeGgyv/hjPF6S7lQ4pGyj7LfrHOFBmay+BOkQ9Z2K98PfXCX3UvMQUDYIY EwvOv/xy2buZ+mlV4E+YA9rKc7/w9xvxyPVnAufg/yRycCbFqml7WZ0YCxS38wI8 t7OSCpe/q7joicRHTjr8mh++khCH3x2yIclrfbJctjV5JddUaECBsvt2VfVbifQ8 6AqXzEp8DN9ZegAOybditp+qKTMaCgFP038k73LEyOiOwA+uVSK/Mrv6G2A1Uvwx CPzLO9pQaj+tszljhqcQT029955ciQVWlTwv4CZxdO436UpcutKueu2cw== X-ME-Sender: <xms:TKf4ZPJOouivA4XGoKp25n4yixCdaKYOxdpLm1JDGkF1h7qhvQzfiA> <xme:TKf4ZDIlF8ulRpOkqPeEEApTDcTMS6G1zz1S_efL_w0uD2Uejpt453X3TcYselw_W LNb14t65INQ2xLysA> X-ME-Received: <xmr:TKf4ZHsavuEAxNVzHG3voZedjRsgIIw4SyCyXcb6K-8LogFvy2b7wIhMsOHlk6pxHGA-681Z6O0R5MQ9FQc_ZaZtk7MOZ2s> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehfedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeevveefveeiiefhtedukeegkeelieegffeukeevudetueffieduveet iedukeefleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:Taf4ZIY0A0IAByb-daymbo35teYBwuhf4IuhSZ4Yzqau3ToAy14fhg> <xmx:Taf4ZGaFWdjHHtODBpmiY8Dg1bucsWIgkIRod3NiVv5CjkAJARVtBA> <xmx:Taf4ZMAM5nr-Htc4BSv5Qu0Q0wXNK61mJHEqFDaT1gBtm7O05LE10w> <xmx:Taf4ZFmZ7dtAnjOGSTP6ZyJy3SyFWFbr40sqtrGvh-rea6FvwiiQtg> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Sep 2023 12:22:35 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>, David Marchand <david.marchand@redhat.com>, Ferruh Yigit <ferruh.yigit@amd.com> Subject: [PATCH 00/11] rework thread management Date: Wed, 6 Sep 2023 18:12:17 +0200 Message-ID: <20230906162226.1618088-1-thomas@monjalon.net> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
rework thread management
|
|
Message
Thomas Monjalon
Sept. 6, 2023, 4:12 p.m. UTC
The main effect of this patch series is to remove calls to pthread functions except for pthread_cancel and locks. The function rte_thread_create_control() does not take attributes anymore as it looks a useless complication of the API. Then the rte_thread API is made stable, so we can remove the old deprecated functions rte_thread_setname() and rte_ctrl_thread_create(). Some new internal functions are added in rte_thread to make sure all internal thread names are prefixed with "dpdk-". Few other cleanups are done. Future work about pthread portability are about: - cancel - mutex Thomas Monjalon (11): devtools: warn when adding some pthread calls eal: rename thread name length definition eal: remove attributes from control thread creation eal: promote thread API as stable eal: force prefix for internal threads lib: convert to internal control threads drivers: convert to internal control threads examples: convert to normal control threads test: convert threads creation eal: remove deprecated thread functions lib: remove pthread.h from includes app/test/process.h | 10 +- app/test/test_lcores.c | 9 +- app/test/test_link_bonding.c | 2 + app/test/test_pdump.c | 6 +- app/test/test_pdump.h | 2 +- app/test/test_threads.c | 2 +- devtools/checkpatches.sh | 16 +++ .../prog_guide/env_abstraction_layer.rst | 2 +- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_23_11.rst | 6 + drivers/common/cnxk/roc_dev.c | 16 +-- drivers/common/cnxk/roc_dev_priv.h | 2 +- drivers/common/cnxk/roc_nix_inl_dev.c | 9 +- drivers/common/cnxk/roc_nix_inl_priv.h | 2 +- drivers/common/cnxk/roc_platform.h | 3 +- drivers/common/mlx5/mlx5_common.c | 1 + drivers/common/mlx5/windows/mlx5_win_ext.h | 2 + drivers/dma/skeleton/skeleton_dmadev.c | 8 +- drivers/event/dlb2/pf/base/dlb2_osdep.h | 14 +- drivers/event/dlb2/pf/base/dlb2_resource.c | 39 +++--- drivers/event/dlb2/pf/dlb2_main.h | 1 - drivers/net/ark/ark_ethdev.c | 11 +- drivers/net/ark/ark_pktgen.c | 8 +- drivers/net/ark/ark_pktgen.h | 2 +- drivers/net/bnxt/bnxt.h | 1 + drivers/net/iavf/iavf_vchnl.c | 4 +- drivers/net/ice/ice_dcf_parent.c | 7 +- drivers/net/ipn3ke/ipn3ke_representor.c | 17 ++- drivers/net/ixgbe/ixgbe_ethdev.c | 8 +- drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_hws_cnt.c | 42 +++--- drivers/net/qede/base/bcm_osal.h | 1 + drivers/net/sfc/sfc_mae.h | 2 +- drivers/net/sfc/sfc_mae_counter.c | 11 +- drivers/net/txgbe/txgbe_ethdev.c | 6 +- drivers/raw/ifpga/base/opae_osdep.h | 1 + drivers/raw/ifpga/ifpga_rawdev.c | 19 ++- drivers/vdpa/ifc/ifcvf_vdpa.c | 86 ++++++------ drivers/vdpa/mlx5/mlx5_vdpa.c | 2 +- drivers/vdpa/mlx5/mlx5_vdpa.h | 10 +- drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 70 +++------- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 64 +++------ drivers/vdpa/sfc/sfc_vdpa.c | 1 + drivers/vdpa/sfc/sfc_vdpa_ops.c | 15 +- drivers/vdpa/sfc/sfc_vdpa_ops.h | 3 +- examples/vhost/main.c | 9 +- examples/vhost_blk/vhost_blk.c | 21 +-- lib/eal/common/eal_common_options.c | 1 + lib/eal/common/eal_common_proc.c | 15 +- lib/eal/common/eal_common_thread.c | 101 +++++--------- lib/eal/common/eal_common_trace.c | 1 + lib/eal/common/malloc_mp.c | 1 + lib/eal/freebsd/eal.c | 2 +- lib/eal/freebsd/eal_alarm.c | 1 + lib/eal/freebsd/eal_interrupts.c | 10 +- lib/eal/freebsd/eal_thread.c | 9 +- lib/eal/include/rte_eal.h | 3 - lib/eal/include/rte_lcore.h | 42 ------ lib/eal/include/rte_per_lcore.h | 2 - lib/eal/include/rte_thread.h | 131 +++++++++--------- lib/eal/linux/eal.c | 2 +- lib/eal/linux/eal_alarm.c | 1 + lib/eal/linux/eal_interrupts.c | 10 +- lib/eal/linux/eal_thread.c | 18 +-- lib/eal/linux/eal_timer.c | 11 +- lib/eal/unix/rte_thread.c | 2 +- lib/eal/version.map | 44 +++--- lib/eal/windows/eal.c | 2 +- lib/eal/windows/eal_interrupts.c | 2 +- lib/eal/windows/eal_thread.c | 8 -- lib/eal/windows/rte_thread.c | 2 +- lib/ethdev/ethdev_driver.c | 1 + lib/ethdev/ethdev_driver.h | 2 + lib/ethdev/rte_ethdev_core.h | 2 - lib/ethdev/rte_flow.c | 1 + lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++-- lib/vhost/fd_man.c | 6 +- lib/vhost/fd_man.h | 2 +- lib/vhost/socket.c | 23 ++- lib/vhost/vduse.c | 5 +- lib/vhost/vhost.c | 1 + 81 files changed, 451 insertions(+), 617 deletions(-)
Comments
> From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, 6 September 2023 18.12 > > The main effect of this patch series is to > remove calls to pthread functions except for pthread_cancel and locks. > > The function rte_thread_create_control() does not take attributes anymore > as it looks a useless complication of the API. Note for other reviewers: The "args" parameter, passed to the thread function, is still there. > Then the rte_thread API is made stable, > so we can remove the old deprecated functions > rte_thread_setname() and rte_ctrl_thread_create(). > > Some new internal functions are added in rte_thread to make sure > all internal thread names are prefixed with "dpdk-". > > Few other cleanups are done. > > Future work about pthread portability are about: > - cancel > - mutex > > > Thomas Monjalon (11): > devtools: warn when adding some pthread calls > eal: rename thread name length definition > eal: remove attributes from control thread creation > eal: promote thread API as stable > eal: force prefix for internal threads > lib: convert to internal control threads > drivers: convert to internal control threads > examples: convert to normal control threads > test: convert threads creation > eal: remove deprecated thread functions > lib: remove pthread.h from includes Thank you for cleaning all this up, Thomas. Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
On Thu, Sep 07, 2023 at 10:30:59AM +0200, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, 6 September 2023 18.12 > > > > The main effect of this patch series is to > > remove calls to pthread functions except for pthread_cancel and locks. > > > > The function rte_thread_create_control() does not take attributes anymore > > as it looks a useless complication of the API. > > Note for other reviewers: The "args" parameter, passed to the thread function, is still there. > > > Then the rte_thread API is made stable, > > so we can remove the old deprecated functions > > rte_thread_setname() and rte_ctrl_thread_create(). > > > > Some new internal functions are added in rte_thread to make sure > > all internal thread names are prefixed with "dpdk-". > > > > Few other cleanups are done. > > > > Future work about pthread portability are about: > > - cancel > > - mutex > > > > > > Thomas Monjalon (11): > > devtools: warn when adding some pthread calls > > eal: rename thread name length definition > > eal: remove attributes from control thread creation > > eal: promote thread API as stable > > eal: force prefix for internal threads > > lib: convert to internal control threads > > drivers: convert to internal control threads > > examples: convert to normal control threads > > test: convert threads creation > > eal: remove deprecated thread functions > > lib: remove pthread.h from includes > > Thank you for cleaning all this up, Thomas. > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com> +1 thank you very much, this has been on my todo list it's really appreciated! Series-acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>