From patchwork Thu Aug 17 04:28:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 67 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0A794308A; Thu, 17 Aug 2023 06:28:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B27D940ED9; Thu, 17 Aug 2023 06:28:25 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mails.dpdk.org (Postfix) with ESMTP id D44A140685 for ; Thu, 17 Aug 2023 06:28:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4670D6223B for ; Thu, 17 Aug 2023 04:28:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6320CC433C7; Thu, 17 Aug 2023 04:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692246503; bh=A8XWWn/d3+DCe8TRhnbxyF516+FtuU8bJcB/m2Rt0qE=; h=From:To:Cc:Subject:Date:From; b=iW/Q20aSUHGudg6Ix6Di9y3BxJHqycA7mkNDZ1Lr7I98HV5ALBuWo4D58nbM582iK zvn0tn3pTV+lCdUB3F6DWZspA3WWQEXUUek3AVvnysqqpywdulT91JpAcMtjXdJFAs lrRrzT6Qh7lozLiR4m3HFZvS3NL9hddpUKD+NCw7TGMkKPF6a6AAPwl5QY0GH60Uba FXggzEiDHFKI5K6XHbu65u924d+g+sEd+gsI97JPpYmVFEmcO2mwla+VWGxarZMpRV dFCr19wShRobnw3+VxFjjTFZdx8BHVIUq9s7izfqzMpGik/s+5At0nfQQLdgPC5rVT VlPdTptI+8knQ== From: okaya@kernel.org To: Cc: dev@dpdk.org, Sinan Kaya Subject: [PATCH v5 00/10] support reinit flow Date: Thu, 17 Aug 2023 00:28:11 -0400 Message-Id: <20230817042820.137957-1-okaya@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sinan Kaya We want to be able to call rte_eal_init() and rte_eal_cleanup() APIs back to back for maintanance reasons. Here is a summary of the code we have seen so far: 1. some code support getting called multiple times by keeping a static variable. 2. some code initializes once but never clean up after them and don't have a cleanup API. 3. some code assumes that they only get called once during the lifecycle of the process. Most changes in this patch center around following the #1 design principle. Why? It is not always ideal to reinitialize a DPDK process. Memory needs to be reinitialized, hugetables need to warm up etc. Limitations: This sequence could only be done by main lcore, and never ever in a signal handler. Do not try and trap signals like abort, bus error, illegal instruction and try to use this for recovery. It is a recipe for failure. Changed from v1: Fix checkpatch warnings v2: rebase to most recent DPDK. v3: pick up Stephen's "eal: cleanup plugins data" as a pre-requisite patch. v4: fix windows build rename variables to run_once where possible move run_once inside the functions where possible Graham Whyte (1): eal: fixes for re-initialization issues Sinan Kaya (8): tailq: skip init if already initialized eal_memzone: bail out on initialized memseg: init once eal_memory: skip initialization eal_interrupts: don't reinitialize threads eal: initialize worker threads once eal: declare the reinit via cleanup/init feature unsupported test: remove double registration check Stephen Hemminger (1): eal: cleanup plugins data app/test/test_tailq.c | 5 --- lib/eal/common/eal_common_memory.c | 6 +++ lib/eal/common/eal_common_memzone.c | 6 +++ lib/eal/common/eal_common_options.c | 21 +++++++++ lib/eal/common/eal_common_tailqs.c | 20 ++++++--- lib/eal/common/eal_options.h | 1 + lib/eal/common/malloc_heap.c | 7 +++ lib/eal/include/rte_eal.h | 5 +++ lib/eal/linux/eal.c | 66 ++++++++++++++++------------- lib/eal/linux/eal_interrupts.c | 6 +++ lib/eal/linux/eal_memory.c | 12 +++++- 11 files changed, 113 insertions(+), 42 deletions(-)