mbox series

[v2,00/13] support telemetry query ethdev info

Message ID 20230607074209.4798-1-haijie1@huawei.com (mailing list archive)
Headers
Series support telemetry query ethdev info |

Message

Jie Hai June 7, 2023, 7:41 a.m. UTC 
  This patchset supports querying information about ethdev.
The information includes MAC addresses, RxTx offload, flow ctrl,
Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.

v1->v2:
1. Fix incorrect argument of calloc.
2. Extract telemetry codes to a file.
3. Extract codes parsing port id as a function.
4. Use malloc instead of rte_malloc.
5. Fix codecheck warnings and build errors reported by CI.
6. Use 'int' instead of 'unsigned' in help info.

Dengdui Huang (1):
  ethdev: support telemetry query MAC addresses

Jie Hai (12):
  ethdev: fix incorrect argument of calloc
  ethdev: extract telemetry codes to a file
  ethdev: extract codes parsing port ID as a function
  ethdev: support RxTx offload display
  ethdev: support telemetry query flow ctrl info
  ethdev: support telemetry query Rx queue info
  ethdev: support telemetry query Tx queue info
  ethdev: add firmware version in telemetry info command
  ethdev: support telemetry query DCB info
  ethdev: support telemetry query RSS info
  ethdev: support telemetry query FEC info
  ethdev: support telemetry query VLAN info

 lib/ethdev/meson.build            |    1 +
 lib/ethdev/rte_ethdev.c           |  332 ---------
 lib/ethdev/rte_ethdev_telemetry.c | 1063 +++++++++++++++++++++++++++++
 lib/ethdev/sff_telemetry.c        |    4 +-
 4 files changed, 1066 insertions(+), 334 deletions(-)
 create mode 100644 lib/ethdev/rte_ethdev_telemetry.c

Comments

Ferruh Yigit June 7, 2023, 11:40 a.m. UTC | #1 
On 6/7/2023 8:41 AM, Jie Hai wrote:
> This patchset supports querying information about ethdev.
> The information includes MAC addresses, RxTx offload, flow ctrl,
> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
> 
> v1->v2:
> 1. Fix incorrect argument of calloc.
> 2. Extract telemetry codes to a file.
> 3. Extract codes parsing port id as a function.
> 4. Use malloc instead of rte_malloc.
> 5. Fix codecheck warnings and build errors reported by CI.
> 6. Use 'int' instead of 'unsigned' in help info.
> 
> Dengdui Huang (1):
>   ethdev: support telemetry query MAC addresses
> 
> Jie Hai (12):
>   ethdev: fix incorrect argument of calloc
>   ethdev: extract telemetry codes to a file
>   ethdev: extract codes parsing port ID as a function
>   ethdev: support RxTx offload display
>   ethdev: support telemetry query flow ctrl info
>   ethdev: support telemetry query Rx queue info
>   ethdev: support telemetry query Tx queue info
>   ethdev: add firmware version in telemetry info command
>   ethdev: support telemetry query DCB info
>   ethdev: support telemetry query RSS info
>   ethdev: support telemetry query FEC info
>   ethdev: support telemetry query VLAN info
>

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>


There are minor comments, applied them while merging set.

Series applied to dpdk-next-net/main, thanks.
Jie Hai June 8, 2023, 2:01 a.m. UTC | #2 
On 2023/6/7 19:40, Ferruh Yigit wrote:
> On 6/7/2023 8:41 AM, Jie Hai wrote:
>> This patchset supports querying information about ethdev.
>> The information includes MAC addresses, RxTx offload, flow ctrl,
>> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
>>
>> v1->v2:
>> 1. Fix incorrect argument of calloc.
>> 2. Extract telemetry codes to a file.
>> 3. Extract codes parsing port id as a function.
>> 4. Use malloc instead of rte_malloc.
>> 5. Fix codecheck warnings and build errors reported by CI.
>> 6. Use 'int' instead of 'unsigned' in help info.
>>
>> Dengdui Huang (1):
>>    ethdev: support telemetry query MAC addresses
>>
>> Jie Hai (12):
>>    ethdev: fix incorrect argument of calloc
>>    ethdev: extract telemetry codes to a file
>>    ethdev: extract codes parsing port ID as a function
>>    ethdev: support RxTx offload display
>>    ethdev: support telemetry query flow ctrl info
>>    ethdev: support telemetry query Rx queue info
>>    ethdev: support telemetry query Tx queue info
>>    ethdev: add firmware version in telemetry info command
>>    ethdev: support telemetry query DCB info
>>    ethdev: support telemetry query RSS info
>>    ethdev: support telemetry query FEC info
>>    ethdev: support telemetry query VLAN info
>>
> 
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 
> 
> There are minor comments, applied them while merging set.
> 
> Series applied to dpdk-next-net/main, thanks.
> .
Hi Ferruh

Thank you for your valuable comments on the entire patch group.

Thanks,
Jie Hai