mbox series

[0/4] Small corrections in mempool

Message ID 20230309045738.1261000-1-honnappa.nagarahalli@arm.com (mailing list archive)
Headers
Series Small corrections in mempool |

Message

Honnappa Nagarahalli March 9, 2023, 4:57 a.m. UTC 
1) Patches 1/4, 2/4 - Few small corrections in mempool API documentation.
2) Patch 3/4 - The API for checking 'lcore ID is valid' is trivial,
   but it is the right thing to do.
3) Patch 4/4 - IMO, the 'lcore ID is valid' check is not necessary to be
   done during run time. If it is not valid, there is something seriously
   wrong in the system already or it is a programming error. Given that
   it is a data plane function, it makes sense to remove it from run
   time check.

Honnappa Nagarahalli (4):
  mempool: clarify mempool cache flush API behavior
  mempool: clarify comments for mempool cache implementation
  eal: add API to check if lcore id is valid
  mempool: use lcore API to check if lcore ID is valid

 lib/eal/include/rte_lcore.h | 14 ++++++++++++++
 lib/mempool/rte_mempool.c   | 12 ++++++------
 lib/mempool/rte_mempool.h   | 13 ++++++++-----
 3 files changed, 28 insertions(+), 11 deletions(-)

Comments

Thomas Monjalon June 7, 2023, 9:35 a.m. UTC | #1 
Any update about this series?

09/03/2023 05:57, Honnappa Nagarahalli:
> 1) Patches 1/4, 2/4 - Few small corrections in mempool API documentation.
> 2) Patch 3/4 - The API for checking 'lcore ID is valid' is trivial,
>    but it is the right thing to do.
> 3) Patch 4/4 - IMO, the 'lcore ID is valid' check is not necessary to be
>    done during run time. If it is not valid, there is something seriously
>    wrong in the system already or it is a programming error. Given that
>    it is a data plane function, it makes sense to remove it from run
>    time check.
> 
> Honnappa Nagarahalli (4):
>   mempool: clarify mempool cache flush API behavior
>   mempool: clarify comments for mempool cache implementation
>   eal: add API to check if lcore id is valid
>   mempool: use lcore API to check if lcore ID is valid
> 
>  lib/eal/include/rte_lcore.h | 14 ++++++++++++++
>  lib/mempool/rte_mempool.c   | 12 ++++++------
>  lib/mempool/rte_mempool.h   | 13 ++++++++-----
>  3 files changed, 28 insertions(+), 11 deletions(-)