Message ID | 20230203094340.8103-1-beilei.xing@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09EB841BBB; Fri, 3 Feb 2023 11:10:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87CFE410D7; Fri, 3 Feb 2023 11:10:09 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 57A444021E for <dev@dpdk.org>; Fri, 3 Feb 2023 11:10:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675419007; x=1706955007; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9adQSMlx80+ZijpDrLIetOUuBRrZKwgUAP/e0utdsvY=; b=kTJq9hqLgd2A9oyEAkqEhrqes7KOq3lqnRp6PtsLjX52ikz1Uc3rFjG6 6eYJgQoPwrnOXP1MGCW/Sy/FHxbU8SXdPZF3p2swj+Dz91xlmEkCOhfWt FG4udVqS8V3icdhiNFSGGQPRogFlooYFRpxcyO7oOQFGWzhRZeHh9YgHM FsbxDMdIRJE509D0VvqHtpaQk8ECWX4Dm8O4CORQ0KR2P2dnoSQZ7v651 uMElcDQqgn1NALZ4jh33Ul5T2An2xZKmUfcqzM+yDu7ioxguBU7rlQO5b 2gcJ9OoCeyONftZcLwFSqT894xVo3bLP7rZ9hCljio459oDNS7CQx8jXE w==; X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="356052765" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="356052765" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2023 02:10:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10609"; a="659047710" X-IronPort-AV: E=Sophos;i="5.97,270,1669104000"; d="scan'208";a="659047710" Received: from dpdk-beileix-3.sh.intel.com ([10.67.110.253]) by orsmga007.jf.intel.com with ESMTP; 03 Feb 2023 02:10:04 -0800 From: beilei.xing@intel.com To: jingjing.wu@intel.com Cc: dev@dpdk.org, qi.z.zhang@intel.com, Beilei Xing <beilei.xing@intel.com> Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle Date: Fri, 3 Feb 2023 09:43:21 +0000 Message-Id: <20230203094340.8103-1-beilei.xing@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20230202095357.37929-1-beilei.xing@intel.com> References: <20230202095357.37929-1-beilei.xing@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
net/idpf: introduce idpf common modle
|
|
Message
Xing, Beilei
Feb. 3, 2023, 9:43 a.m. UTC
From: Beilei Xing <beilei.xing@intel.com>
Refactor idpf pmd by introducing idpf common module, which will be also
consumed by a new PMD - CPFL (Control Plane Function Library) PMD.
v2 changes:
- Refine irq map/unmap functions.
- Fix cross compile issue.
v3 changes:
- Embed vport_info field into the vport structure.
- Refine APIs' name and order in version.map.
- Refine commit log.
v4 changes:
- Refine commit log.
v5 changes:
- Refine version.map.
- Fix typo.
- Return error log.
v6 changes:
- Refine API name in common module.
Beilei Xing (19):
common/idpf: add adapter structure
common/idpf: add vport structure
common/idpf: add virtual channel functions
common/idpf: introduce adapter init and deinit
common/idpf: add vport init/deinit
common/idpf: add config RSS
common/idpf: add irq map/unmap
common/idpf: support get packet type
common/idpf: add vport info initialization
common/idpf: add vector flags in vport
common/idpf: add rxq and txq struct
common/idpf: add help functions for queue setup and release
common/idpf: add Rx and Tx data path
common/idpf: add vec queue setup
common/idpf: add avx512 for single queue model
common/idpf: refine API name for vport functions
common/idpf: refine API name for queue config module
common/idpf: refine API name for data path module
common/idpf: refine API name for virtual channel functions
drivers/common/idpf/base/idpf_controlq_api.h | 6 -
drivers/common/idpf/base/meson.build | 2 +-
drivers/common/idpf/idpf_common_device.c | 655 +++++
drivers/common/idpf/idpf_common_device.h | 195 ++
drivers/common/idpf/idpf_common_logs.h | 47 +
drivers/common/idpf/idpf_common_rxtx.c | 1458 ++++++++++++
drivers/common/idpf/idpf_common_rxtx.h | 278 +++
.../idpf/idpf_common_rxtx_avx512.c} | 24 +-
.../idpf/idpf_common_virtchnl.c} | 945 ++------
drivers/common/idpf/idpf_common_virtchnl.h | 52 +
drivers/common/idpf/meson.build | 38 +
drivers/common/idpf/version.map | 61 +-
drivers/net/idpf/idpf_ethdev.c | 552 +----
drivers/net/idpf/idpf_ethdev.h | 194 +-
drivers/net/idpf/idpf_logs.h | 24 -
drivers/net/idpf/idpf_rxtx.c | 2107 +++--------------
drivers/net/idpf/idpf_rxtx.h | 253 +-
drivers/net/idpf/meson.build | 18 -
18 files changed, 3442 insertions(+), 3467 deletions(-)
create mode 100644 drivers/common/idpf/idpf_common_device.c
create mode 100644 drivers/common/idpf/idpf_common_device.h
create mode 100644 drivers/common/idpf/idpf_common_logs.h
create mode 100644 drivers/common/idpf/idpf_common_rxtx.c
create mode 100644 drivers/common/idpf/idpf_common_rxtx.h
rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c => common/idpf/idpf_common_rxtx_avx512.c} (97%)
rename drivers/{net/idpf/idpf_vchnl.c => common/idpf/idpf_common_virtchnl.c} (52%)
create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h
Comments
> -----Original Message----- > From: Xing, Beilei <beilei.xing@intel.com> > Sent: Friday, February 3, 2023 5:43 PM > To: Wu, Jingjing <jingjing.wu@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei > <beilei.xing@intel.com> > Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle > > From: Beilei Xing <beilei.xing@intel.com> > > Refactor idpf pmd by introducing idpf common module, which will be also > consumed by a new PMD - CPFL (Control Plane Function Library) PMD. > > v2 changes: > - Refine irq map/unmap functions. > - Fix cross compile issue. > v3 changes: > - Embed vport_info field into the vport structure. > - Refine APIs' name and order in version.map. > - Refine commit log. > v4 changes: > - Refine commit log. > v5 changes: > - Refine version.map. > - Fix typo. > - Return error log. > v6 changes: > - Refine API name in common module. > > Beilei Xing (19): > common/idpf: add adapter structure > common/idpf: add vport structure > common/idpf: add virtual channel functions > common/idpf: introduce adapter init and deinit > common/idpf: add vport init/deinit > common/idpf: add config RSS > common/idpf: add irq map/unmap > common/idpf: support get packet type > common/idpf: add vport info initialization > common/idpf: add vector flags in vport > common/idpf: add rxq and txq struct > common/idpf: add help functions for queue setup and release > common/idpf: add Rx and Tx data path > common/idpf: add vec queue setup > common/idpf: add avx512 for single queue model > common/idpf: refine API name for vport functions > common/idpf: refine API name for queue config module > common/idpf: refine API name for data path module > common/idpf: refine API name for virtual channel functions > > drivers/common/idpf/base/idpf_controlq_api.h | 6 - > drivers/common/idpf/base/meson.build | 2 +- > drivers/common/idpf/idpf_common_device.c | 655 +++++ > drivers/common/idpf/idpf_common_device.h | 195 ++ > drivers/common/idpf/idpf_common_logs.h | 47 + > drivers/common/idpf/idpf_common_rxtx.c | 1458 ++++++++++++ > drivers/common/idpf/idpf_common_rxtx.h | 278 +++ > .../idpf/idpf_common_rxtx_avx512.c} | 24 +- > .../idpf/idpf_common_virtchnl.c} | 945 ++------ > drivers/common/idpf/idpf_common_virtchnl.h | 52 + > drivers/common/idpf/meson.build | 38 + > drivers/common/idpf/version.map | 61 +- > drivers/net/idpf/idpf_ethdev.c | 552 +---- > drivers/net/idpf/idpf_ethdev.h | 194 +- > drivers/net/idpf/idpf_logs.h | 24 - > drivers/net/idpf/idpf_rxtx.c | 2107 +++-------------- > drivers/net/idpf/idpf_rxtx.h | 253 +- > drivers/net/idpf/meson.build | 18 - > 18 files changed, 3442 insertions(+), 3467 deletions(-) create mode 100644 > drivers/common/idpf/idpf_common_device.c > create mode 100644 drivers/common/idpf/idpf_common_device.h > create mode 100644 drivers/common/idpf/idpf_common_logs.h > create mode 100644 drivers/common/idpf/idpf_common_rxtx.c > create mode 100644 drivers/common/idpf/idpf_common_rxtx.h > rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c => > common/idpf/idpf_common_rxtx_avx512.c} (97%) rename > drivers/{net/idpf/idpf_vchnl.c => common/idpf/idpf_common_virtchnl.c} > (52%) create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h > > -- > 2.26.2 Overall looks good to me, just couple thing need to fix 1. fix copy right date to 2023 2. fix some meson build , you can use devtools/check-meson.py to check the warning.
> -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Monday, February 6, 2023 10:59 AM > To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > Cc: dev@dpdk.org > Subject: RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle > > > > > -----Original Message----- > > From: Xing, Beilei <beilei.xing@intel.com> > > Sent: Friday, February 3, 2023 5:43 PM > > To: Wu, Jingjing <jingjing.wu@intel.com> > > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei > > <beilei.xing@intel.com> > > Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle > > > > From: Beilei Xing <beilei.xing@intel.com> > > > > Refactor idpf pmd by introducing idpf common module, which will be > > also consumed by a new PMD - CPFL (Control Plane Function Library) PMD. > > > > v2 changes: > > - Refine irq map/unmap functions. > > - Fix cross compile issue. > > v3 changes: > > - Embed vport_info field into the vport structure. > > - Refine APIs' name and order in version.map. > > - Refine commit log. > > v4 changes: > > - Refine commit log. > > v5 changes: > > - Refine version.map. > > - Fix typo. > > - Return error log. > > v6 changes: > > - Refine API name in common module. > > > > Beilei Xing (19): > > common/idpf: add adapter structure > > common/idpf: add vport structure > > common/idpf: add virtual channel functions > > common/idpf: introduce adapter init and deinit > > common/idpf: add vport init/deinit > > common/idpf: add config RSS > > common/idpf: add irq map/unmap > > common/idpf: support get packet type > > common/idpf: add vport info initialization > > common/idpf: add vector flags in vport > > common/idpf: add rxq and txq struct > > common/idpf: add help functions for queue setup and release > > common/idpf: add Rx and Tx data path > > common/idpf: add vec queue setup > > common/idpf: add avx512 for single queue model > > common/idpf: refine API name for vport functions > > common/idpf: refine API name for queue config module > > common/idpf: refine API name for data path module > > common/idpf: refine API name for virtual channel functions > > > > drivers/common/idpf/base/idpf_controlq_api.h | 6 - > > drivers/common/idpf/base/meson.build | 2 +- > > drivers/common/idpf/idpf_common_device.c | 655 +++++ > > drivers/common/idpf/idpf_common_device.h | 195 ++ > > drivers/common/idpf/idpf_common_logs.h | 47 + > > drivers/common/idpf/idpf_common_rxtx.c | 1458 ++++++++++++ > > drivers/common/idpf/idpf_common_rxtx.h | 278 +++ > > .../idpf/idpf_common_rxtx_avx512.c} | 24 +- > > .../idpf/idpf_common_virtchnl.c} | 945 ++------ > > drivers/common/idpf/idpf_common_virtchnl.h | 52 + > > drivers/common/idpf/meson.build | 38 + > > drivers/common/idpf/version.map | 61 +- > > drivers/net/idpf/idpf_ethdev.c | 552 +---- > > drivers/net/idpf/idpf_ethdev.h | 194 +- > > drivers/net/idpf/idpf_logs.h | 24 - > > drivers/net/idpf/idpf_rxtx.c | 2107 +++-------------- > > drivers/net/idpf/idpf_rxtx.h | 253 +- > > drivers/net/idpf/meson.build | 18 - > > 18 files changed, 3442 insertions(+), 3467 deletions(-) create mode > > 100644 drivers/common/idpf/idpf_common_device.c > > create mode 100644 drivers/common/idpf/idpf_common_device.h > > create mode 100644 drivers/common/idpf/idpf_common_logs.h > > create mode 100644 drivers/common/idpf/idpf_common_rxtx.c > > create mode 100644 drivers/common/idpf/idpf_common_rxtx.h > > rename drivers/{net/idpf/idpf_rxtx_vec_avx512.c => > > common/idpf/idpf_common_rxtx_avx512.c} (97%) rename > > drivers/{net/idpf/idpf_vchnl.c => common/idpf/idpf_common_virtchnl.c} > > (52%) create mode 100644 drivers/common/idpf/idpf_common_virtchnl.h > > > > -- > > 2.26.2 > > Overall looks good to me, just couple thing need to fix > > 1. fix copy right date to 2023 > 2. fix some meson build , you can use devtools/check-meson.py to check the > warning. Yes, updated in v7. > > >