Message ID | 20230116153714.554470-1-bruce.richardson@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F6B6423F1; Mon, 16 Jan 2023 16:37:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA7AB40691; Mon, 16 Jan 2023 16:37:34 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5D87B40042 for <dev@dpdk.org>; Mon, 16 Jan 2023 16:37:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673883453; x=1705419453; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4dre2udH1vNq4wBj1z62wHAuqkr7eBgM4W8juIAhqbc=; b=nDM3euBAUlFTo8nf4AGT3xExy3OQWp6kGO/80Ln4y4A0tF+Po121CA7E VaonxDvCXjdyeV33oPU9Ehty05ETczKyMA5IO5TLSjXAOzeUwYLPo0obw cCekRy52endhKYsgj2W35QAnwhOv6YyyCaa5fFGZO4fIrepccPLZFDj8x UXWFKpNuS9cbuJ5LCzJFwrf991r/lTDKBK6kqEEFhmdHz3gg8JOkRvC5b LUD6xv1MTmV79elLNiay3cD8+ayoLjYw23n2WGdVUDkQQPMAksunlJWNG J3L8V2wIxJuygx7a9lT1nlVMeg5ktq4TGM4GwU6fJ2YKNcEK2EU06zD7S g==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="351735331" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="351735331" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 07:37:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="727505458" X-IronPort-AV: E=Sophos;i="5.97,221,1669104000"; d="scan'208";a="727505458" Received: from silpixa00401385.ir.intel.com ([10.237.214.55]) by fmsmga004.fm.intel.com with ESMTP; 16 Jan 2023 07:37:31 -0800 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com> Subject: [PATCH 0/5] dma/ioat: fix issues with stopping and restarting device Date: Mon, 16 Jan 2023 15:37:09 +0000 Message-Id: <20230116153714.554470-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
dma/ioat: fix issues with stopping and restarting device
|
|
Message
Bruce Richardson
Jan. 16, 2023, 3:37 p.m. UTC
This patchset fixes a couple of problems with stopping and restarting an ioat DMA device. Following the two fixes, a series of improvements are made to the dmadev unit tests to properly validate that dmadevs work correctly as they are started and stopped, and ensure that no other or future drivers will suffer from issues. Bruce Richardson (5): dma/ioat: fix device stop if no copies done dma/ioat: fix incorrectly set indexes after restart test/dmadev: check result for device stop test/dmadev: create separate function for single copy test test/dmadev: add tests for stopping and restarting dev app/test/test_dmadev.c | 172 ++++++++++++++++++++++----------- drivers/dma/ioat/ioat_dmadev.c | 26 ++++- 2 files changed, 137 insertions(+), 61 deletions(-) -- 2.37.2
Comments
Hi Bruce, This patchset breaks the dmadev autotest for IOAT on IceLake. Trace below: ### Test dmadev instance 0 [0000:00:01.0] IOAT.status: ACTIVE [0x100242880] DMA Dev 0: Running copy Tests Ops submitted: 85120 Ops completed: 85120 Errors: 0 DMA Dev 0: Running stop-start Tests IOAT.status: ACTIVE [0x100242880] IOAT.status: ACTIVE [0x100242880] Ops submitted: 1 Ops completed: 1 Errors: 0 DMA Dev 0: Running burst capacity Tests Ops submitted: 65536 Ops completed: 65536 Errors: 0 DMA Dev 0: Running error handling Tests (errors expected) In test_failure_in_full_burst:390 - Error, missing expected failed copy, 0. has_error is not set In runtest:58 - Error, not all submitted jobs are reported as completed In test_dma:940 - Error, test failure for device 0 Test Faileded: 16 Ops completed: 0 Errors: 0 RTE>>IOAT: ioat_dmadev_remove(): Closing 0000:00:01.0 on NUMA node 0 Thanks, Conor. > -----Original Message----- > From: Bruce Richardson <bruce.richardson@intel.com> > Sent: Monday 16 January 2023 15:37 > To: dev@dpdk.org > Cc: Richardson, Bruce <bruce.richardson@intel.com> > Subject: [PATCH 0/5] dma/ioat: fix issues with stopping and restarting device > > This patchset fixes a couple of problems with stopping and restarting an > ioat DMA device. Following the two fixes, a series of improvements are > made to the dmadev unit tests to properly validate that dmadevs work > correctly as they are started and stopped, and ensure that no other or > future drivers will suffer from issues. > > Bruce Richardson (5): > dma/ioat: fix device stop if no copies done > dma/ioat: fix incorrectly set indexes after restart > test/dmadev: check result for device stop > test/dmadev: create separate function for single copy test > test/dmadev: add tests for stopping and restarting dev > > app/test/test_dmadev.c | 172 ++++++++++++++++++++++----------- > drivers/dma/ioat/ioat_dmadev.c | 26 ++++- > 2 files changed, 137 insertions(+), 61 deletions(-) > > -- > 2.37.2
On Mon, Jan 16, 2023 at 04:09:19PM +0000, Walsh, Conor wrote: > Hi Bruce, > > This patchset breaks the dmadev autotest for IOAT on IceLake. > > Trace below: > > ### Test dmadev instance 0 [0000:00:01.0] IOAT.status: ACTIVE > [0x100242880] DMA Dev 0: Running copy Tests Ops submitted: 85120 Ops > completed: 85120 Errors: 0 DMA Dev 0: Running stop-start Tests > IOAT.status: ACTIVE [0x100242880] IOAT.status: ACTIVE [0x100242880] Ops > submitted: 1 Ops completed: 1 Errors: 0 DMA Dev 0: Running > burst capacity Tests Ops submitted: 65536 Ops completed: 65536 > Errors: 0 DMA Dev 0: Running error handling Tests (errors expected) In > test_failure_in_full_burst:390 - Error, missing expected failed copy, 0. > has_error is not set In runtest:58 - Error, not all submitted jobs are > reported as completed In test_dma:940 - Error, test failure for device 0 > Test Faileded: 16 Ops completed: 0 Errors: 0 RTE>>IOAT: > ioat_dmadev_remove(): Closing 0000:00:01.0 on NUMA node 0 > > Thanks, Conor. > Thanks for catching this, Conor. I was testing on a system using noiommu mode, so those error tests were getting skipped. I'll investigate and do a v2. /Bruce