mbox series

[v8,0/4] ethdev: support mulitiple mbuf pools per Rx queue

Message ID 20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru (mailing list archive)
Headers show
Series ethdev: support mulitiple mbuf pools per Rx queue | expand

Message

Andrew Rybchenko Oct. 7, 2022, 5:29 p.m. UTC
I'm not sure in testpmd patch. Review would be useful and may be we
should postpone it to rc2.

v8:
 - Process review notes
v7:
 - Drop RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL offload which seems to be
   unnecessary. Positive max_rx_mempools in dev_info is sufficient to
   indicate that the capability is support and positive number of
   mempools in Rx configuration is sufficient to request it.
 - Add helper patch to factor out Rx mempool check to be shared
   for single mempool, buffer split and multiple mempools case.
 - Refine check for a way to provide Rx buffers to be one and only one.
   Either single mempool, or buffer split, or multi mempool.
 - Drop feature advertisement in net/cnxk patch since there is no
   such feature defined yet. I have no strong opinion if a new feature
   is required or not.
v6:
 - Updated release notes, release_22_11.rst.
v5:
 - Declared memory pools as struct rte_mempool **rx_mempools rather than
   as struct rte_mempool *mp.
 - Added the feature in release notes.
 - Updated conditions and strings as per review comments.
v4:
 - Renamed Offload capability name from RTE_ETH_RX_OFFLOAD_BUFFER_SORT
   to RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL.
 - In struct rte_eth_rxconf, defined new pointer, which holds array of
   type struct rte_eth_rx_mempool(memory pools). This array is used
   by PMD to program multiple mempools.
v3:
 - Implemented Pool Sort capability as new Rx offload capability,
   RTE_ETH_RX_OFFLOAD_BUFFER_SORT.
v2:
 - Along with spec changes, uploading testpmd and driver changes.

Andrew Rybchenko (1):
  ethdev: factor out helper function to check Rx mempool

Hanumanth Pothula (3):
  ethdev: support multiple mbuf pools per Rx queue
  net/cnxk: support mulitiple mbuf pools per Rx queue
  app/testpmd: support mulitiple mbuf pools per Rx queue

 app/test-pmd/testpmd.c                 |  34 ++++--
 app/test-pmd/testpmd.h                 |   3 +
 app/test-pmd/util.c                    |   4 +-
 doc/guides/rel_notes/release_22_11.rst |   6 +
 drivers/net/cnxk/cnxk_ethdev.c         |  84 +++++++++++--
 drivers/net/cnxk/cnxk_ethdev.h         |   2 +
 drivers/net/cnxk/cnxk_ethdev_ops.c     |   3 +
 lib/ethdev/rte_ethdev.c                | 157 +++++++++++++++++--------
 lib/ethdev/rte_ethdev.h                |  29 +++++
 9 files changed, 253 insertions(+), 69 deletions(-)

Comments

Thomas Monjalon Oct. 8, 2022, 8:38 p.m. UTC | #1
07/10/2022 19:29, Andrew Rybchenko:
> I'm not sure in testpmd patch. Review would be useful and may be we
> should postpone it to rc2.
> 
> v8:
>  - Process review notes
> v7:
>  - Drop RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL offload which seems to be
>    unnecessary. Positive max_rx_mempools in dev_info is sufficient to
>    indicate that the capability is support and positive number of
>    mempools in Rx configuration is sufficient to request it.
>  - Add helper patch to factor out Rx mempool check to be shared
>    for single mempool, buffer split and multiple mempools case.
>  - Refine check for a way to provide Rx buffers to be one and only one.
>    Either single mempool, or buffer split, or multi mempool.
>  - Drop feature advertisement in net/cnxk patch since there is no
>    such feature defined yet. I have no strong opinion if a new feature
>    is required or not.
> v6:
>  - Updated release notes, release_22_11.rst.
> v5:
>  - Declared memory pools as struct rte_mempool **rx_mempools rather than
>    as struct rte_mempool *mp.
>  - Added the feature in release notes.
>  - Updated conditions and strings as per review comments.
> v4:
>  - Renamed Offload capability name from RTE_ETH_RX_OFFLOAD_BUFFER_SORT
>    to RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL.
>  - In struct rte_eth_rxconf, defined new pointer, which holds array of
>    type struct rte_eth_rx_mempool(memory pools). This array is used
>    by PMD to program multiple mempools.
> v3:
>  - Implemented Pool Sort capability as new Rx offload capability,
>    RTE_ETH_RX_OFFLOAD_BUFFER_SORT.
> v2:
>  - Along with spec changes, uploading testpmd and driver changes.
> 
> Andrew Rybchenko (1):
>   ethdev: factor out helper function to check Rx mempool
> 
> Hanumanth Pothula (3):
>   ethdev: support multiple mbuf pools per Rx queue
>   net/cnxk: support mulitiple mbuf pools per Rx queue
>   app/testpmd: support mulitiple mbuf pools per Rx queue

Applied, except testpmd patch, as recommended by Andrew, thanks.