mbox series

[v3,0/2] Vector support for event crypto adapter

Message ID 20221001004213.2911114-1-vfialko@marvell.com (mailing list archive)
Headers show
Series Vector support for event crypto adapter | expand

Message

Volodymyr Fialko Oct. 1, 2022, 12:42 a.m. UTC
Introduce ability to aggregate crypto operations processed by event
crypto adapter into single event containing rte_event_vector whose event
type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR.

* Changes since v1
- Add missing newline/space issues
- Add missing error messages
- Remove double check of conf input parameter

* Changes since v2
- Rebase on top of dpdk-next-eventdev branch
- Remove already merged patch

Volodymyr Fialko (2):
  eventdev: introduce event cryptodev vector type
  crypto/cnxk: add vectorization for event crypto

 app/test-eventdev/test_perf_common.c          |  11 +-
 app/test/test_event_crypto_adapter.c          |  12 +-
 .../prog_guide/event_crypto_adapter.rst       |  23 +-
 drivers/crypto/cnxk/cn10k_cryptodev_ops.c     | 398 ++++++++++++++++--
 drivers/crypto/cnxk/cn10k_cryptodev_ops.h     |   2 +
 drivers/crypto/cnxk/cnxk_cryptodev_ops.h      |   9 +-
 drivers/crypto/cnxk/version.map               |   1 +
 drivers/event/cnxk/cn10k_eventdev.c           |  33 +-
 drivers/event/cnxk/cn10k_worker.h             |   6 +-
 drivers/event/cnxk/cn9k_eventdev.c            |  10 +-
 drivers/event/cnxk/cnxk_eventdev.h            |   4 +-
 drivers/event/cnxk/cnxk_eventdev_adptr.c      |  17 +-
 drivers/event/dpaa/dpaa_eventdev.c            |   9 +-
 drivers/event/dpaa2/dpaa2_eventdev.c          |   9 +-
 drivers/event/octeontx/ssovf_evdev.c          |   4 +-
 lib/eventdev/eventdev_pmd.h                   |  35 +-
 lib/eventdev/eventdev_trace.h                 |   6 +-
 lib/eventdev/rte_event_crypto_adapter.c       | 105 ++++-
 lib/eventdev/rte_event_crypto_adapter.h       | 101 ++++-
 lib/eventdev/rte_eventdev.h                   |   8 +
 20 files changed, 698 insertions(+), 105 deletions(-)

Comments

Akhil Goyal Oct. 1, 2022, 3:42 a.m. UTC | #1
> Subject: [PATCH v3 0/2] Vector support for event crypto adapter
> 
> Introduce ability to aggregate crypto operations processed by event
> crypto adapter into single event containing rte_event_vector whose event
> type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR.
> 
> * Changes since v1
> - Add missing newline/space issues
> - Add missing error messages
> - Remove double check of conf input parameter
> 
> * Changes since v2
> - Rebase on top of dpdk-next-eventdev branch
> - Remove already merged patch
> 

Series Acked-by: Akhil Goyal <gakhil@marvell.com>

Since there is no response and we are approaching RC1 deadline patches are applied to dpdk-next-crypto
 with below changes.

Updated release notes and removed deprecation notice.
Added a build fix because of removal of a macro RTE_FUNC_PTR_OR_ERR_RET.

Thanks.
Gujjar, Abhinandan S Oct. 1, 2022, 8 a.m. UTC | #2
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Saturday, October 1, 2022 9:12 AM
> To: Volodymyr Fialko <vfialko@marvell.com>; dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> Volodymyr Fialko <vfialko@marvell.com>
> Subject: RE: [PATCH v3 0/2] Vector support for event crypto adapter
> 
> > Subject: [PATCH v3 0/2] Vector support for event crypto adapter
> >
> > Introduce ability to aggregate crypto operations processed by event
> > crypto adapter into single event containing rte_event_vector whose
> > event type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR.
> >
> > * Changes since v1
> > - Add missing newline/space issues
> > - Add missing error messages
> > - Remove double check of conf input parameter
> >
> > * Changes since v2
> > - Rebase on top of dpdk-next-eventdev branch
> > - Remove already merged patch
> >
> 
> Series Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> Since there is no response and we are approaching RC1 deadline patches are
> applied to dpdk-next-crypto  with below changes.
Hi @Akhil Goyal,

Did not we discuss in the call, and I committed to acked the patch by Saturday?
You cant call that as no response!
> 
> Updated release notes and removed deprecation notice.
> Added a build fix because of removal of a macro RTE_FUNC_PTR_OR_ERR_RET.
> 
> Thanks.
Akhil Goyal Oct. 1, 2022, 8:47 a.m. UTC | #3
> > > Subject: [PATCH v3 0/2] Vector support for event crypto adapter
> > >
> > > Introduce ability to aggregate crypto operations processed by event
> > > crypto adapter into single event containing rte_event_vector whose
> > > event type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR.
> > >
> > > * Changes since v1
> > > - Add missing newline/space issues
> > > - Add missing error messages
> > > - Remove double check of conf input parameter
> > >
> > > * Changes since v2
> > > - Rebase on top of dpdk-next-eventdev branch
> > > - Remove already merged patch
> > >
> >
> > Series Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > Since there is no response and we are approaching RC1 deadline patches are
> > applied to dpdk-next-crypto  with below changes.
> Hi @Akhil Goyal,
> 
> Did not we discuss in the call, and I committed to acked the patch by Saturday?
> You cant call that as no response!

I mentioned in the call that we have RC1 deadline, ack/nack shall be provided as soon as possible.
It was agreed that it will come by Friday. I can not spend all of my weekend on a particular series.
There are other series also.
The patches have been there for about 2 months(V1 was shared on August 4).
As per DPDK guidelines, I could merge a patch if there is no response for more than 3 weeks even without asking anybody.
I asked out to you just to be courteous on Sep 22. And even after that your responses were pretty slow.
You should give ample time for rework to happen before the deadline.

From next time onwards, I will not ask for review. You should be proactive within 3 weeks.
> >
> > Updated release notes and removed deprecation notice.
> > Added a build fix because of removal of a macro
> RTE_FUNC_PTR_OR_ERR_RET.
> >
> > Thanks.
Gujjar, Abhinandan S Oct. 2, 2022, 1:56 a.m. UTC | #4
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Saturday, October 1, 2022 2:18 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Volodymyr Fialko
> <vfialko@marvell.com>; dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; Volodymyr Fialko <vfialko@marvell.com>;
> Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> Subject: RE: [PATCH v3 0/2] Vector support for event crypto adapter
> 
> > > > Subject: [PATCH v3 0/2] Vector support for event crypto adapter
> > > >
> > > > Introduce ability to aggregate crypto operations processed by
> > > > event crypto adapter into single event containing rte_event_vector
> > > > whose event type is RTE_EVENT_TYPE_CRYPTODEV_VECTOR.
> > > >
> > > > * Changes since v1
> > > > - Add missing newline/space issues
> > > > - Add missing error messages
> > > > - Remove double check of conf input parameter
> > > >
> > > > * Changes since v2
> > > > - Rebase on top of dpdk-next-eventdev branch
> > > > - Remove already merged patch
> > > >
> > >
> > > Series Acked-by: Akhil Goyal <gakhil@marvell.com>
> > >
> > > Since there is no response and we are approaching RC1 deadline
> > > patches are applied to dpdk-next-crypto  with below changes.
> > Hi @Akhil Goyal,
> >
> > Did not we discuss in the call, and I committed to acked the patch by
> Saturday?
> > You cant call that as no response!
> 
> I mentioned in the call that we have RC1 deadline, ack/nack shall be provided
> as soon as possible.
> It was agreed that it will come by Friday. I can not spend all of my weekend on
> a particular series.
> There are other series also.
> The patches have been there for about 2 months(V1 was shared on August 4).
> As per DPDK guidelines, I could merge a patch if there is no response for more
> than 3 weeks even without asking anybody.
> I asked out to you just to be courteous on Sep 22. And even after that your
> responses were pretty slow.
> You should give ample time for rework to happen before the deadline.
But this time few things were not clear. So, we had a call.
I would not have sent this mail if I had agreed on Friday.
> 
> From next time onwards, I will not ask for review. You should be proactive
> within 3 weeks.
BTW, there is nothing wrong in sending reminder for the review.
It will help in prioritizing the task in the busy schedule.
> > >
> > > Updated release notes and removed deprecation notice.
> > > Added a build fix because of removal of a macro
> > RTE_FUNC_PTR_OR_ERR_RET.
> > >
> > > Thanks.