mbox series

[v2,00/37] baseband/acc100: changes for 22.11

Message ID 20220820023157.189047-1-hernan.vargas@intel.com (mailing list archive)
Headers
Series baseband/acc100: changes for 22.11 |

Message

Hernan Vargas Aug. 20, 2022, 2:31 a.m. UTC 
  Upstreaming ACC100 changes for 22.11.
This patch series is dependant on series:
https://patches.dpdk.org/project/dpdk/patch/1657150110-69957

Hernan Vargas (37):
  baseband/acc100: add enqueue status
  baseband/acc100: update ring availability calculation
  baseband/acc100: add function to check AQ availability
  baseband/acc100: free SW ring mem for reconfiguration
  baseband/acc100: memory leak fix
  baseband/acc100: add default e value for FCW
  baseband/acc100: add LDPC encoder padding function
  baseband/acc100: add scatter-gather support
  baseband/acc100: add HARQ index helper function
  baseband/acc100: avoid mux for small inbound frames
  baseband/acc100: separate validation functions from debug
  baseband/acc100: add LDPC transport block support
  baseband/acc10x: limit cases for HARQ pruning
  baseband/acc100: update validate LDPC enc/dec
  baseband/acc100: add workaround for deRM corner cases
  baseband/acc100: add ring companion address
  baseband/acc100: configure PMON control registers
  baseband/acc100: implement configurable queue depth
  baseband/acc100: add queue stop operation
  baseband/acc100: check turbo dec/enc input
  baseband/acc100: check for unlikely operation vals
  baseband/acc100: enforce additional check on FCW
  baseband/acc100: update uplink CB input length
  baseband/acc100: rename ldpc encode function arg
  baseband/acc100: update log messages
  baseband/acc100: allocate ring/queue mem when NULL
  baseband/acc100: store FCW from first CB descriptor
  baseband/acc100: make desc optimization optional
  baseband/acc100: update device info
  baseband/acc100: reduce input length for CRC24B
  baseband/acc100: fix clearing PF IR outside handler
  baseband/acc100: fix debug print for LDPC FCW
  baseband/acc100: set device min alignment to 1
  baseband/acc100: update meson file sdk dependency
  baseband/acc100: add protection for NULL HARQ input
  baseband/acc100: make HARQ layout memory 4GB
  baseband/acc100: reset pointer after rte_free

 drivers/baseband/acc100/acc100_pf_enum.h |   52 +-
 drivers/baseband/acc100/acc100_pmd.h     |   41 +-
 drivers/baseband/acc100/acc100_vf_enum.h |    6 +
 drivers/baseband/acc100/meson.build      |   21 +
 drivers/baseband/acc100/rte_acc100_pmd.c | 1388 ++++++++++++++++++----
 5 files changed, 1254 insertions(+), 254 deletions(-)

Comments

Akhil Goyal Aug. 23, 2022, 3:59 p.m. UTC | #1 
Hi Hernan,

Can you specify the change log for v2?

> -----Original Message-----
> From: Hernan Vargas <hernan.vargas@intel.com>
> Sent: Saturday, August 20, 2022 8:01 AM
> To: dev@dpdk.org; Akhil Goyal <gakhil@marvell.com>; trix@redhat.com
> Cc: nicolas.chautru@intel.com; qi.z.zhang@intel.com; Hernan Vargas
> <hernan.vargas@intel.com>
> Subject: [EXT] [PATCH v2 00/37] baseband/acc100: changes for 22.11
> 
> External Email
> 
> ----------------------------------------------------------------------
> Upstreaming ACC100 changes for 22.11.
> This patch series is dependant on series:
> https://patches.dpdk.org/project/dpdk/patch/1657150110-69957/
The link is not accessible.

> 
> Hernan Vargas (37):
>   baseband/acc100: add enqueue status
>   baseband/acc100: update ring availability calculation
>   baseband/acc100: add function to check AQ availability
>   baseband/acc100: free SW ring mem for reconfiguration
>   baseband/acc100: memory leak fix
>   baseband/acc100: add default e value for FCW
>   baseband/acc100: add LDPC encoder padding function
>   baseband/acc100: add scatter-gather support
>   baseband/acc100: add HARQ index helper function
>   baseband/acc100: avoid mux for small inbound frames
>   baseband/acc100: separate validation functions from debug
>   baseband/acc100: add LDPC transport block support
>   baseband/acc10x: limit cases for HARQ pruning
>   baseband/acc100: update validate LDPC enc/dec
>   baseband/acc100: add workaround for deRM corner cases
>   baseband/acc100: add ring companion address
>   baseband/acc100: configure PMON control registers
>   baseband/acc100: implement configurable queue depth
>   baseband/acc100: add queue stop operation
>   baseband/acc100: check turbo dec/enc input
>   baseband/acc100: check for unlikely operation vals
>   baseband/acc100: enforce additional check on FCW
>   baseband/acc100: update uplink CB input length
>   baseband/acc100: rename ldpc encode function arg
>   baseband/acc100: update log messages
>   baseband/acc100: allocate ring/queue mem when NULL
>   baseband/acc100: store FCW from first CB descriptor
>   baseband/acc100: make desc optimization optional
>   baseband/acc100: update device info
>   baseband/acc100: reduce input length for CRC24B
>   baseband/acc100: fix clearing PF IR outside handler
>   baseband/acc100: fix debug print for LDPC FCW
>   baseband/acc100: set device min alignment to 1
>   baseband/acc100: update meson file sdk dependency
>   baseband/acc100: add protection for NULL HARQ input
>   baseband/acc100: make HARQ layout memory 4GB
>   baseband/acc100: reset pointer after rte_free
> 
>  drivers/baseband/acc100/acc100_pf_enum.h |   52 +-
>  drivers/baseband/acc100/acc100_pmd.h     |   41 +-
>  drivers/baseband/acc100/acc100_vf_enum.h |    6 +
>  drivers/baseband/acc100/meson.build      |   21 +
>  drivers/baseband/acc100/rte_acc100_pmd.c | 1388 ++++++++++++++++++----
>  5 files changed, 1254 insertions(+), 254 deletions(-)
> 
> --
> 2.37.1
Chautru, Nicolas Aug. 24, 2022, 6:23 p.m. UTC | #2 
Thanks for the feedback Akhil. Hernan is out for a bit but I can cover from him. 
There was no actual code change in v2, only change in commit messages so that to be more explicit and detailed. In case there is a v3, the change log would be amended to capture this. 
Thanks
Nic

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, August 23, 2022 9:00 AM
> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
> trix@redhat.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: RE: [EXT] [PATCH v2 00/37] baseband/acc100: changes for 22.11
> 
> Hi Hernan,
> 
> Can you specify the change log for v2?
> 
> > -----Original Message-----
> > From: Hernan Vargas <hernan.vargas@intel.com>
> > Sent: Saturday, August 20, 2022 8:01 AM
> > To: dev@dpdk.org; Akhil Goyal <gakhil@marvell.com>; trix@redhat.com
> > Cc: nicolas.chautru@intel.com; qi.z.zhang@intel.com; Hernan Vargas
> > <hernan.vargas@intel.com>
> > Subject: [EXT] [PATCH v2 00/37] baseband/acc100: changes for 22.11
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > Upstreaming ACC100 changes for 22.11.
> > This patch series is dependant on series:
> > https://patches.dpdk.org/project/dpdk/patch/1657150110-69957/
> The link is not accessible.
> 
> >
> > Hernan Vargas (37):
> >   baseband/acc100: add enqueue status
> >   baseband/acc100: update ring availability calculation
> >   baseband/acc100: add function to check AQ availability
> >   baseband/acc100: free SW ring mem for reconfiguration
> >   baseband/acc100: memory leak fix
> >   baseband/acc100: add default e value for FCW
> >   baseband/acc100: add LDPC encoder padding function
> >   baseband/acc100: add scatter-gather support
> >   baseband/acc100: add HARQ index helper function
> >   baseband/acc100: avoid mux for small inbound frames
> >   baseband/acc100: separate validation functions from debug
> >   baseband/acc100: add LDPC transport block support
> >   baseband/acc10x: limit cases for HARQ pruning
> >   baseband/acc100: update validate LDPC enc/dec
> >   baseband/acc100: add workaround for deRM corner cases
> >   baseband/acc100: add ring companion address
> >   baseband/acc100: configure PMON control registers
> >   baseband/acc100: implement configurable queue depth
> >   baseband/acc100: add queue stop operation
> >   baseband/acc100: check turbo dec/enc input
> >   baseband/acc100: check for unlikely operation vals
> >   baseband/acc100: enforce additional check on FCW
> >   baseband/acc100: update uplink CB input length
> >   baseband/acc100: rename ldpc encode function arg
> >   baseband/acc100: update log messages
> >   baseband/acc100: allocate ring/queue mem when NULL
> >   baseband/acc100: store FCW from first CB descriptor
> >   baseband/acc100: make desc optimization optional
> >   baseband/acc100: update device info
> >   baseband/acc100: reduce input length for CRC24B
> >   baseband/acc100: fix clearing PF IR outside handler
> >   baseband/acc100: fix debug print for LDPC FCW
> >   baseband/acc100: set device min alignment to 1
> >   baseband/acc100: update meson file sdk dependency
> >   baseband/acc100: add protection for NULL HARQ input
> >   baseband/acc100: make HARQ layout memory 4GB
> >   baseband/acc100: reset pointer after rte_free
> >
> >  drivers/baseband/acc100/acc100_pf_enum.h |   52 +-
> >  drivers/baseband/acc100/acc100_pmd.h     |   41 +-
> >  drivers/baseband/acc100/acc100_vf_enum.h |    6 +
> >  drivers/baseband/acc100/meson.build      |   21 +
> >  drivers/baseband/acc100/rte_acc100_pmd.c | 1388
> > ++++++++++++++++++----
> >  5 files changed, 1254 insertions(+), 254 deletions(-)
> >
> > --
> > 2.37.1
Chautru, Nicolas Sept. 6, 2022, 8:03 p.m. UTC | #3 
Hi Tom, Maxime, Hermant, 
Can we get a few reviews/or and acks for the patches in that serie please?
Much appreciated, 
Nic

> -----Original Message-----
> From: Vargas, Hernan <hernan.vargas@intel.com>
> Sent: Friday, August 19, 2022 7:31 PM
> To: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Vargas, Hernan <hernan.vargas@intel.com>
> Subject: [PATCH v2 00/37] baseband/acc100: changes for 22.11
> 
> Upstreaming ACC100 changes for 22.11.
> This patch series is dependant on series:
> https://patches.dpdk.org/project/dpdk/patch/1657150110-69957
> 
> Hernan Vargas (37):
>   baseband/acc100: add enqueue status
>   baseband/acc100: update ring availability calculation
>   baseband/acc100: add function to check AQ availability
>   baseband/acc100: free SW ring mem for reconfiguration
>   baseband/acc100: memory leak fix
>   baseband/acc100: add default e value for FCW
>   baseband/acc100: add LDPC encoder padding function
>   baseband/acc100: add scatter-gather support
>   baseband/acc100: add HARQ index helper function
>   baseband/acc100: avoid mux for small inbound frames
>   baseband/acc100: separate validation functions from debug
>   baseband/acc100: add LDPC transport block support
>   baseband/acc10x: limit cases for HARQ pruning
>   baseband/acc100: update validate LDPC enc/dec
>   baseband/acc100: add workaround for deRM corner cases
>   baseband/acc100: add ring companion address
>   baseband/acc100: configure PMON control registers
>   baseband/acc100: implement configurable queue depth
>   baseband/acc100: add queue stop operation
>   baseband/acc100: check turbo dec/enc input
>   baseband/acc100: check for unlikely operation vals
>   baseband/acc100: enforce additional check on FCW
>   baseband/acc100: update uplink CB input length
>   baseband/acc100: rename ldpc encode function arg
>   baseband/acc100: update log messages
>   baseband/acc100: allocate ring/queue mem when NULL
>   baseband/acc100: store FCW from first CB descriptor
>   baseband/acc100: make desc optimization optional
>   baseband/acc100: update device info
>   baseband/acc100: reduce input length for CRC24B
>   baseband/acc100: fix clearing PF IR outside handler
>   baseband/acc100: fix debug print for LDPC FCW
>   baseband/acc100: set device min alignment to 1
>   baseband/acc100: update meson file sdk dependency
>   baseband/acc100: add protection for NULL HARQ input
>   baseband/acc100: make HARQ layout memory 4GB
>   baseband/acc100: reset pointer after rte_free
> 
>  drivers/baseband/acc100/acc100_pf_enum.h |   52 +-
>  drivers/baseband/acc100/acc100_pmd.h     |   41 +-
>  drivers/baseband/acc100/acc100_vf_enum.h |    6 +
>  drivers/baseband/acc100/meson.build      |   21 +
>  drivers/baseband/acc100/rte_acc100_pmd.c | 1388 ++++++++++++++++++----
>  5 files changed, 1254 insertions(+), 254 deletions(-)
> 
> --
> 2.37.1