mbox series

[v4,0/1] crypto/openssl: add aes cmac support

Message ID 20220718091855.17604-1-asekhar@marvell.com (mailing list archive)
Headers
Series crypto/openssl: add aes cmac support |

Message

Ashwin Sekhar T K July 18, 2022, 9:18 a.m. UTC 
  Add support for aes cmac operations.

v2:
 * Added support for openssl 3.0
v3:
 * Fixed checkpatch warnings.
v4:
 * Fixed more checkpatch warnings.

Ashwin Sekhar T K (1):
  crypto/openssl: support aes cmac operations

 drivers/crypto/openssl/openssl_pmd_private.h |  14 ++
 drivers/crypto/openssl/rte_openssl_pmd.c     | 142 ++++++++++++++++++-
 drivers/crypto/openssl/rte_openssl_pmd_ops.c |  20 +++
 3 files changed, 169 insertions(+), 7 deletions(-)

Comments

Ji, Kai July 18, 2022, 1:57 p.m. UTC | #1 
Hi Ashwin,

There is duplication of OPENSSL_VERSION_NUMBER check in v4,  right before process_openssl_auth_mac(). 
Are you planning to enable CMAC unit test case in cryptodev_openssl_autotest ?

Regards

Kai 


> -----Original Message-----
> From: Ashwin Sekhar T K <asekhar@marvell.com>
> Sent: Monday, July 18, 2022 10:19 AM
> To: asekhar@marvell.com
> Cc: anoobj@marvell.com; dev@dpdk.org; gakhil@marvell.com;
> hkalra@marvell.com; jerinj@marvell.com; kirankumark@marvell.com;
> ndabilpuram@marvell.com; pbhagavatula@marvell.com;
> psatheesh@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> skori@marvell.com; skoteshwar@marvell.com
> Subject: [PATCH v4 0/1] crypto/openssl: add aes cmac support
> 
> Add support for aes cmac operations.
> 
> v2:
>  * Added support for openssl 3.0
> v3:
>  * Fixed checkpatch warnings.
> v4:
>  * Fixed more checkpatch warnings.
> 
> Ashwin Sekhar T K (1):
>   crypto/openssl: support aes cmac operations
> 
>  drivers/crypto/openssl/openssl_pmd_private.h |  14 ++
>  drivers/crypto/openssl/rte_openssl_pmd.c     | 142 ++++++++++++++++++-
>  drivers/crypto/openssl/rte_openssl_pmd_ops.c |  20 +++
>  3 files changed, 169 insertions(+), 7 deletions(-)
> 
> --
> 2.25.1
Ashwin Sekhar T K July 18, 2022, 4:18 p.m. UTC | #2 
Hi Kai,

Will fix the is duplication of OPENSSL_VERSION_NUMBER check.

Some CMAC tests are already present. The number of successful tests in cryptodev_openssl_autotest increases by 4 with this change. I am not planning to add more.

Regards,
Ashwin Sekhar T K 

> -----Original Message-----
> From: Ji, Kai <kai.ji@intel.com>
> Sent: Monday, July 18, 2022 7:27 PM
> To: Ashwin Sekhar Thalakalath Kottilveetil <asekhar@marvell.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; dev@dpdk.org; Akhil Goyal
> <gakhil@marvell.com>; Harman Kalra <hkalra@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankumark@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; Satheesh Paul Antonysamy
> <psatheesh@marvell.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Sunil Kumar Kori <skori@marvell.com>; Satha Koteswara Rao Kottidi
> <skoteshwar@marvell.com>
> Subject: [EXT] RE: [PATCH v4 0/1] crypto/openssl: add aes cmac support
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Ashwin,
> 
> There is duplication of OPENSSL_VERSION_NUMBER check in v4,  right
> before process_openssl_auth_mac().
> Are you planning to enable CMAC unit test case in
> cryptodev_openssl_autotest ?
> 
> Regards
> 
> Kai
> 
> 
> > -----Original Message-----
> > From: Ashwin Sekhar T K <asekhar@marvell.com>
> > Sent: Monday, July 18, 2022 10:19 AM
> > To: asekhar@marvell.com
> > Cc: anoobj@marvell.com; dev@dpdk.org; gakhil@marvell.com;
> > hkalra@marvell.com; jerinj@marvell.com; kirankumark@marvell.com;
> > ndabilpuram@marvell.com; pbhagavatula@marvell.com;
> > psatheesh@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> > skori@marvell.com; skoteshwar@marvell.com
> > Subject: [PATCH v4 0/1] crypto/openssl: add aes cmac support
> >
> > Add support for aes cmac operations.
> >
> > v2:
> >  * Added support for openssl 3.0
> > v3:
> >  * Fixed checkpatch warnings.
> > v4:
> >  * Fixed more checkpatch warnings.
> >
> > Ashwin Sekhar T K (1):
> >   crypto/openssl: support aes cmac operations
> >
> >  drivers/crypto/openssl/openssl_pmd_private.h |  14 ++
> >  drivers/crypto/openssl/rte_openssl_pmd.c     | 142
> ++++++++++++++++++-
> >  drivers/crypto/openssl/rte_openssl_pmd_ops.c |  20 +++
> >  3 files changed, 169 insertions(+), 7 deletions(-)
> >
> > --
> > 2.25.1