| Message ID | 20220210065334.19942-1-adwivedi@marvell.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 465B7A00C2; Thu, 10 Feb 2022 07:54:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE41B4013F; Thu, 10 Feb 2022 07:54:09 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 47F2740041 for <dev@dpdk.org>; Thu, 10 Feb 2022 07:54:08 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21A2Jnwv014380 for <dev@dpdk.org>; Wed, 9 Feb 2022 22:54:07 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=bCxCl5KRhu8ZEunjpdlajVgfHvQnHUc8c0D/+DTf5HE=; b=c1pyZqsqO2PO/pE6oZTPDe45k+VY0xopXGC7cxug8A69vPGlYKz+rvR7UzZ1aNaB/XOD xiSHNrJ6kpNYgS9WZbU5exh9Q5li12XaKklSZfzqXpZ2YFW5fzRA7CzlFc5jVpOhib0U JCUQL4islIlaL1s2SDFid4oWge6swaMZ8zM6dIspd1vbPzdssIAPFB2FBAg1Itzi/z6T Ou9VZoRn+FIsP0cd6nWVARhKJ4mTscrOPCaRsTYotH3zYqetIbtDcAmwfr7EgiaHCggM 2hINox31OXLH29SUAV4gN265YNPIt9FqCorZTRFbDAD5p6iFwVlKtFfV4MB3kW2YkCQA dQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e4am951tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for <dev@dpdk.org>; Wed, 09 Feb 2022 22:54:07 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 9 Feb 2022 22:54:05 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 9 Feb 2022 22:54:05 -0800 Received: from hyd1349.t110.caveonetworks.com.com (unknown [10.29.45.13]) by maili.marvell.com (Postfix) with ESMTP id C6C103F7074; Wed, 9 Feb 2022 22:54:02 -0800 (PST) From: Ankur Dwivedi <adwivedi@marvell.com> To: <dev@dpdk.org> CC: <ndabilpuram@marvell.com>, <kirankumark@marvell.com>, <skori@marvell.com>, <skoteshwar@marvell.com>, <jerinj@marvell.com>, <anoobj@marvell.com>, <ktejasree@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com> Subject: [PATCH 0/2] add telemetry for inline IPsec Date: Thu, 10 Feb 2022 12:23:32 +0530 Message-ID: <20220210065334.19942-1-adwivedi@marvell.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-GUID: 77LGSHpChQthU8c0OogjiTPLtoJIOGNU X-Proofpoint-ORIG-GUID: 77LGSHpChQthU8c0OogjiTPLtoJIOGNU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-10_02,2022-02-09_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
add telemetry for inline IPsec
|
|
Message
Ankur Dwivedi
Feb. 10, 2022, 6:53 a.m. UTC
Adds telemetry function for inline ipsec in net CNXK driver. This series depends on the following patch series: Series: Adding new features and improvements in cnxk crypto PMD http://patches.dpdk.org/project/dpdk/list/?series=21433 Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for cn9k net/cnxk: add telemetry for inline IPsec for cn10k drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 292 +++++++++++++++++++ drivers/net/cnxk/meson.build | 1 + 2 files changed, 293 insertions(+) create mode 100644 drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c
Comments
On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote: > Adds telemetry function for inline ipsec in net CNXK driver. > > This series depends on the following patch series: > > Series: Adding new features and improvements in cnxk crypto PMD > http://patches.dpdk.org/project/dpdk/list/?series=21433 > > Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for cn9k > net/cnxk: add telemetry for inline IPsec for cn10k > Out of interest, is there any of this telemetry that could be made generic and apply at a device-class or library level rather than being tied to the cnxk driver only?
Hi Bruce, Please see my comment inline. Regards, Ankur >-----Original Message----- >From: Bruce Richardson <bruce.richardson@intel.com> >Sent: Thursday, February 10, 2022 2:42 PM >To: Ankur Dwivedi <adwivedi@marvell.com> >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; >Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori ><skori@marvell.com>; Satha Koteswara Rao Kottidi ><skoteshwar@marvell.com>; Jerin Jacob Kollanukkaran ><jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree >Kondoj <ktejasree@marvell.com> >Subject: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec > >External Email > >---------------------------------------------------------------------- >On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote: >> Adds telemetry function for inline ipsec in net CNXK driver. >> >> This series depends on the following patch series: >> >> Series: Adding new features and improvements in cnxk crypto PMD >> https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_p >> roject_dpdk_list_-3Fseries- >3D21433&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r >> >=ILjiNF3GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=szcLmV4s_NiVroE4B >vC5yW6 >> >litxm6Pfo2ymX7QhE1qDSpKTa56lnfmMqfnohRfI6&s=VtKHr9SAo3R0g7lGPoSJlg >xVxn >> r2t_TYhHbfH7rS4sE&e= >> >> Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for cn9k >> net/cnxk: add telemetry for inline IPsec for cn10k >> >Out of interest, is there any of this telemetry that could be made generic and >apply at a device-class or library level rather than being tied to the cnxk driver >only? I could think of that the callback function registered in rte_telemetry_register_cmd() can be a generic one. The net device (eth_dev) may have ops registered, which can be called depending on dev->tx_offloads and dev->rx_offloads flags. However the data to be returned by telemetry might depend on the PMD. Please let me know if this is possible.
On Thu, Feb 10, 2022 at 10:04:22AM +0000, Ankur Dwivedi wrote: > Hi Bruce, > > Please see my comment inline. > > Regards, > Ankur > > >-----Original Message----- > >From: Bruce Richardson <bruce.richardson@intel.com> > >Sent: Thursday, February 10, 2022 2:42 PM > >To: Ankur Dwivedi <adwivedi@marvell.com> > >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; > >Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori > ><skori@marvell.com>; Satha Koteswara Rao Kottidi > ><skoteshwar@marvell.com>; Jerin Jacob Kollanukkaran > ><jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree > >Kondoj <ktejasree@marvell.com> > >Subject: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec > > > >External Email > > > >---------------------------------------------------------------------- > >On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote: > >> Adds telemetry function for inline ipsec in net CNXK driver. > >> > >> This series depends on the following patch series: > >> > >> Series: Adding new features and improvements in cnxk crypto PMD > >> https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.org_p > >> roject_dpdk_list_-3Fseries- > >3D21433&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r > >> > >=ILjiNF3GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=szcLmV4s_NiVroE4B > >vC5yW6 > >> > >litxm6Pfo2ymX7QhE1qDSpKTa56lnfmMqfnohRfI6&s=VtKHr9SAo3R0g7lGPoSJlg > >xVxn > >> r2t_TYhHbfH7rS4sE&e= > >> > >> Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for cn9k > >> net/cnxk: add telemetry for inline IPsec for cn10k > >> > >Out of interest, is there any of this telemetry that could be made generic and > >apply at a device-class or library level rather than being tied to the cnxk driver > >only? > I could think of that the callback function registered in rte_telemetry_register_cmd() can be a generic one. The net device (eth_dev) may have ops registered, which can be called depending on dev->tx_offloads and dev->rx_offloads flags. However the data to be returned by telemetry might depend on the PMD. > Please let me know if this is possible. Thanks. So if I understand you correctly, the information returned would vary based on the offload flags only? If that is the case, it does sound like it could be generic, where the offload flags field in the return information identify what other fields are present in the reply. That would then make the telemetry generic and possible to implement at the ethdev level. Is that all correct?
>-----Original Message----- >From: Bruce Richardson <bruce.richardson@intel.com> >Sent: Thursday, February 10, 2022 5:02 PM >To: Ankur Dwivedi <adwivedi@marvell.com> >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; >Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori ><skori@marvell.com>; Satha Koteswara Rao Kottidi ><skoteshwar@marvell.com>; Jerin Jacob Kollanukkaran ><jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree >Kondoj <ktejasree@marvell.com>; ferruh.yigit@intel.com >Subject: Re: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec > >On Thu, Feb 10, 2022 at 10:04:22AM +0000, Ankur Dwivedi wrote: >> Hi Bruce, >> >> Please see my comment inline. >> >> Regards, >> Ankur >> >> >-----Original Message----- >> >From: Bruce Richardson <bruce.richardson@intel.com> >> >Sent: Thursday, February 10, 2022 2:42 PM >> >To: Ankur Dwivedi <adwivedi@marvell.com> >> >Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ><ndabilpuram@marvell.com>; >> >Kiran Kumar Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori >> ><skori@marvell.com>; Satha Koteswara Rao Kottidi >> ><skoteshwar@marvell.com>; Jerin Jacob Kollanukkaran >> ><jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Tejasree >> >Kondoj <ktejasree@marvell.com> >> >Subject: [EXT] Re: [PATCH 0/2] add telemetry for inline IPsec >> > >> >External Email >> > >> >--------------------------------------------------------------------- >> >- On Thu, Feb 10, 2022 at 12:23:32PM +0530, Ankur Dwivedi wrote: >> >> Adds telemetry function for inline ipsec in net CNXK driver. >> >> >> >> This series depends on the following patch series: >> >> >> >> Series: Adding new features and improvements in cnxk crypto PMD >> >> https://urldefense.proofpoint.com/v2/url?u=http-3A__patches.dpdk.or >> >> g_p >> >> roject_dpdk_list_-3Fseries- >> >3D21433&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r >> >> >> >>=ILjiNF3GF25y6QdHZUxMl6JrStU0MIuCtO5dMzn3Ybk&m=szcLmV4s_NiVroE4 >B >> >vC5yW6 >> >> >> >>litxm6Pfo2ymX7QhE1qDSpKTa56lnfmMqfnohRfI6&s=VtKHr9SAo3R0g7lGPoSJl >g >> >xVxn >> >> r2t_TYhHbfH7rS4sE&e= >> >> >> >> Ankur Dwivedi (2): net/cnxk: add telemetry for inline IPsec for >> >> cn9k >> >> net/cnxk: add telemetry for inline IPsec for cn10k >> >> >> >Out of interest, is there any of this telemetry that could be made >> >generic and apply at a device-class or library level rather than >> >being tied to the cnxk driver only? >> I could think of that the callback function registered in >rte_telemetry_register_cmd() can be a generic one. The net device (eth_dev) >may have ops registered, which can be called depending on dev->tx_offloads >and dev->rx_offloads flags. However the data to be returned by telemetry >might depend on the PMD. >> Please let me know if this is possible. > >Thanks. So if I understand you correctly, the information returned would vary >based on the offload flags only? If that is the case, it does sound like it could >be generic, where the offload flags field in the return information identify >what other fields are present in the reply. That would then make the >telemetry generic and possible to implement at the ethdev level. Is that all >correct? Apart from offload flags, the information would vary depending on what a PMD is willing to provide. That's why I was thinking ops callback function will be required in struct eth_dev_ops which will be PMD specific. This ops callback will be called from the registered telemetry callback.