mbox series

[0/8] ethdev: introduce IP reassembly offload

Message ID 20220103150813.1694888-1-gakhil@marvell.com (mailing list archive)
Headers
Series ethdev: introduce IP reassembly offload |

Message

Akhil Goyal Jan. 3, 2022, 3:08 p.m. UTC
  As discussed in the RFC[1] sent in 21.11, a new offload is
introduced in ethdev for IP reassembly.

This patchset add the RX offload and an application to test it.
Currently, the offload is tested along with inline IPsec processing.
It can also be updated as a standalone offload without IPsec, if there
are some hardware available to test it.
The patchset is tested on cnxk platform. The driver implementation is
added as a separate patchset.

[1]: http://patches.dpdk.org/project/dpdk/patch/20210823100259.1619886-1-gakhil@marvell.com/


Akhil Goyal (8):
  ethdev: introduce IP reassembly offload
  ethdev: add dev op for IP reassembly configuration
  ethdev: add mbuf dynfield for incomplete IP reassembly
  security: add IPsec option for IP reassembly
  app/test: add unit cases for inline IPsec offload
  app/test: add IP reassembly case with no frags
  app/test: add IP reassembly cases with multiple fragments
  app/test: add IP reassembly negative cases

 app/test/meson.build                          |    1 +
 app/test/test_inline_ipsec.c                  | 1036 +++++++++++++++++
 .../test_inline_ipsec_reassembly_vectors.h    |  790 +++++++++++++
 doc/guides/nics/features.rst                  |   12 +
 lib/ethdev/ethdev_driver.h                    |   27 +
 lib/ethdev/rte_ethdev.c                       |   47 +
 lib/ethdev/rte_ethdev.h                       |  117 +-
 lib/ethdev/version.map                        |    5 +
 lib/mbuf/rte_mbuf_core.h                      |    3 +-
 lib/security/rte_security.h                   |   12 +-
 10 files changed, 2047 insertions(+), 3 deletions(-)
 create mode 100644 app/test/test_inline_ipsec.c
 create mode 100644 app/test/test_inline_ipsec_reassembly_vectors.h
  

Comments

David Marchand Jan. 6, 2022, 9:51 a.m. UTC | #1
On Mon, Jan 3, 2022 at 4:08 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
> As discussed in the RFC[1] sent in 21.11, a new offload is
> introduced in ethdev for IP reassembly.
>
> This patchset add the RX offload and an application to test it.
> Currently, the offload is tested along with inline IPsec processing.
> It can also be updated as a standalone offload without IPsec, if there
> are some hardware available to test it.
> The patchset is tested on cnxk platform. The driver implementation is
> added as a separate patchset.
>
> [1]: http://patches.dpdk.org/project/dpdk/patch/20210823100259.1619886-1-gakhil@marvell.com/
>
>
> Akhil Goyal (8):
>   ethdev: introduce IP reassembly offload
>   ethdev: add dev op for IP reassembly configuration
>   ethdev: add mbuf dynfield for incomplete IP reassembly
>   security: add IPsec option for IP reassembly
>   app/test: add unit cases for inline IPsec offload
>   app/test: add IP reassembly case with no frags
>   app/test: add IP reassembly cases with multiple fragments
>   app/test: add IP reassembly negative cases
>
>  app/test/meson.build                          |    1 +
>  app/test/test_inline_ipsec.c                  | 1036 +++++++++++++++++
>  .../test_inline_ipsec_reassembly_vectors.h    |  790 +++++++++++++

I see no update in MAINTAINERS for those new files.
So I think they end up in the "main" repo scope.

You can either update MAINTAINERS (changing the app/test/test_ipsec*
pattern as app/test/test_*ipsec*) or rename files as
app/test/test_ipsec_inline.c, for example.
  
Akhil Goyal Jan. 6, 2022, 9:54 a.m. UTC | #2
> > Akhil Goyal (8):
> >   ethdev: introduce IP reassembly offload
> >   ethdev: add dev op for IP reassembly configuration
> >   ethdev: add mbuf dynfield for incomplete IP reassembly
> >   security: add IPsec option for IP reassembly
> >   app/test: add unit cases for inline IPsec offload
> >   app/test: add IP reassembly case with no frags
> >   app/test: add IP reassembly cases with multiple fragments
> >   app/test: add IP reassembly negative cases
> >
> >  app/test/meson.build                          |    1 +
> >  app/test/test_inline_ipsec.c                  | 1036 +++++++++++++++++
> >  .../test_inline_ipsec_reassembly_vectors.h    |  790 +++++++++++++
> 
> I see no update in MAINTAINERS for those new files.
> So I think they end up in the "main" repo scope.
> 
> You can either update MAINTAINERS (changing the app/test/test_ipsec*
> pattern as app/test/test_*ipsec*) or rename files as
> app/test/test_ipsec_inline.c, for example.
> 
Thanks for the update David,
There are a few other issues in the patchset, I will post a new version in next few days
With MAINTAINERS updated.