mbox series

[v2,00/10] vdpa/sfc: introduce Xilinx vDPA driver

Message ID 20211028075452.11804-1-vsrivast@xilinx.com (mailing list archive)
Headers
Series vdpa/sfc: introduce Xilinx vDPA driver |

Message

Vijay Srivastava Oct. 28, 2021, 7:54 a.m. UTC 
  This patch series introduces vDPA driver for Xilinx devices.
The Xilinx vDPA (vhost data path acceleration) provides
support for the Xilinx SN1022 SmartNICs.

Vijay Kumar Srivastava (10):
  vdpa/sfc: introduce Xilinx vDPA driver
  vdpa/sfc: add support for device initialization
  vdpa/sfc: add support to get device and protocol features
  vdpa/sfc: get device supported max queue count
  vdpa/sfc: add support to get VFIO device fd
  vdpa/sfc: add support for dev conf and dev close ops
  vdpa/sfc: add support to get queue notify area info
  vdpa/sfc: add support for MAC filter config
  vdpa/sfc: add support to set vring state
  vdpa/sfc: set a multicast filter during vDPA init

 MAINTAINERS                            |   6 +
 doc/guides/rel_notes/release_21_11.rst |   5 +
 doc/guides/vdpadevs/features/sfc.ini   |  19 +
 doc/guides/vdpadevs/sfc.rst            | 107 ++++
 drivers/common/sfc_efx/efsys.h         |   2 +-
 drivers/common/sfc_efx/version.map     |  10 +
 drivers/vdpa/meson.build               |   1 +
 drivers/vdpa/sfc/meson.build           |  37 ++
 drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
 drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
 drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
 drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
 drivers/vdpa/sfc/sfc_vdpa_hw.c         | 419 +++++++++++++++
 drivers/vdpa/sfc/sfc_vdpa_log.h        |  59 ++
 drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
 drivers/vdpa/sfc/sfc_vdpa_ops.c        | 947 +++++++++++++++++++++++++++++++++
 drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
 drivers/vdpa/sfc/version.map           |   3 +
 18 files changed, 2467 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/vdpadevs/features/sfc.ini
 create mode 100644 doc/guides/vdpadevs/sfc.rst
 create mode 100644 drivers/vdpa/sfc/meson.build
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
 create mode 100644 drivers/vdpa/sfc/version.map

Comments

Chenbo Xia Oct. 28, 2021, 8:08 a.m. UTC | #1 
> -----Original Message-----
> From: Vijay Srivastava <vijay.srivastava@xilinx.com>
> Sent: Thursday, October 28, 2021 3:55 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> andrew.rybchenko@oktetlabs.ru; Vijay Srivastava <vsrivast@xilinx.com>
> Subject: [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver
> 
> This patch series introduces vDPA driver for Xilinx devices.
> The Xilinx vDPA (vhost data path acceleration) provides
> support for the Xilinx SN1022 SmartNICs.
> 
> Vijay Kumar Srivastava (10):
>   vdpa/sfc: introduce Xilinx vDPA driver
>   vdpa/sfc: add support for device initialization
>   vdpa/sfc: add support to get device and protocol features
>   vdpa/sfc: get device supported max queue count
>   vdpa/sfc: add support to get VFIO device fd
>   vdpa/sfc: add support for dev conf and dev close ops
>   vdpa/sfc: add support to get queue notify area info
>   vdpa/sfc: add support for MAC filter config
>   vdpa/sfc: add support to set vring state
>   vdpa/sfc: set a multicast filter during vDPA init
> 
> 1.8.3.1

I remember Maxime added R-by in some patches? And Andrew also acked
the whole series?

If yes, you should add those tags in new version.

Thanks,
Chenbo
Maxime Coquelin Oct. 28, 2021, 8:11 a.m. UTC | #2 
On 10/28/21 10:08, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Vijay Srivastava <vijay.srivastava@xilinx.com>
>> Sent: Thursday, October 28, 2021 3:55 PM
>> To: dev@dpdk.org
>> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
>> andrew.rybchenko@oktetlabs.ru; Vijay Srivastava <vsrivast@xilinx.com>
>> Subject: [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver
>>
>> This patch series introduces vDPA driver for Xilinx devices.
>> The Xilinx vDPA (vhost data path acceleration) provides
>> support for the Xilinx SN1022 SmartNICs.
>>
>> Vijay Kumar Srivastava (10):
>>    vdpa/sfc: introduce Xilinx vDPA driver
>>    vdpa/sfc: add support for device initialization
>>    vdpa/sfc: add support to get device and protocol features
>>    vdpa/sfc: get device supported max queue count
>>    vdpa/sfc: add support to get VFIO device fd
>>    vdpa/sfc: add support for dev conf and dev close ops
>>    vdpa/sfc: add support to get queue notify area info
>>    vdpa/sfc: add support for MAC filter config
>>    vdpa/sfc: add support to set vring state
>>    vdpa/sfc: set a multicast filter during vDPA init
>>
>> 1.8.3.1
> 
> I remember Maxime added R-by in some patches? And Andrew also acked
> the whole series?
> 
> If yes, you should add those tags in new version.

Agree with Chenbo, but I'd like to add that it should be done only on
patches that were not significantly reworked.

Maxime
> Thanks,
> Chenbo
>
Maxime Coquelin Oct. 28, 2021, 2:35 p.m. UTC | #3 
On 10/28/21 09:54, Vijay Srivastava wrote:
> This patch series introduces vDPA driver for Xilinx devices.
> The Xilinx vDPA (vhost data path acceleration) provides
> support for the Xilinx SN1022 SmartNICs.
> 
> Vijay Kumar Srivastava (10):
>    vdpa/sfc: introduce Xilinx vDPA driver
>    vdpa/sfc: add support for device initialization
>    vdpa/sfc: add support to get device and protocol features
>    vdpa/sfc: get device supported max queue count
>    vdpa/sfc: add support to get VFIO device fd
>    vdpa/sfc: add support for dev conf and dev close ops
>    vdpa/sfc: add support to get queue notify area info
>    vdpa/sfc: add support for MAC filter config
>    vdpa/sfc: add support to set vring state
>    vdpa/sfc: set a multicast filter during vDPA init
> 
>   MAINTAINERS                            |   6 +
>   doc/guides/rel_notes/release_21_11.rst |   5 +
>   doc/guides/vdpadevs/features/sfc.ini   |  19 +
>   doc/guides/vdpadevs/sfc.rst            | 107 ++++
>   drivers/common/sfc_efx/efsys.h         |   2 +-
>   drivers/common/sfc_efx/version.map     |  10 +
>   drivers/vdpa/meson.build               |   1 +
>   drivers/vdpa/sfc/meson.build           |  37 ++
>   drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
>   drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
>   drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
>   drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
>   drivers/vdpa/sfc/sfc_vdpa_hw.c         | 419 +++++++++++++++
>   drivers/vdpa/sfc/sfc_vdpa_log.h        |  59 ++
>   drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
>   drivers/vdpa/sfc/sfc_vdpa_ops.c        | 947 +++++++++++++++++++++++++++++++++
>   drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
>   drivers/vdpa/sfc/version.map           |   3 +
>   18 files changed, 2467 insertions(+), 1 deletion(-)
>   create mode 100644 doc/guides/vdpadevs/features/sfc.ini
>   create mode 100644 doc/guides/vdpadevs/sfc.rst
>   create mode 100644 drivers/vdpa/sfc/meson.build
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
>   create mode 100644 drivers/vdpa/sfc/version.map
> 

Please also note that doc build is failing:
http://mails.dpdk.org/archives/test-report/2021-October/235652.html

"
Warning, treated as error:
/home/runner/work/dpdk/dpdk/doc/guides/vdpadevs/sfc.rst:document isn't 
included in any toctree
"

Maxime
Vijay Kumar Srivastava Oct. 28, 2021, 6:03 p.m. UTC | #4 
Hi Maxime,

>-----Original Message-----
>From: Maxime Coquelin <maxime.coquelin@redhat.com>
>Sent: Thursday, October 28, 2021 8:05 PM
>To: Vijay Kumar Srivastava <vsrivast@xilinx.com>; dev@dpdk.org
>Cc: chenbo.xia@intel.com; andrew.rybchenko@oktetlabs.ru; Vijay Kumar
>Srivastava <vsrivast@xilinx.com>
>Subject: Re: [PATCH v2 00/10] vdpa/sfc: introduce Xilinx vDPA driver
>
>
>
>On 10/28/21 09:54, Vijay Srivastava wrote:
>> This patch series introduces vDPA driver for Xilinx devices.
>> The Xilinx vDPA (vhost data path acceleration) provides support for
>> the Xilinx SN1022 SmartNICs.
[SNIP]
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
>>   create mode 100644 drivers/vdpa/sfc/version.map
>>
>
>Please also note that doc build is failing:
>http://mails.dpdk.org/archives/test-report/2021-October/235652.html
>
>"
>Warning, treated as error:
>/home/runner/work/dpdk/dpdk/doc/guides/vdpadevs/sfc.rst:document isn't
>included in any toctree "

Now including it in the toctree of vdpadevs/index.rst.

Regards,
Vijay