mbox series

[v4,0/8] port ioatfwd app to dmadev

Message ID 20211014095311.1311617-1-kevin.laatz@intel.com (mailing list archive)
Headers
Series port ioatfwd app to dmadev |

Message

Kevin Laatz Oct. 14, 2021, 9:53 a.m. UTC
  This patchset first adds some additional command line options to the
existing ioatfwd application to enhance usability.

The last 3 patches of this set then port the ioatfwd application to use the
dmadev library APIs instead of the IOAT rawdev APIs. Following the port,
all variables etc are renamed to be more appropriate for using with the
DMAdev library. Lastly, the application itself is renamed to "dmafwd".

Depends-on: series-19594 ("support dmadev")

---
v4:
  - rebase on dmadev lib v26 patchset
v3:
  - add signal-triggered device dump
  - add cmd line option to control stats print frequency
  - documentation updates
  - small miscellaneous changes from review feedback

Kevin Laatz (5):
  examples/ioat: add cmd line option to control stats print interval
  examples/ioat: add signal-triggered device dumps
  examples/ioat: port application to dmadev APIs
  examples/ioat: update naming to match change to dmadev
  examples/ioat: rename application to dmafwd

Konstantin Ananyev (3):
  examples/ioat: always use same lcore for both DMA requests enqueue and
    dequeue
  examples/ioat: add cmd line option to control DMA batch size
  examples/ioat: add cmd line option to control max frame size

 .../sample_app_ug/{ioat.rst => dma.rst}       | 149 ++---
 doc/guides/sample_app_ug/index.rst            |   2 +-
 doc/guides/sample_app_ug/intro.rst            |   4 +-
 examples/{ioat => dma}/Makefile               |   4 +-
 examples/{ioat/ioatfwd.c => dma/dmafwd.c}     | 632 ++++++++++--------
 examples/{ioat => dma}/meson.build            |  10 +-
 examples/meson.build                          |   2 +-
 7 files changed, 427 insertions(+), 376 deletions(-)
 rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (64%)
 rename examples/{ioat => dma}/Makefile (97%)
 rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (60%)
 rename examples/{ioat => dma}/meson.build (63%)
  

Comments

Thomas Monjalon Oct. 22, 2021, 7:48 p.m. UTC | #1
14/10/2021 11:53, Kevin Laatz:
> This patchset first adds some additional command line options to the
> existing ioatfwd application to enhance usability.

Please could you rebase?
I see some errors about max_rx_pkt_len and DEV_RX_OFFLOAD_JUMBO_FRAME.
Cc Ferruh for help if needed.
  
Kevin Laatz Oct. 25, 2021, 7:59 p.m. UTC | #2
On 22/10/2021 20:48, Thomas Monjalon wrote:
> 14/10/2021 11:53, Kevin Laatz:
>> This patchset first adds some additional command line options to the
>> existing ioatfwd application to enhance usability.
> Please could you rebase?
> I see some errors about max_rx_pkt_len and DEV_RX_OFFLOAD_JUMBO_FRAME.
> Cc Ferruh for help if needed.
>

I'll send a v5 with rebase and fix for this.

Thanks,
Kevin
  
fengchengwen Oct. 26, 2021, 12:56 a.m. UTC | #3
Hi Kevin,

We test whole patch set and found it should add one judgement:
the ring_size should be less than or equal to MBUF_RING_SIZE.
If ring_size greater than MBUF_RING_SIZE, the tracking DMA bufs
may be overwrited when the DMA copy is not in time.

Thanks.

On 2021/10/14 17:53, Kevin Laatz wrote:
> This patchset first adds some additional command line options to the
> existing ioatfwd application to enhance usability.
> 
> The last 3 patches of this set then port the ioatfwd application to use the
> dmadev library APIs instead of the IOAT rawdev APIs. Following the port,
> all variables etc are renamed to be more appropriate for using with the
> DMAdev library. Lastly, the application itself is renamed to "dmafwd".
> 
> Depends-on: series-19594 ("support dmadev")
> 
> ---
> v4:
>   - rebase on dmadev lib v26 patchset
> v3:
>   - add signal-triggered device dump
>   - add cmd line option to control stats print frequency
>   - documentation updates
>   - small miscellaneous changes from review feedback
> 
> Kevin Laatz (5):
>   examples/ioat: add cmd line option to control stats print interval
>   examples/ioat: add signal-triggered device dumps
>   examples/ioat: port application to dmadev APIs
>   examples/ioat: update naming to match change to dmadev
>   examples/ioat: rename application to dmafwd
> 
> Konstantin Ananyev (3):
>   examples/ioat: always use same lcore for both DMA requests enqueue and
>     dequeue
>   examples/ioat: add cmd line option to control DMA batch size
>   examples/ioat: add cmd line option to control max frame size
> 
>  .../sample_app_ug/{ioat.rst => dma.rst}       | 149 ++---
>  doc/guides/sample_app_ug/index.rst            |   2 +-
>  doc/guides/sample_app_ug/intro.rst            |   4 +-
>  examples/{ioat => dma}/Makefile               |   4 +-
>  examples/{ioat/ioatfwd.c => dma/dmafwd.c}     | 632 ++++++++++--------
>  examples/{ioat => dma}/meson.build            |  10 +-
>  examples/meson.build                          |   2 +-
>  7 files changed, 427 insertions(+), 376 deletions(-)
>  rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (64%)
>  rename examples/{ioat => dma}/Makefile (97%)
>  rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (60%)
>  rename examples/{ioat => dma}/meson.build (63%)
>
  
Kevin Laatz Oct. 26, 2021, 11:46 a.m. UTC | #4
On 26/10/2021 01:56, fengchengwen wrote:
> Hi Kevin,
>
> We test whole patch set and found it should add one judgement:
> the ring_size should be less than or equal to MBUF_RING_SIZE.
> If ring_size greater than MBUF_RING_SIZE, the tracking DMA bufs
> may be overwrited when the DMA copy is not in time.
>
> Thanks.
>

Thanks for testing, Chengwen. I'll include this check in the v5.

/Kevin