mbox series

[v12,0/2] testpmd shows incorrect rx_offload configuration

Message ID 20211012025417.134866-1-jie1x.wang@intel.com (mailing list archive)
Headers
Series testpmd shows incorrect rx_offload configuration |

Message

Jie Wang Oct. 12, 2021, 2:54 a.m. UTC
  Launch testpmd with multiple queues, and check rx_offload info.

When testpmd shows the port configuration, it doesn't show RSS_HASH.

---
v12: update the commit log and the API comment.
v11:
 - update the commit log.
 - rename the function and variable name.
v10:
 - update the commit log.
 - merge the first two patches.
 - rename the new API name.
v9:
 - add a release notes update for the new API.
 - update the description of the new API.
 - optimize the new API.
 - optimize the assignment of the offloads.
v8: delete "rte_exit" and just print error log.
v7:
 - delete struct "rte_eth_dev_conf_info", and reuse struct "rte_eth_conf".
 - add "__rte_experimental" to the new API "rte_eth_dev_conf_info_get" declaration.
v6: split this patch into two patches.
v5: add an API to get device configuration info.
v4: delete the whitespace at the end of the line.
v3:
 - check and update the "offloads" of "port->dev_conf.rx/txmode".
 - update the commit log.
v2: copy "rx/txmode.offloads", instead of copying the entire struct
"dev->data->dev_conf.rx/txmode".

Jie Wang (2):
  ethdev: add an API to get device configuration
  app/testpmd: fix testpmd doesn't show RSS hash offload

 app/test-pmd/cmdline.c                 | 14 +++++++++--
 app/test-pmd/testpmd.c                 | 33 ++++++++++++++++++++++++++
 app/test-pmd/testpmd.h                 |  2 ++
 app/test-pmd/util.c                    | 14 +++++++++++
 doc/guides/rel_notes/release_21_11.rst |  4 ++++
 lib/ethdev/rte_ethdev.c                | 20 ++++++++++++++++
 lib/ethdev/rte_ethdev.h                | 20 ++++++++++++++++
 lib/ethdev/version.map                 |  3 +++
 8 files changed, 108 insertions(+), 2 deletions(-)
  

Comments

Ferruh Yigit Oct. 12, 2021, 2:35 p.m. UTC | #1
On 10/12/2021 3:54 AM, Jie Wang wrote:
> Launch testpmd with multiple queues, and check rx_offload info.
> 
> When testpmd shows the port configuration, it doesn't show RSS_HASH.
> 
> ---
> v12: update the commit log and the API comment.
> v11:
>   - update the commit log.
>   - rename the function and variable name.
> v10:
>   - update the commit log.
>   - merge the first two patches.
>   - rename the new API name.
> v9:
>   - add a release notes update for the new API.
>   - update the description of the new API.
>   - optimize the new API.
>   - optimize the assignment of the offloads.
> v8: delete "rte_exit" and just print error log.
> v7:
>   - delete struct "rte_eth_dev_conf_info", and reuse struct "rte_eth_conf".
>   - add "__rte_experimental" to the new API "rte_eth_dev_conf_info_get" declaration.
> v6: split this patch into two patches.
> v5: add an API to get device configuration info.
> v4: delete the whitespace at the end of the line.
> v3:
>   - check and update the "offloads" of "port->dev_conf.rx/txmode".
>   - update the commit log.
> v2: copy "rx/txmode.offloads", instead of copying the entire struct
> "dev->data->dev_conf.rx/txmode".
> 
> Jie Wang (2):
>    ethdev: add an API to get device configuration
>    app/testpmd: fix testpmd doesn't show RSS hash offload
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>