mbox series

[v2,0/4] net/tap: fix Rx cksum

Message ID 20210630135158.8108-1-olivier.matz@6wind.com (mailing list archive)
Headers
Series net/tap: fix Rx cksum |

Message

Olivier Matz June 30, 2021, 1:51 p.m. UTC 
  This patchset fixes the Rx checksum flags in net/tap
driver. The first two patches are the effective fixes.

The last 2 patches introduce a new checksum API to
verify a L4 checksum and its unt test, in order to
simplify the net/tap code, or any other code that has
the same needs.

v2:

* clarify why RTE_PTYPE_L3_IPV4_EXT_UNKNOWN cannot happen in
  tap_verify_csum() (patch 1)
* align style of rte_ipv6_udptcp_cksum_verify() to
  rte_ipv4_udptcp_cksum_verify() (patch 3)
* clarify comment above rte_ipv4_udptcp_cksum_verify() and
  rte_ipv6_udptcp_cksum_verify() (patch 3)


Olivier Matz (4):
  net/tap: fix Rx cksum flags on IP options packets
  net/tap: fix Rx cksum flags on TCP packets
  net: introduce functions to verify L4 checksums
  test/cksum: new test for L3/L4 checksum API

 MAINTAINERS                   |   1 +
 app/test/autotest_data.py     |   6 +
 app/test/meson.build          |   2 +
 app/test/test_cksum.c         | 271 ++++++++++++++++++++++++++++++++++
 drivers/net/tap/rte_eth_tap.c |  23 ++-
 lib/net/rte_ip.h              | 127 +++++++++++++---
 6 files changed, 398 insertions(+), 32 deletions(-)
 create mode 100644 app/test/test_cksum.c

Comments

Andrew Rybchenko July 1, 2021, 9:28 a.m. UTC | #1 
On 6/30/21 4:51 PM, Olivier Matz wrote:
> This patchset fixes the Rx checksum flags in net/tap
> driver. The first two patches are the effective fixes.
> 
> The last 2 patches introduce a new checksum API to
> verify a L4 checksum and its unt test, in order to
> simplify the net/tap code, or any other code that has
> the same needs.
> 
> v2:
> 
> * clarify why RTE_PTYPE_L3_IPV4_EXT_UNKNOWN cannot happen in
>   tap_verify_csum() (patch 1)
> * align style of rte_ipv6_udptcp_cksum_verify() to
>   rte_ipv4_udptcp_cksum_verify() (patch 3)
> * clarify comment above rte_ipv4_udptcp_cksum_verify() and
>   rte_ipv6_udptcp_cksum_verify() (patch 3)
> 
> 
> Olivier Matz (4):
>   net/tap: fix Rx cksum flags on IP options packets
>   net/tap: fix Rx cksum flags on TCP packets
>   net: introduce functions to verify L4 checksums
>   test/cksum: new test for L3/L4 checksum API
> 
>  MAINTAINERS                   |   1 +
>  app/test/autotest_data.py     |   6 +
>  app/test/meson.build          |   2 +
>  app/test/test_cksum.c         | 271 ++++++++++++++++++++++++++++++++++
>  drivers/net/tap/rte_eth_tap.c |  23 ++-
>  lib/net/rte_ip.h              | 127 +++++++++++++---
>  6 files changed, 398 insertions(+), 32 deletions(-)
>  create mode 100644 app/test/test_cksum.c
> 

Series-reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied, thanks.