[v4,00/19] net/ena: update ENA PMD to v2.3.0

  Hi,

this version updates the driver to version 2.3.0, which fixes multiple
bugs, contains part of the work on making the ENA PMD fully MP aware, and
also updates HAL to the latest version.

More detailed list of changes:
  * memcpy mapping to the dpdk-optimized version.
  * ena_com (HAL) update to the latest version.
  * Bug fixes for the large LLQ headers and devargs parsing.
  * Mbuf RSS hash presence indication.
  * Bug fix for the default ring size.
  * Various fixes for the SMP mode.

v4:
* Remove patches adding shared memory for SMP:
  - net/ena: move default RSS key to shared mem
  - net/ena: support SMP for mz alloc counter
* Move release notes to the related patches.
* Squash HAL version update patch with the same commit for the core driver.
* Change names fo the macros arguments in the "net/ena/base: destroy multiple
  "wait events" patch.
* Removed call to the rte_panic().
* Squashed ena_com version update with the driver version update.
* Fix multiple checkpatch warnings.
* Fix issues found in the commit logs.

v3:
* Fix build of the PMD with the debug flags enabled.
* Fix typo in the commit log of the version upgrade patch.

v2:
* Fix nested declaration of the rte_memcpy on arm64 architecture.

Amit Bernstein (1):
  net/ena/base: adjust changes to lastest ena-com

Igor Chauskin (2):
  net/ena: switch memcpy to dpdk-optimized version
  net/ena: fix parsing of large LLQ header devarg

Michal Krawczyk (11):
  net/ena/base: unify arg names for the functions
  net/ena/base: add dev arg to the logging macros
  net/ena/base: style and comments improvements
  net/ena/base: fix issues from the static code scan
  net/ena/base: destroy multiple "wait events"
  net/ena/base: remove indir table from ENA feat ctx
  net/ena/base: remove mutable RSS from the host info
  net/ena/base: use rte prefetch0 write
  net/ena: terminate devargs allowed keys with null
  net/ena: indicate Rx RSS hash presence
  net/ena: update version to v2.3.0

Stanislaw Kardach (5):
  net/ena: remove endian swap functions
  net/ena: handle spurious wakeups in ENA wait event
  net/ena: make ethdev references SMP safe
  net/ena: disable dev ops not supported in SMP
  net/ena: report default ring size

 doc/guides/rel_notes/release_21_05.rst        |  11 +
 drivers/net/ena/base/ena_com.c                | 379 +++++++++---------
 drivers/net/ena/base/ena_com.h                |  24 +-
 .../net/ena/base/ena_defs/ena_admin_defs.h    |  98 ++---
 drivers/net/ena/base/ena_defs/ena_gen_info.h  |   4 +-
 drivers/net/ena/base/ena_eth_com.c            |  94 +++--
 drivers/net/ena/base/ena_eth_com.h            |  17 +-
 drivers/net/ena/base/ena_plat_dpdk.h          | 337 ++++++++--------
 drivers/net/ena/ena_ethdev.c                  | 124 +++---
 drivers/net/ena/ena_ethdev.h                  |   5 +-
 drivers/net/ena/ena_platform.h                |  12 -
 11 files changed, 600 insertions(+), 505 deletions(-)
  

On 5/11/2021 7:45 AM, Michal Krawczyk wrote:
> Hi,
> 
> this version updates the driver to version 2.3.0, which fixes multiple
> bugs, contains part of the work on making the ENA PMD fully MP aware, and
> also updates HAL to the latest version.
> 
> More detailed list of changes:
>   * memcpy mapping to the dpdk-optimized version.
>   * ena_com (HAL) update to the latest version.
>   * Bug fixes for the large LLQ headers and devargs parsing.
>   * Mbuf RSS hash presence indication.
>   * Bug fix for the default ring size.
>   * Various fixes for the SMP mode.
> 
> v4:
> * Remove patches adding shared memory for SMP:
>   - net/ena: move default RSS key to shared mem
>   - net/ena: support SMP for mz alloc counter
> * Move release notes to the related patches.
> * Squash HAL version update patch with the same commit for the core driver.
> * Change names fo the macros arguments in the "net/ena/base: destroy multiple
>   "wait events" patch.
> * Removed call to the rte_panic().
> * Squashed ena_com version update with the driver version update.
> * Fix multiple checkpatch warnings.
> * Fix issues found in the commit logs.
> 
> v3:
> * Fix build of the PMD with the debug flags enabled.
> * Fix typo in the commit log of the version upgrade patch.
> 
> v2:
> * Fix nested declaration of the rte_memcpy on arm64 architecture.
> 
> Amit Bernstein (1):
>   net/ena/base: adjust changes to lastest ena-com
> 
> Igor Chauskin (2):
>   net/ena: switch memcpy to dpdk-optimized version
>   net/ena: fix parsing of large LLQ header devarg
> 
> Michal Krawczyk (11):
>   net/ena/base: unify arg names for the functions
>   net/ena/base: add dev arg to the logging macros
>   net/ena/base: style and comments improvements
>   net/ena/base: fix issues from the static code scan
>   net/ena/base: destroy multiple "wait events"
>   net/ena/base: remove indir table from ENA feat ctx
>   net/ena/base: remove mutable RSS from the host info
>   net/ena/base: use rte prefetch0 write
>   net/ena: terminate devargs allowed keys with null
>   net/ena: indicate Rx RSS hash presence
>   net/ena: update version to v2.3.0
> 
> Stanislaw Kardach (5):
>   net/ena: remove endian swap functions
>   net/ena: handle spurious wakeups in ENA wait event
>   net/ena: make ethdev references SMP safe
>   net/ena: disable dev ops not supported in SMP
>   net/ena: report default ring size
> 

Hi Michal,

I put some comments on 13,16,17/19 but merging rest, can you please send a new
version for those three patches separately, on top of latest head?

Also can you please double check if anything is missed/wrong in the merged ones
because of rebasing.

Except 13,16,17/19,
Series applied to dpdk-next-net/main, thanks.
  

wt., 11 maj 2021 o 15:07 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>
> On 5/11/2021 7:45 AM, Michal Krawczyk wrote:
> > Hi,
> >
> > this version updates the driver to version 2.3.0, which fixes multiple
> > bugs, contains part of the work on making the ENA PMD fully MP aware, and
> > also updates HAL to the latest version.
> >
> > More detailed list of changes:
> >   * memcpy mapping to the dpdk-optimized version.
> >   * ena_com (HAL) update to the latest version.
> >   * Bug fixes for the large LLQ headers and devargs parsing.
> >   * Mbuf RSS hash presence indication.
> >   * Bug fix for the default ring size.
> >   * Various fixes for the SMP mode.
> >
> > v4:
> > * Remove patches adding shared memory for SMP:
> >   - net/ena: move default RSS key to shared mem
> >   - net/ena: support SMP for mz alloc counter
> > * Move release notes to the related patches.
> > * Squash HAL version update patch with the same commit for the core driver.
> > * Change names fo the macros arguments in the "net/ena/base: destroy multiple
> >   "wait events" patch.
> > * Removed call to the rte_panic().
> > * Squashed ena_com version update with the driver version update.
> > * Fix multiple checkpatch warnings.
> > * Fix issues found in the commit logs.
> >
> > v3:
> > * Fix build of the PMD with the debug flags enabled.
> > * Fix typo in the commit log of the version upgrade patch.
> >
> > v2:
> > * Fix nested declaration of the rte_memcpy on arm64 architecture.
> >
> > Amit Bernstein (1):
> >   net/ena/base: adjust changes to lastest ena-com
> >
> > Igor Chauskin (2):
> >   net/ena: switch memcpy to dpdk-optimized version
> >   net/ena: fix parsing of large LLQ header devarg
> >
> > Michal Krawczyk (11):
> >   net/ena/base: unify arg names for the functions
> >   net/ena/base: add dev arg to the logging macros
> >   net/ena/base: style and comments improvements
> >   net/ena/base: fix issues from the static code scan
> >   net/ena/base: destroy multiple "wait events"
> >   net/ena/base: remove indir table from ENA feat ctx
> >   net/ena/base: remove mutable RSS from the host info
> >   net/ena/base: use rte prefetch0 write
> >   net/ena: terminate devargs allowed keys with null
> >   net/ena: indicate Rx RSS hash presence
> >   net/ena: update version to v2.3.0
> >
> > Stanislaw Kardach (5):
> >   net/ena: remove endian swap functions
> >   net/ena: handle spurious wakeups in ENA wait event
> >   net/ena: make ethdev references SMP safe
> >   net/ena: disable dev ops not supported in SMP
> >   net/ena: report default ring size
> >
>
> Hi Michal,
>
> I put some comments on 13,16,17/19 but merging rest, can you please send a new
> version for those three patches separately, on top of latest head?
>

Hi Ferruh,

thanks a lot for a review and merge!

Sure, I'll send the new version separately, rebased on the head.

> Also can you please double check if anything is missed/wrong in the merged ones
> because of rebasing.
>

Checked - everything is fine.

> Except 13,16,17/19,
> Series applied to dpdk-next-net/main, thanks.

Thanks,
Michal