mbox series

[v3,0/4] Offload flags fixes

Message ID 20210503132646.16076-1-david.marchand@redhat.com (mailing list archive)
Headers
Series Offload flags fixes |

Message

David Marchand May 3, 2021, 1:26 p.m. UTC 
  The important part is the last patch on vhost handling of offloading
requests coming from a virtio guest interface.

The rest are small fixes that I accumulated while reviewing the mbuf
offload flags.

On this last patch, it has the potential of breaking existing
applications using the vhost library (OVS being impacted).
I did not mark it for backport.

Changes since v2:
- kept behavior untouched (to avoid breaking ABI) and introduced a new
  flag to select the new behavior,

Changes since v1:
- dropped patch on net/tap,
- added missing bits in example/vhost,
- relaxed checks on VIRTIO_NET_HDR_GSO_ECN and VIRTIO_NET_HDR_GSO_UDP,

Comments

Maxime Coquelin May 3, 2021, 3:24 p.m. UTC | #1 
Hi David,

On 5/3/21 3:26 PM, David Marchand wrote:
> The important part is the last patch on vhost handling of offloading
> requests coming from a virtio guest interface.
> 
> The rest are small fixes that I accumulated while reviewing the mbuf
> offload flags.
> 
> On this last patch, it has the potential of breaking existing
> applications using the vhost library (OVS being impacted).
> I did not mark it for backport.
> 
> Changes since v2:
> - kept behavior untouched (to avoid breaking ABI) and introduced a new
>   flag to select the new behavior,
> 
> Changes since v1:
> - dropped patch on net/tap,
> - added missing bits in example/vhost,
> - relaxed checks on VIRTIO_NET_HDR_GSO_ECN and VIRTIO_NET_HDR_GSO_UDP,
> 

Patch 4 does not apply on top of next-virtio/main branch.
Could you please send a rebased version?

Thanks,
Maxime
David Marchand May 3, 2021, 4:21 p.m. UTC | #2 
On Mon, May 3, 2021 at 5:24 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> On 5/3/21 3:26 PM, David Marchand wrote:
> > The important part is the last patch on vhost handling of offloading
> > requests coming from a virtio guest interface.
> >
> > The rest are small fixes that I accumulated while reviewing the mbuf
> > offload flags.
> >
> > On this last patch, it has the potential of breaking existing
> > applications using the vhost library (OVS being impacted).
> > I did not mark it for backport.
> >
> > Changes since v2:
> > - kept behavior untouched (to avoid breaking ABI) and introduced a new
> >   flag to select the new behavior,
> >
> > Changes since v1:
> > - dropped patch on net/tap,
> > - added missing bits in example/vhost,
> > - relaxed checks on VIRTIO_NET_HDR_GSO_ECN and VIRTIO_NET_HDR_GSO_UDP,
> >
>
> Patch 4 does not apply on top of next-virtio/main branch.
> Could you please send a rebased version?

The conflict is with Balazs rework.
Ok, preparing v4.