mbox series

[v5,0/1] eal/interrupts: add synchronous wrapper around unregister

Message ID 20210406144614.3394-1-Renata.Saiakhova@ekinops.com (mailing list archive)
Headers show
Series eal/interrupts: add synchronous wrapper around unregister | expand

Message

Renata Saiakhova April 6, 2021, 2:46 p.m. UTC
For pci_vfio, while removing the device by rte_dev_remove(),
pci_vfio_disable_notifier() will call rte_intr_callback_unregister(),
which may return -EAGAIN, if an interrupt source (kernel) has some active
callbacks right now. As a result, the callback (req notifier) can be never unregistered,
and the corresponding descriptor (vfio_req_intr_handle.fd) can be never closed.
The kernel will continuously try to notify the user space using req notifier, but as
the device is already removed, in this case it even cannot find a bus for that
device, the log is full of messages "EAL: Cannot find bus for device (XX:XX.X)"

v5:
  Re-spin with windows update and 21.05 edition
v4:
* Typo spelling in commit message
v3:
* Subject line reworded
v2:
* Use only for pci-vfio in pci_vfio_disable_notifier()

Renata Saiakhova (1):
  eal/interrupts: add synchronous wrapper around unregister

 drivers/bus/pci/linux/pci_vfio.c        |  2 +-
 lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++
 lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++
 lib/librte_eal/linux/eal_interrupts.c   | 12 ++++++++++++
 lib/librte_eal/version.map              |  1 +
 lib/librte_eal/windows/eal_interrupts.c |  8 ++++++++
 6 files changed, 59 insertions(+), 1 deletion(-)