mbox series

[v6,0/8] ether: refine debug build option

Message ID 20210331095254.2454439-1-qi.z.zhang@intel.com (mailing list archive)
Headers show
Series ether: refine debug build option | expand

Message

Zhang, Qi Z March 31, 2021, 9:52 a.m. UTC
PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as build option to wrap
data path debug code. As .config has been removed since the meson build,
It is not friendly for new DPDK users to notice those debug options.

Patch 1/8: introduces new compile options for data path debug in ether
layer, PMD can choose to reuse them to avoid maintain their own.

- RTE_ETHDEV_DEBUG_RX
- RTE_ETHDEV_DEBUG_TX

The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to
both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward
compatibility.

Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the
new build options

v6:
- fix build issue for -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1"
- s/compile/build/  

v5:
- Remove RTE_ETHDEV_DEBUG
- Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG_RX|TX for backward
  compatibility.

v4:
- Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG in ethdev library
  for backward compatibility.
- Not replace RTE_LIBRTE_ETHDEV_DEBUG in all PMDs.

v3:
- rename "RTE_LIBRTE_ETHDEV_xxx" to "RTE_ETHDEV_xxx"
- move document from "overview.rst" page to "build_and_test.rst"
- fix grammar issues.

v2:
- fix some coding style issues.


Qi Zhang (8):
  ether: refine debug build option
  net/fm10k: refine debug build option
  net/e1000: refine debug build option
  net/i40e: refine debug build option
  net/iavf: refine debug build option
  net/ice: refine debug build option
  net/ixgbe: refine debug build option
  net/igc: refine debug build option

 doc/guides/nics/build_and_test.rst | 16 ++++++++
 drivers/net/e1000/e1000_logs.c     | 18 +++------
 drivers/net/e1000/e1000_logs.h     | 13 +-----
 drivers/net/e1000/em_rxtx.c        | 38 +++++++++---------
 drivers/net/e1000/igb_rxtx.c       |  2 +-
 drivers/net/fm10k/fm10k_ethdev.c   |  7 +---
 drivers/net/fm10k/fm10k_logs.h     | 13 +-----
 drivers/net/fm10k/fm10k_rxtx.c     |  8 ++--
 drivers/net/i40e/i40e_ethdev.c     |  7 +---
 drivers/net/i40e/i40e_logs.h       | 13 +-----
 drivers/net/i40e/i40e_rxtx.c       | 16 ++++----
 drivers/net/iavf/iavf_ethdev.c     |  7 +---
 drivers/net/iavf/iavf_log.h        | 13 +-----
 drivers/net/iavf/iavf_rxtx.c       |  8 ++--
 drivers/net/ice/ice_ethdev.c       |  7 +---
 drivers/net/ice/ice_logs.h         | 13 +-----
 drivers/net/ice/ice_rxtx.c         | 20 +++++-----
 drivers/net/igc/igc_logs.h         |  4 +-
 drivers/net/igc/igc_txrx.c         |  2 +-
 drivers/net/ixgbe/ixgbe_ethdev.c   |  7 +---
 drivers/net/ixgbe/ixgbe_logs.h     | 13 +-----
 drivers/net/ixgbe/ixgbe_rxtx.c     | 64 +++++++++++++++---------------
 lib/librte_ethdev/rte_ethdev.h     | 22 ++++++----
 23 files changed, 138 insertions(+), 193 deletions(-)

Comments

Ferruh Yigit April 1, 2021, 2:11 p.m. UTC | #1
On 3/31/2021 10:52 AM, Qi Zhang wrote:
> PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as build option to wrap
> data path debug code. As .config has been removed since the meson build,
> It is not friendly for new DPDK users to notice those debug options.
> 
> Patch 1/8: introduces new compile options for data path debug in ether
> layer, PMD can choose to reuse them to avoid maintain their own.
> 
> - RTE_ETHDEV_DEBUG_RX
> - RTE_ETHDEV_DEBUG_TX
> 
> The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to
> both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward
> compatibility.
> 
> Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the
> new build options
> 
> v6:
> - fix build issue for -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1"
> - s/compile/build/
> 
> v5:
> - Remove RTE_ETHDEV_DEBUG
> - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG_RX|TX for backward
>    compatibility.
> 
> v4:
> - Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG in ethdev library
>    for backward compatibility.
> - Not replace RTE_LIBRTE_ETHDEV_DEBUG in all PMDs.
> 
> v3:
> - rename "RTE_LIBRTE_ETHDEV_xxx" to "RTE_ETHDEV_xxx"
> - move document from "overview.rst" page to "build_and_test.rst"
> - fix grammar issues.
> 
> v2:
> - fix some coding style issues.
> 
> 
> Qi Zhang (8):
>    ether: refine debug build option
>    net/fm10k: refine debug build option
>    net/e1000: refine debug build option
>    net/i40e: refine debug build option
>    net/iavf: refine debug build option
>    net/ice: refine debug build option
>    net/ixgbe: refine debug build option
>    net/igc: refine debug build option
> 

For series,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied to dpdk-next-net/main, thanks.