mbox series

[v2,0/7] txgbe backplane AN training

Message ID 20210316105149.110904-1-jiawenwu@trustnetic.com (mailing list archive)
Headers
Series txgbe backplane AN training |

Message

Jiawen Wu March 16, 2021, 10:51 a.m. UTC
  This series update link process for backplane NICs.
And support to control AN training.

v2:
- Convert compile time flags to runtime options
- Move firmware version get operation to base code
- Fix minor bugs

Jiawen Wu (7):
  net/txgbe: update device ID
  net/txgbe: add device arguments
  net/txgbe: move firmware version get function to base code
  net/txgbe: update link setup process of backplane NICs
  net/txgbe/base: support to handle backplane AN73 flow
  net/txgbe: handle AN interrupt and link update
  net/txgbe: add FFE parameters for user debugging

 doc/guides/nics/txgbe.rst             |  50 ++
 drivers/net/txgbe/base/txgbe_devids.h |  44 +-
 drivers/net/txgbe/base/txgbe_dummy.h  |   6 +
 drivers/net/txgbe/base/txgbe_eeprom.h |   3 +
 drivers/net/txgbe/base/txgbe_hw.c     | 160 ++----
 drivers/net/txgbe/base/txgbe_osdep.h  |   1 +
 drivers/net/txgbe/base/txgbe_phy.c    | 760 +++++++++++++++++++++++---
 drivers/net/txgbe/base/txgbe_phy.h    | 107 +++-
 drivers/net/txgbe/base/txgbe_type.h   |  51 +-
 drivers/net/txgbe/txgbe_ethdev.c      | 134 ++++-
 drivers/net/txgbe/txgbe_ethdev.h      |   7 +-
 drivers/net/txgbe/txgbe_ethdev_vf.c   |   4 +-
 drivers/net/txgbe/txgbe_logs.h        |  10 +
 13 files changed, 1113 insertions(+), 224 deletions(-)
  

Comments

Ferruh Yigit March 23, 2021, 5:33 p.m. UTC | #1
On 3/16/2021 10:51 AM, Jiawen Wu wrote:
> This series update link process for backplane NICs.
> And support to control AN training.
> 
> v2:
> - Convert compile time flags to runtime options
> - Move firmware version get operation to base code
> - Fix minor bugs
> 
> Jiawen Wu (7):
>    net/txgbe: update device ID
>    net/txgbe: add device arguments
>    net/txgbe: move firmware version get function to base code
>    net/txgbe: update link setup process of backplane NICs
>    net/txgbe/base: support to handle backplane AN73 flow
>    net/txgbe: handle AN interrupt and link update
>    net/txgbe: add FFE parameters for user debugging
> 

Hi Jiawen,

Overall set looks good, just to double check, is there anything to update in the 
release notes, can briefly mention from new device args perhaps?
  
Jiawen Wu March 24, 2021, 1:57 a.m. UTC | #2
On March 24, 2021 1:33 AM, Ferruh Yigit wrote:
> On 3/16/2021 10:51 AM, Jiawen Wu wrote:
> > This series update link process for backplane NICs.
> > And support to control AN training.
> >
> > v2:
> > - Convert compile time flags to runtime options
> > - Move firmware version get operation to base code
> > - Fix minor bugs
> >
> > Jiawen Wu (7):
> >    net/txgbe: update device ID
> >    net/txgbe: add device arguments
> >    net/txgbe: move firmware version get function to base code
> >    net/txgbe: update link setup process of backplane NICs
> >    net/txgbe/base: support to handle backplane AN73 flow
> >    net/txgbe: handle AN interrupt and link update
> >    net/txgbe: add FFE parameters for user debugging
> >
> 
> Hi Jiawen,
> 
> Overall set looks good, just to double check, is there anything to update in the
> release notes, can briefly mention from new device args perhaps?

Yeah, it should be.
I'd like to update the release notes in an individual patch, would it be appropriate?
  
Ferruh Yigit March 24, 2021, 10:36 a.m. UTC | #3
On 3/24/2021 1:57 AM, Jiawen Wu wrote:
> On March 24, 2021 1:33 AM, Ferruh Yigit wrote:
>> On 3/16/2021 10:51 AM, Jiawen Wu wrote:
>>> This series update link process for backplane NICs.
>>> And support to control AN training.
>>>
>>> v2:
>>> - Convert compile time flags to runtime options
>>> - Move firmware version get operation to base code
>>> - Fix minor bugs
>>>
>>> Jiawen Wu (7):
>>>     net/txgbe: update device ID
>>>     net/txgbe: add device arguments
>>>     net/txgbe: move firmware version get function to base code
>>>     net/txgbe: update link setup process of backplane NICs
>>>     net/txgbe/base: support to handle backplane AN73 flow
>>>     net/txgbe: handle AN interrupt and link update
>>>     net/txgbe: add FFE parameters for user debugging
>>>
>>
>> Hi Jiawen,
>>
>> Overall set looks good, just to double check, is there anything to update in the
>> release notes, can briefly mention from new device args perhaps?
> 
> Yeah, it should be.
> I'd like to update the release notes in an individual patch, would it be appropriate?
> 

It is preferred to have the doc update with the actual functional change patch, 
I see you have sent the doc as separate patch, I can squash it while merging.