mbox series

[0/4] bug fixes for txgbe

Message ID 20210304100700.17888-1-jiawenwu@trustnetic.com (mailing list archive)
Headers show
Series bug fixes for txgbe | expand

Message

Jiawen Wu March 4, 2021, 10:06 a.m. UTC
This series fix some bugs and remove unused functions.

Jiawen Wu (4):
  net/txgbe: remove unused functions
  net/txgbe: fix Rx missed packet counter
  net/txgbe: update packet type
  net/txgbe: fix the process of adding crypto SA

 drivers/net/txgbe/base/txgbe_eeprom.c | 76 +--------------------------
 drivers/net/txgbe/base/txgbe_eeprom.h |  2 -
 drivers/net/txgbe/base/txgbe_type.h   |  1 +
 drivers/net/txgbe/txgbe_ethdev.c      |  4 +-
 drivers/net/txgbe/txgbe_ipsec.c       |  6 +--
 drivers/net/txgbe/txgbe_ptypes.c      |  4 +-
 6 files changed, 12 insertions(+), 81 deletions(-)

Comments

Ferruh Yigit March 4, 2021, 4:48 p.m. UTC | #1
On 3/4/2021 10:06 AM, Jiawen Wu wrote:
> This series fix some bugs and remove unused functions.
> 
> Jiawen Wu (4):
>    net/txgbe: remove unused functions
>    net/txgbe: fix Rx missed packet counter
>    net/txgbe: update packet type
>    net/txgbe: fix the process of adding crypto SA
> 

Hi Jiawen,

Can you please add fixes line for all of them?
So that LTS maintainers can figure out where to backport the ones that can be 
backported.

Fixes line is commit that introduces the issue fixed by that commit. It has a 
defined syntax which can be get via a git alias:
git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'"

(as documented in 
"https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body")
Jiawen Wu March 5, 2021, 1:48 a.m. UTC | #2
On Friday, March 5, 2021 12:49 AM, Ferruh Yigit wrote:
> On 3/4/2021 10:06 AM, Jiawen Wu wrote:
> > This series fix some bugs and remove unused functions.
> >
> > Jiawen Wu (4):
> >    net/txgbe: remove unused functions
> >    net/txgbe: fix Rx missed packet counter
> >    net/txgbe: update packet type
> >    net/txgbe: fix the process of adding crypto SA
> >
> 
> Hi Jiawen,
> 
> Can you please add fixes line for all of them?
> So that LTS maintainers can figure out where to backport the ones that can be
> backported.
> 
> Fixes line is commit that introduces the issue fixed by that commit. It has a
> defined syntax which can be get via a git alias:
> git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h
> (\"%s\")%nCc: %ae'"
> 
> (as documented in
> "https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-bo
> dy")

Ok, I will add it.
Thanks for the guidance.