mbox series

[v3,0/6] Refactor FDIR pattern parser

Message ID 20210302025407.1197434-1-zhirun.yan@intel.com (mailing list archive)
Headers show
Series Refactor FDIR pattern parser | expand

Message

Zhirun Yan March 2, 2021, 2:54 a.m. UTC
V3:
Clear the variable name of input_set_o and input_set_i.
Use input_set_o for tunnerl outer or non-tunnel fields, let
ice_pattern_match_item 3rd columns all none in ACL, RSS, switch.
Add new patch to use seg_tun[1] to record tunnel inner part.
Add new patch to clean GTPU inner flow type for PF.


V2:

Meld patch 4,5 into 3.
Update ACL input set.
Clear PPPoE GTPU input set in RSS.
Put p_v4/6 assignment earlier to reduce redundant code in FDIR.




This patch set refactor FDIR pattern parser.

Redefine input set. Ignore the redundant inner/outer info.
Align the parser action with hardware, using input_set_f for outer,
input_set_l for inner or non-tunnel fields.
Adjust indentation for easy review.
Enable VXLAN inner/outer fields.

Zhirun Yan (6):
  net/ice: clean input set macro definition
  net/ice: refactor structure field
  net/ice: refactor flow pattern parser
  net/ice: refactor input set conf
  net/ice: add outer input set mask to distinguish outer fields
  net/ice: clean GTPU flow_type for FDIR

 drivers/net/ice/ice_acl_filter.c    |  10 +-
 drivers/net/ice/ice_ethdev.h        |   4 +-
 drivers/net/ice/ice_fdir_filter.c   | 590 ++++++++++++++--------------
 drivers/net/ice/ice_generic_flow.c  |   6 +-
 drivers/net/ice/ice_generic_flow.h  | 237 +++++------
 drivers/net/ice/ice_hash.c          | 214 +++++-----
 drivers/net/ice/ice_switch_filter.c | 296 +++++---------
 7 files changed, 605 insertions(+), 752 deletions(-)

Comments

Zhang, Qi Z March 5, 2021, 8:46 a.m. UTC | #1
> -----Original Message-----
> From: Yan, Zhirun <zhirun.yan@intel.com>
> Sent: Tuesday, March 2, 2021 10:54 AM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Cao, Yahui
> <yahui.cao@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>; Guo,
> Junfeng <junfeng.guo@intel.com>
> Cc: Su, Simei <simei.su@intel.com>; Xu, Ting <ting.xu@intel.com>; Zhang,
> Yuying <yuying.zhang@intel.com>; Ding, Xuan <xuan.ding@intel.com>; Yan,
> Zhirun <zhirun.yan@intel.com>
> Subject: [PATCH v3 0/6] Refactor FDIR pattern parser
> 
> V3:
> Clear the variable name of input_set_o and input_set_i.
> Use input_set_o for tunnerl outer or non-tunnel fields, let
> ice_pattern_match_item 3rd columns all none in ACL, RSS, switch.
> Add new patch to use seg_tun[1] to record tunnel inner part.
> Add new patch to clean GTPU inner flow type for PF.
> 
> 
> V2:
> 
> Meld patch 4,5 into 3.
> Update ACL input set.
> Clear PPPoE GTPU input set in RSS.
> Put p_v4/6 assignment earlier to reduce redundant code in FDIR.
> 
> 
> 
> 
> This patch set refactor FDIR pattern parser.
> 
> Redefine input set. Ignore the redundant inner/outer info.
> Align the parser action with hardware, using input_set_f for outer, input_set_l
> for inner or non-tunnel fields.
> Adjust indentation for easy review.
> Enable VXLAN inner/outer fields.
> 
> Zhirun Yan (6):
>   net/ice: clean input set macro definition
>   net/ice: refactor structure field
>   net/ice: refactor flow pattern parser
>   net/ice: refactor input set conf
>   net/ice: add outer input set mask to distinguish outer fields
>   net/ice: clean GTPU flow_type for FDIR
> 
>  drivers/net/ice/ice_acl_filter.c    |  10 +-
>  drivers/net/ice/ice_ethdev.h        |   4 +-
>  drivers/net/ice/ice_fdir_filter.c   | 590 ++++++++++++++--------------
>  drivers/net/ice/ice_generic_flow.c  |   6 +-
>  drivers/net/ice/ice_generic_flow.h  | 237 +++++------
>  drivers/net/ice/ice_hash.c          | 214 +++++-----
>  drivers/net/ice/ice_switch_filter.c | 296 +++++---------
>  7 files changed, 605 insertions(+), 752 deletions(-)
> 
> --
> 2.25.1


Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi