mbox series

[0/3] Add developer mode to DPDK build

Message ID 20210225152903.148347-1-bruce.richardson@intel.com (mailing list archive)
Headers show
Series Add developer mode to DPDK build | expand

Message

Bruce Richardson Feb. 25, 2021, 3:29 p.m. UTC
To allow more flexibility in enabling additional build checks to DPDK build
process, we can add a developer mode option to the build. With this option
enabled, extra checks of interest to DPDK developers rather than users can be
done on the code, without having to worry about possible user impacts. The new
option can be manually enabled or disabled by using meson configure, but by
default is set to "auto" which means it is enabled if building from a git repo.

Once the developer mode is added in the first patch, the other patches of this
series turn off a number of previous features for non-developer builds, since
those features would only be of interest to DPDK devs.

Bruce Richardson (3):
  build: enable a developer mode setting
  build: hide debug messages in non-developer mode
  build: limit symbol checks to developer mode

 doc/guides/contributing/coding_style.rst |  8 ++++++++
 drivers/meson.build                      | 26 ++++++++++++++----------
 lib/meson.build                          | 12 ++++++-----
 meson.build                              | 14 +++++++++++++
 meson_options.txt                        |  2 ++
 5 files changed, 46 insertions(+), 16 deletions(-)

--
2.27.0

Comments

Thomas Monjalon Feb. 25, 2021, 7:50 p.m. UTC | #1
25/02/2021 16:29, Bruce Richardson:
> To allow more flexibility in enabling additional build checks to DPDK build
> process, we can add a developer mode option to the build. With this option
> enabled, extra checks of interest to DPDK developers rather than users can be
> done on the code, without having to worry about possible user impacts. The new
> option can be manually enabled or disabled by using meson configure, but by
> default is set to "auto" which means it is enabled if building from a git repo.
> 
> Once the developer mode is added in the first patch, the other patches of this
> series turn off a number of previous features for non-developer builds, since
> those features would only be of interest to DPDK devs.
> 
> Bruce Richardson (3):
>   build: enable a developer mode setting
>   build: hide debug messages in non-developer mode
>   build: limit symbol checks to developer mode

Thanks for the quick patches.
I like the idea.
Thomas Monjalon April 9, 2021, 5:05 p.m. UTC | #2
25/02/2021 20:50, Thomas Monjalon:
> 25/02/2021 16:29, Bruce Richardson:
> > To allow more flexibility in enabling additional build checks to DPDK build
> > process, we can add a developer mode option to the build. With this option
> > enabled, extra checks of interest to DPDK developers rather than users can be
> > done on the code, without having to worry about possible user impacts. The new
> > option can be manually enabled or disabled by using meson configure, but by
> > default is set to "auto" which means it is enabled if building from a git repo.
> > 
> > Once the developer mode is added in the first patch, the other patches of this
> > series turn off a number of previous features for non-developer builds, since
> > those features would only be of interest to DPDK devs.
> > 
> > Bruce Richardson (3):
> >   build: enable a developer mode setting
> >   build: hide debug messages in non-developer mode
> >   build: limit symbol checks to developer mode
> 
> Thanks for the quick patches.
> I like the idea.

There was no comment and I found no issue.
Applied, thanks